From: Sibi Sankar <quic_sibis@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <andersson@kernel.org>,
<krzk+dt@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <conor+dt@kernel.org>,
<dmitry.baryshkov@linaro.org>, <abel.vesa@linaro.org>,
<srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH V2] arm64: dts: qcom: x1e80100: Add fastrpc nodes
Date: Mon, 24 Jun 2024 15:29:57 +0530 [thread overview]
Message-ID: <7cc374b8-ebf2-0dde-2733-bb188e6591de@quicinc.com> (raw)
In-Reply-To: <2fb391fe-84ab-4c15-9d8f-4119bff0572c@linaro.org>
On 6/19/24 00:45, Konrad Dybcio wrote:
>
>
> On 6/18/24 16:56, Sibi Sankar wrote:
>> Add fastrpc nodes for ADSP and CDSP on X1E80100 SoC.
>>
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Hey Konrad,
Thanks for taking time to review the series :)
>> ---
>
> [...]
>
>> +
>> + compute-cb@1 {
>> + compatible = "qcom,fastrpc-compute-cb";
>> + reg = <1>;
>> + iommus = <&apps_smmu 0x0c01 0x20>,
>> + <&apps_smmu 0x0c21 0x20>;
>
> (0x0c01 & ~0x20) == (0x0c21 & ~0x20), is this repetition required by
> the firmware, or would it work with the latter entry dropped? (and
> all others in this cdsp fastrpc list)
Yes the latter can/should be dropped. Thanks for catching this. Will
fix this in the next re-spin.
-Sibi
>
> Konrad
prev parent reply other threads:[~2024-06-24 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 14:56 Sibi Sankar
2024-06-18 19:15 ` Konrad Dybcio
2024-06-24 9:59 ` Sibi Sankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cc374b8-ebf2-0dde-2733-bb188e6591de@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®