From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB60E1E3DEC for ; Wed, 30 Oct 2024 11:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730286571; cv=none; b=o1Oa33Z9BRmGaSUVi+IkhfF9FaGyf49/zSzDk4OwnJUo/fs3aJLkATCyakwMRRAR8Gg0ZrHdRBSWWlGTblcqBtKiVWmVEBbNQna10+Im33iY+sQFVvl5W+QQd35yxCFFoQCFkr3UEUTxcOeZqGiNcsmjGBK5SzrxiEgOwUFmT7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730286571; c=relaxed/simple; bh=mQaUzwaxnnqV45/x8tEAI39WnNj925wRWeOEbSeY/uI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BG74QH+4Kc5pcc4c2XzIX8et83T1qTQGQfu521BQtcCtRiRZcpjjGyYhbVZ9L8TWqYeUVz1h0FXA81lQPq287lFONCsmsKzN4IOyHgk6KgrJQWxyX7sgEIXCVGznLCFIRUIb3zqCj+RiL+La7tMJvHc/1y03CgopzNxvGXe+DsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kFt6riOe; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kFt6riOe" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-539f4d8ef66so8458107e87.1 for ; Wed, 30 Oct 2024 04:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730286568; x=1730891368; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mQaUzwaxnnqV45/x8tEAI39WnNj925wRWeOEbSeY/uI=; b=kFt6riOeslgr9ibbQBWoLzlp+k9h2TAaHmfwjEbqd7uQkrp2UPvOrWbZA+PNOqmsYf WyGQsJ1zh8xfgBntHkr9xUujqEFQ584rgvqViPHgZTwYx428K4cVSFSj5Xcmq0/lopgp i4E8c6iX939GWxXBJ2YkdRRrU74/DTQ54ikp3BAQRMh4zsdLZcp7wD6WBpvVQisLPEHO 6MiobcaF0aYkXesNsWnUsyOCXPBOWiO6Nv7elYBSmbGjFYgNCcUuf5C1qQneCR3QkfsF xtwfLlVznGE/DWDHu6sKcXmXH/M5CubWSgUPhSj3x8CyC6AH0Ki/z3yWRJB4uHuuKn/q nFXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730286568; x=1730891368; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mQaUzwaxnnqV45/x8tEAI39WnNj925wRWeOEbSeY/uI=; b=SrUKvqoNtyAIfeTE5ChpV4BX1EsNOmhmBCVc2UJaRZsvJmHssrB/na5+o4lUzxK8Hj v8Ut2O56/Bk0coVYvr/f9zmJDijKFm8EG5eeNcVGxBas2n0twWiiS59TohA+i26ZymB7 ijDX869zpVhoh5+eml/3eAlW4VUtQ4O0k3ExO8Uj79nSMsCb/GvVfl/pABokWin6Xcv2 i6rU6C1VQOP0tkMbHhRdxD3NLjvi+7O8BFz2pUye0gWA8cOlLeRIjjESLLVR/9ThGr6+ /YcYeLRpvH+KVzAosPO+GVdHpGjqrL9d8L+Dmg+/+JdHKCTBWa/yYrQVwnBrCoAnI2Cg cZhQ== X-Forwarded-Encrypted: i=1; AJvYcCXLLeexSMsrd7TA4QSMdzFBUiw+DbmL2RCOwvFh9JKIbzxxePO4wBzMwM6u/fIV500O3gvwJUZA1oPVwi4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0sET51b8YpLiJtAcBvE3GFphb2eU5DpvC9DtmsC91VshJZDGT d6I6ihniEDnbuKTH/n+PWKEzczxGoZXe+FanlOH33WfdLenA7fTrRdIx+WsOnC0= X-Google-Smtp-Source: AGHT+IFQvNMe1Knd6pNleviaqJovBHa2NbBVLssU/HpGHKZatxe8p94FQpXjkdGNR+UdreZfcJSkiQ== X-Received: by 2002:a05:6512:6801:b0:53c:7652:6c9e with SMTP id 2adb3069b0e04-53c76526f55mr415631e87.53.1730286567743; Wed, 30 Oct 2024 04:09:27 -0700 (PDT) Received: from [192.168.0.157] ([79.115.63.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd9ca704sm18186125e9.41.2024.10.30.04.09.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Oct 2024 04:09:27 -0700 (PDT) Message-ID: <7cc95e52-7509-44eb-8e30-d518283e7d87@linaro.org> Date: Wed, 30 Oct 2024 11:09:25 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] spi: atmel-quadspi: Create `atmel_qspi_ops` to support newer SoC families To: =?UTF-8?B?Q3PDs2vDoXMsIEJlbmNl?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Varshini Rajendran , Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea References: <20241030084445.2438750-1-csokas.bence@prolan.hu> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <20241030084445.2438750-1-csokas.bence@prolan.hu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/30/24 8:44 AM, Csókás, Bence wrote: > Refactor the code to introduce an ops struct, to prepare for merging > support for later SoCs, such as SAMA7G5. This code was based on the > vendor's kernel (linux4microchip). Cc'ing original contributors. I think it's fine to split sama7g5 addition in smaller steps. But please add the sama7g5 support in the same patch set, otherwise this patch doesn't make sense on its own. Also, if you think you significantly changed the code of authors, I think it's fine to overwrite the authorship. Otherwise, try to keep the authorship and specify your contributions above your S-o-b tag. Cheers, ta