From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC3B6257AED for ; Wed, 7 May 2025 11:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746619199; cv=none; b=YltrzWIhfhVsUfk1pkd+pyP5kvjkp2Q/sReCV6JpR97SL7XYlCNRFfp2GQpXNcJCCj/LdXj04neML/KeLjirINi7ciXmrZxPvlR6rtp3OX7I9wAaj9MRBa1T5f2VLLnRvJ0AA7AH+jumKTComI1ZCQlJRf8JtDAnbJMPaii7Cyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746619199; c=relaxed/simple; bh=qbnCw7dOQkq3nFndIdhgatR4r8qCPfL3w4RscWXHG3c=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=LPlMJSKRSrXkMddZdmgFSjs4uT8wZHfGr2SlsnCnqOfWynuj69G8h3n2IR/4H4sGBWBDhRSlmLONsf8QBT0/RiIbVFzhVANcnIo3b01WMe1MBq5fLYwK81EA1frqOGIp19zx+fbSLsJjSePBCOkpR+5grRyQCUSJ1PPX5Ds9WWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=j6f+0JzF; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j6f+0JzF" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso56531875e9.2 for ; Wed, 07 May 2025 04:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746619195; x=1747223995; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=CqPJI4HdquVpCx3k4hEKfR3V8+wlA5emf3OFZSQ9jYg=; b=j6f+0JzFQYl3GPNHcnI6Ch7j/dtyjYiKszBG2AbKIgQlBLvH/okBpQqj+O2tgFkIvA EBd2u5dNU7V9VDxa2mUqWvvg9x+2o98uVyWs8LM3vuOJTwvmUNHQNQnZoOT8pmdtmfPc lXpIUW9P0SoWMl3eTHP7p74PPs51rInyU7eUoNNVjrr543ChEFzOFTSOtVqoaYc9GGmo oVBjz5Nzhrm6BeckPNxEVJ8wGYiQ2/34FMSJRsWljB1H/XmQF4g6zMSwz7yJEA5R4Clb umeU/cPJkEaHy44QUWHoj9EGSmG8/frWcYO2vmqsxRl1Z0bMtoerKhewNVTPueiuzNDt AjFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746619195; x=1747223995; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CqPJI4HdquVpCx3k4hEKfR3V8+wlA5emf3OFZSQ9jYg=; b=keklw0G84tzhyefFhBeLqCdUGCQajcqk507mJUwr8/heff8GD7sK0rQTC8KMDaB/OL uO0CZIRbKJyxbsRc35DnrBwP4eDf8ALZe0lv2AW30XVTsnxribpByS+eykLG2Ok9gCDv Hlwzc65rRC/kLbr6bC9OXnlZ+B+bquqlKoxpE/Fp1KQF8lWT2HX6Ir1l3fb78x8Exx+D V+RVF8pHcX51XfY5abAGQascZCLmZo4FiGrdBEvEs0mkzGNWpruPjcmNKzlwHlExzsPj lNraATKnEaAQfZWVA27SJUsLSMn5VCq4kNd1UPQ5IotF/CRWOGaqJd5Kx18aO5BhEhM0 gQEQ== X-Forwarded-Encrypted: i=1; AJvYcCXnJt6NI52Je3YMR+yb2dxeKwSkmRc1QYXzSvu2FaoD1DilVK4F5g6IuMmNiogqb9elWW5V0wq85MCgrFw=@vger.kernel.org X-Gm-Message-State: AOJu0YwyINVhYh3u568SF8xoXF5ax7HKQxNNWgetALIzgS2z88Xlzpla 2H67FfqAAhctS9TZwAm+xZl/Ee+gePGz1Ibdv9DxBpuIVf0fAEDcPa4ZUlmXf2k= X-Gm-Gg: ASbGnct5AkY75/+yEJHvIOmCRZkxeMg/C133kTyQlRu18KkPf3h1T57yQk+Rj5LX+6M OEsCMZIfWQ/518eWsiPAiKB2qYaFYGYqDvAKkjj9mzUvSHxoy79YE+XeOcSOb+5y+1yQROpw6g+ K+R5nDcMnaNsMfaW1muDKg2nHDTVXD3qTZgPzDuSEOfK55oEWlQ0X76W50cOXq8oCiS+mYNv3Xc w3oJsuAbDuFjXWwFSXiGvtQVSZ+oL8nF2zyfFhEJMbTSxTn1AJllQiDNY8NvJMc96kwtjV/E9CR XMV94o8XlpvK6sWUPVVrcCEC0rLW4n+W4HTMUWk1WlvNJz5nRSnif4/h2sLE2ZB+uCqy/3Wz+su nISqfWPXABVEZAuznQQ== X-Google-Smtp-Source: AGHT+IFIxLzUQYS8WbSe7gjUBBLP5moevd2VzC6lwoikd3JqtPlVaRPaA2s8NpuN78U3XjMiFPwpFw== X-Received: by 2002:a05:600c:1c8c:b0:43d:683:8cb2 with SMTP id 5b1f17b1804b1-441d4eeb512mr15437105e9.14.1746619195054; Wed, 07 May 2025 04:59:55 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:784f:3312:6406:12a9? ([2a01:e0a:3d9:2080:784f:3312:6406:12a9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17096sm17206685f8f.96.2025.05.07.04.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 04:59:54 -0700 (PDT) Message-ID: <7ccbd722-c99a-43b3-9ceb-4c207521822d@linaro.org> Date: Wed, 7 May 2025 13:59:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/3] scsi: ufs: qcom: Map devfreq OPP freq to UniPro Core Clock freq To: Ziqi Chen , Luca Weiss , quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com, quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com, quic_rampraka@quicinc.com, konrad.dybcio@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, Manivannan Sadhasivam , "James E.J. Bottomley" , open list References: <20250507074415.2451940-1-quic_ziqichen@quicinc.com> <20250507074415.2451940-3-quic_ziqichen@quicinc.com> <7c74a395-a8b8-4a12-9ddb-691f28c90885@quicinc.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <7c74a395-a8b8-4a12-9ddb-691f28c90885@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/05/2025 11:09, Ziqi Chen wrote: > Hi Luca, > > On 5/7/2025 4:19 PM, Luca Weiss wrote: >> Hi Ziqi, >> >> On Wed May 7, 2025 at 9:44 AM CEST, Ziqi Chen wrote: >>> From: Can Guo >>> >>> On some platforms, the devfreq OPP freq may be different than the unipro >>> core clock freq. Implement ufs_qcom_opp_freq_to_clk_freq() and use it to >>> find the unipro core clk freq. >>> >>> Signed-off-by: Can Guo >>> Co-developed-by: Ziqi Chen >>> Signed-off-by: Ziqi Chen >>> --- >>>   drivers/ufs/host/ufs-qcom.c | 81 ++++++++++++++++++++++++++++++++----- >>>   1 file changed, 71 insertions(+), 10 deletions(-) >>> >>> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c >>> index 7f10926100a5..804c8ccd8d03 100644 >>> --- a/drivers/ufs/host/ufs-qcom.c >>> +++ b/drivers/ufs/host/ufs-qcom.c >>> +static unsigned long ufs_qcom_opp_freq_to_clk_freq(struct ufs_hba *hba, >>> +                                                   unsigned long freq, char *name) >>> +{ >>> +    struct ufs_clk_info *clki; >>> +    struct dev_pm_opp *opp; >>> +    unsigned long clk_freq; >>> +    int idx = 0; >>> +    bool found = false; >>> + >>> +    opp = dev_pm_opp_find_freq_exact_indexed(hba->dev, freq, 0, true); >>> +    if (IS_ERR(opp)) { >>> +        dev_err(hba->dev, "Failed to find OPP for exact frequency %lu\n", freq); >> >> I'm hitting this print on bootup: >> >> [    0.512515] ufshcd-qcom 1d84000.ufshc: Failed to find OPP for exact frequency 18446744073709551615 >> [    0.512571] ufshcd-qcom 1d84000.ufshc: Failed to find OPP for exact frequency 18446744073709551615 >> >> Doesn't look like it's intended? The number is (2^64 - 1) >> > Yes, this is expected. During link startup, the frequency > ULONG_MAX will be passed to ufs_qcom_set_core_clk_ctrl() and > ufs_qcom_cfg_timer(). This frequency cannot be found through the API > dev_pm_opp_find_freq_exact_indexed(). Therefore, we handle the > frequency ULONG_MAX separately within Ufs_qcom_set_core_clk_ctrl() > and ufs_qcom_cfg_timer(). > > This print only be print twice during link startup. If you think print > such print during bootup is not make sense, I can improve the code and > update a new vwesion. I think just don't call ufs_qcom_opp_freq_to_clk_freq() if freq==ULONG_MAX Neil > > BRs. > Ziqi > >> Regards >> Luca >> > >