From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A5B1325483 for ; Fri, 17 Apr 2026 15:28:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776439734; cv=none; b=tfW9fXoiECKGe5wFF05+xKgZiUpfFSQRph785GZHWCeVNzWyoC6mkklbUx+L6K1ORWpk9h8fl2ackQJ+/an0G8RGG6U003ZIA+MqDDWqu514p5UD0WWghKnxZGQ77G52FXd+RIoc6OFPcfu/fOB71bblOda3uXpBGlAjwU2QvtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776439734; c=relaxed/simple; bh=i77yRE8WUhFEs7+CBpzlx+r5MC6ikp723zTT7FvNvsY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=o1FePCwCUG8/JlKsXNkVE3KCreHO/Pduq5pvfP8skRYgIw38DRRQZG+U5WEBVEc3eFNoXI2/nJd0MwXhAkytSRYfryqyJicGjD7QsMwniSH4SXwoOLgrr4HgWupae6XTJQKHcupTLHHRQ75sRT+MbnnNUDs50A2y+jeE52grtb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Oi6Te+Y4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HydNxlpw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Oi6Te+Y4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HydNxlpw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63HC9RAO3942156 for ; Fri, 17 Apr 2026 15:28:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YaQtfdZufww/K73QQEA/A0d3XIh2ynwFA8tiiBqAF4Y=; b=Oi6Te+Y4gE+h0ub7 y6aiT0wkH1YE3pSd7X7Ii27zAY28xopCKQ2iKgZRr2E6SRo8QkUVJ/+Ni5SRfIDX yU031UGE+uu+vU0DOnu/Q/N19ULH3dh7Opl0eGDK3cPr5Sn3vIIF8mla8L/BXsw/ CPfJScm8mdfCWW4woWqKudKGRSeH66BjgSb2hEtGZvcEtMECVaTATqhnKtEgP1U9 Qk/SjyAFQKKRNoXCb7zvwC8cT+aaQOV6Ly4SbRFObHEhfjIrw57aR+zqaF90BkAH AGqwmKriE3TxwqSy1Dh07XRxg1br9hsrYGqP0MTssygjLus7onGHP5mjHSOxPhxX 0AEFaA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkg7rsvc6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 15:28:51 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35da8eb0553so943981a91.1 for ; Fri, 17 Apr 2026 08:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776439731; x=1777044531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=YaQtfdZufww/K73QQEA/A0d3XIh2ynwFA8tiiBqAF4Y=; b=HydNxlpwja+/pvZkZEbdMf/EwdroItGwZocSFOT74slwHFAznCuDZkwUUTFz2xvLii M4+3wLeTQ+yjPZZbP4/gba6wAsg1B2uGVC169a42TaRWAmJxt0ZPjPMMO13efbkSE6Mr Nq1UrCh1jSUEzmNTeNXaMd6gDOu2BqVmiBmlSmFFponlssszsNIez0fxAsmiq3wNU98M AJxPsyvElSQJ4p0Iouaf1scNMt1GjCY0FHl7SO2yGbzraeERBY/3q22AW9NPdt2FWGbf 2kO+9WonmdkNlHVks+u6roGOvKAiv65kbyo8r3Z/NHL68cMoLXZox0fYX/H6kSyfeLav 3jPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776439731; x=1777044531; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YaQtfdZufww/K73QQEA/A0d3XIh2ynwFA8tiiBqAF4Y=; b=L1EegsU/f8S0ySj6EhtrKgduALXfONnal94EL0vUKM/REod3LW4dJnJso6zNHERefN RVPr9c1h7kxBuKHfQ8K0p+3GhUTfMk18e03SK9j9tesOgnn3kag4FDixZOZlvtU7VPFm iL9zUi0i91W4DuooreOxA6zD5gk1o6kRXKludnrEabPUTdcKRgnr8PjPvUsd93sjn28z T0u03Gub+/dVOtmtZAFdd7aA2KdRmITGT4JlMeVDsmI0m6CpU3F66ZnJhTi338ETKxm6 oWizsWJSmFGaTFeFuDqcWio3qe+tf0/yoH/cj7KzMoSjn8KKYd8+4xd0GOn6uNEh08H+ TbdA== X-Forwarded-Encrypted: i=1; AFNElJ8GOn7m8dmgmkViYYZyoTrucV+U110U62uJVd48DIokHFuN16VrlFJJG1wQeAYmrGK7chJ0g0+0HJib5H4=@vger.kernel.org X-Gm-Message-State: AOJu0YwifwDhyw+NMMJKVJ8xWUCmySP8WrMjbqVr0zE3Ohfyq5O7lGT8 bHi6KFbDA0o7yNCNnWg1hTZ5M4xYx5Q9YMZ7pAy2dny2iSSmHVzUb1/J0+ufR58yH1UuKstT/GD Hd+YBCEimuLyhTiQHzJMy/eG6xb85tACJDqvRii3sJAmv6VpfZsHPlWtDl2z+gUZE9ck= X-Gm-Gg: AeBDievZQR6wiCnTyZsNboNucHLy+cxQz1CkWDuU7QbNEmDVK/OOBxaE5Inh9sdg+FG lmtDDxeiOJtiVAYoKLTIldwzbVHXKc5o3dhTl6hbn0s2b15Xi23Vu/LytxEk1IOkxAaAeQ+JN/A Uz7JcRWqW3pkJqHAu0RDsaOYwA3NdDJnfFikf1BOI23znC7HIUeX//Qy0GAVoK0X9YtzU1YUHXa LuW9+SONAfhmKTTwdci+rNhutr6JOEw2UXXbbxM2/85ofHII/siq5tW4ls2IhhUib5XRBwNJgFr ZFxcKYF3LxdmfROd8iE664Uv4I70eB4sZEPqNTFmM7r6DlUnTitRrlwalvImJnnNvgQUkayOTOz yKLaM0vj/lAfUbgBJwXswb+WR1cpqnhY9kWdLxFkNDBFKABdmQAGEvygLn1aUOHit X-Received: by 2002:a17:90b:3d02:b0:35b:d795:cf5d with SMTP id 98e67ed59e1d1-361401ec4b4mr2683451a91.5.1776439730730; Fri, 17 Apr 2026 08:28:50 -0700 (PDT) X-Received: by 2002:a17:90b:3d02:b0:35b:d795:cf5d with SMTP id 98e67ed59e1d1-361401ec4b4mr2683418a91.5.1776439730131; Fri, 17 Apr 2026 08:28:50 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614195a9fbsm3284378a91.11.2026.04.17.08.28.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 08:28:49 -0700 (PDT) Message-ID: <7cd1a0ff-53be-7eb7-7de7-420dd1ae7cf4@oss.qualcomm.com> Date: Fri, 17 Apr 2026 20:58:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Vishnu Reddy Subject: Re: [PATCH 06/11] media: iris: Fix VM count passed to firmware To: Mukesh Ojha Cc: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joerg Roedel , Will Deacon , Robin Murphy , Bjorn Andersson , Konrad Dybcio , Stefan Schmidt , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, stable@vger.kernel.org References: <20260414-glymur-v1-0-7d3d1cf57b16@oss.qualcomm.com> <20260414-glymur-v1-6-7d3d1cf57b16@oss.qualcomm.com> <20260414063325.f3yag6gnmaysddkp@hu-mojha-hyd.qualcomm.com> Content-Language: en-US In-Reply-To: <20260414063325.f3yag6gnmaysddkp@hu-mojha-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: KG-v0LeQT476cAEkKCPOsPERhlxcLoim X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDE1NSBTYWx0ZWRfX0JNZHKcL3U/z LpyJE0GJo1R2SzE4w8LsGKOHTB396Wqy8R0S/2l/1HX8FxONqTsnABiu82cy2Zo3Z8A+D7aHBh5 tjPUBkFf+czeqDRuQH3XEW1CeR/zJyO9Xapb/9BqdNxl072JCjiDttO1FuQe1KqMZGfkJXaAWJu wF+E0VOXnLJTby0Y+AA/lyYxLfy1wqGNp6RhOjw+vqKiJRhT5/OBiBYsEz15boGf5YfEstHCcnM PuMc+d6cU7W0cQWgR5Z6MEPltgm+HUWaw7jwFr3NWaqQ9FId/FEBD3u7zpU2yHD3oOEpaOOjwWb arhUktT/BLMJJYx02DERvqR4+5x8FrOqjNCMhb/xFbA90yD3VOVK57KKbQduxrQ5iXBQMHxpFlA sWB7aD+3llkk1VRSZWYzL/F9HWrhg38NybR87PuVaKDcLmMUIqbWgqbUdC9dGJQoNljLMAXzRBB 3z4eTQyVZstQ+gq0+9A== X-Authority-Analysis: v=2.4 cv=b4mCJNGx c=1 sm=1 tr=0 ts=69e251b3 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=5Xy_6AgtP5T3jK3p2aAA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: KG-v0LeQT476cAEkKCPOsPERhlxcLoim X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-17_01,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 adultscore=0 bulkscore=0 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170155 On 4/14/2026 12:03 PM, Mukesh Ojha wrote: > On Tue, Apr 14, 2026 at 10:30:02AM +0530, Vishnu Reddy wrote: >> On Glymur, firmware interprets the value written to CPU_CS_SCIACMDARG3 as >> the number of virtual machines (VMs) and internally adds 1 to it. Writing >> 1 causes firmware to treat it as 2 VMs. Since only one VM is required, >> remove this write to leave the register at its reset value of 0. This does >> not affect other platforms as only Glymur firmware uses this register, >> earlier platform firmwares ignore it. >> >> Fixes: abf5bac63f68a ("media: iris: implement the boot sequence of the firmware") >> Cc:stable@vger.kernel.org >> Signed-off-by: Vishnu Reddy > If this is a fix, should be the first patch in the series., so that it > can be applied independently. Ack, I'll move it accordingly. >> --- >> drivers/media/platform/qcom/iris/iris_vpu_common.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c >> index 548e5f1727fd..bfd1e762c38e 100644 >> --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c >> +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c >> @@ -78,7 +78,6 @@ int iris_vpu_boot_firmware(struct iris_core *core) >> iris_vpu_setup_ucregion_memory_map(core); >> >> writel(ctrl_init, core->reg_base + CTRL_INIT); >> - writel(0x1, core->reg_base + CPU_CS_SCIACMDARG3); >> >> while (!ctrl_status && count < max_tries) { >> ctrl_status = readl(core->reg_base + CTRL_STATUS); >> >> -- >> 2.34.1 >>