From: Oliver Hartkopp <socketcan@hartkopp.net>
To: jiale yao <19888972804@163.com>, Jakub Kicinski <kuba@kernel.org>
Cc: Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] team: reject ARPHRD_CAN devices in team_port_add
Date: Thu, 13 Aug 2026 14:01:36 +0200 [thread overview]
Message-ID: <7cd9991f-57d8-47e4-83bc-2dfeb8a844ff@hartkopp.net> (raw)
In-Reply-To: <6be0ce2c.3d2b.19fa728cd87.Coremail.19888972804@163.com>
Hi,
On 28.07.26 07:18, jiale yao wrote:
> Hi
>
> Sure, I will check, and send v2 patch if there are any others.
I've seen no follow-ups on this.
Did you check on other similarities between team and bonding drivers
according to reject ARPHRD_IEEE802154, ARPHRD_CAN and others?
Best regards,
Oliver
>
> Jiale Yao
>
> At 2026-07-28 09:24:47, "Jakub Kicinski" <kuba@kernel.org> wrote:
>> On Thu, 23 Jul 2026 12:00:32 +0800 Jiale Yao wrote:
>>> Enslaving a CAN device (e.g. vxcan) to a team master triggers a
>>> NULL pointer dereference in can_rx_unregister() inside
>>> net/can/af_can.c.
>>
>> Gemini review says that similar issue is possible with
>> ARPHRD_IEEE802154 devices, could you double check that,
>> see if there are any others, and all these in a single
>> patch?
>> --
>> pw-bot: cr
next prev parent reply other threads:[~2026-08-13 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 4:00 Jiale Yao
2026-07-28 1:24 ` Jakub Kicinski
2026-07-28 5:18 ` jiale yao
2026-08-13 12:01 ` Oliver Hartkopp [this message]
2026-08-14 13:44 ` jiale yao
2026-07-28 7:11 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd9991f-57d8-47e4-83bc-2dfeb8a844ff@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=19888972804@163.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®