From: "Nanzhe Zhao" <nzzhao@126.com>
To: "Chao Yu" <chao@kernel.org>
Cc: "Nanzhe Zhao" <nzzhao.sigma@gmail.com>,
linux-f2fs-devel@lists.sourceforge.net,
"Jaegeuk Kim" <jaegeuk@kernel.org>,
"Barry Song" <baohua@kernel.org>,
"Nanzhe Zhao" <zhaonanzhe@xiaomi.com>,
"Juan Yescas" <jyescas@google.com>,
"Daeho Jeong" <daehojeong@google.com>,
"Dev Jain" <Dev.Jain@arm.com>,
"David Hildenbrand" <David.Hildenbrand@arm.com>,
linux-kernel@vger.kernel.org, "Bo Zhang" <zhangbo56@xiaomi.com>,
"Kalesh Singh" <kaleshsingh@google.com>,
"Pengfei Li" <lipengfei28@xiaomi.com>,
"Ryan Roberts" <Ryan.Roberts@arm.com>
Subject: Re:Re: [PATCH v5 03/16] f2fs: support regular file buffered writes on large folios
Date: Fri, 16 Oct 2026 13:52:48 +0800 (CST) [thread overview]
Message-ID: <7ce0ac29.3f00.1a143452a3e.Coremail.nzzhao@126.com> (raw)
In-Reply-To: <1349f52e-af6d-48ab-b06a-4c8f5b3f7e68@kernel.org>
>> + f2fs_submit_page_read(inode, NULL, folio, index, blkaddr,
>> + REQ_OP_READ, false);
>
>@for_write: true? like we did in f2fs_write_begin -> f2fs_submit_page_read(.., true).
>Otherwise, it can run into mm reclaim after holding folio lock, causing deadlock issue
>potentially.
>
>Thanks,
>
>> +
In fact Sashiko also reported this issue, I've got a bit hesitated to chang @for_write to true
though, because I know that we already remove GFP_NOFS in folio allocation. And I also
check shrink_folio_list and study shrink_slab and swapfile in nowadays mainline and didn't
find a deadlock issue. But I do miss to take porting large folio on older kernel like 6.12 into
consideration. Anyway, I didn't receive report or test data on direct reclaim casuse by bio allocation
with GFP_NOIO, so I'll change @for_write to true in v6.
next prev parent reply other threads:[~2026-10-16 5:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:44 [PATCH v5 00/16] f2fs: support & optimize large folios for writable files Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 01/16] f2fs: extend folio state for large folio write path Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 02/16] f2fs: carry subpage offset and count in write IO Nanzhe Zhao
2026-10-15 2:37 ` [f2fs-dev] " Jaegeuk Kim
2026-10-14 6:44 ` [PATCH v5 03/16] f2fs: support regular file buffered writes on large folios Nanzhe Zhao
2026-10-15 13:11 ` Chao Yu
2026-10-16 0:04 ` Chao Yu
2026-10-16 5:52 ` Nanzhe Zhao [this message]
2026-10-14 6:44 ` [PATCH v5 04/16] f2fs: support atomic file large folios buffered write Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 05/16] f2fs: support large folio writeback Nanzhe Zhao
2026-10-16 0:39 ` Chao Yu
2026-10-16 3:57 ` Chao Yu
2026-10-14 6:44 ` [PATCH v5 06/16] f2fs: account large folio dirty data at block granularity Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 07/16] f2fs: prepare mmap write faults for large folios Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 08/16] f2fs: make GC migration large-folio aware Nanzhe Zhao
2026-10-16 11:25 ` Chao Yu
2026-10-14 6:44 ` [PATCH v5 09/16] f2fs: optimize small block size large folio read Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 10/16] f2fs: support partial uptodate " Nanzhe Zhao
2026-10-15 13:34 ` Chao Yu
2026-10-14 6:44 ` [PATCH v5 11/16] f2fs: handle partial truncate of large folio dirty subpages Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 12/16] f2fs: wait for folio writeback before ffs_detach_free Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 13/16] f2fs: fix zeroing paths for large folios Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 14/16] f2fs: handle block cloning within the same large folio Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 15/16] f2fs: allow large folio support to writeable files Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 16/16] f2fs: make compressed files compatible with large folio Nanzhe Zhao
2026-10-14 23:23 ` [f2fs-dev] [PATCH v5 00/16] f2fs: support & optimize large folios for writable files Jaegeuk Kim
2026-10-15 2:13 ` Jaegeuk Kim
2026-10-15 2:36 ` Chao Yu
2026-10-15 3:33 ` Nanzhe Zhao
2026-10-15 16:19 ` Jaegeuk Kim
2026-10-15 21:27 ` Jaegeuk Kim
2026-10-15 8:40 ` Nanzhe Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ce0ac29.3f00.1a143452a3e.Coremail.nzzhao@126.com \
--to=nzzhao@126.com \
--cc=David.Hildenbrand@arm.com \
--cc=Dev.Jain@arm.com \
--cc=Ryan.Roberts@arm.com \
--cc=baohua@kernel.org \
--cc=chao@kernel.org \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=jyescas@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lipengfei28@xiaomi.com \
--cc=nzzhao.sigma@gmail.com \
--cc=zhangbo56@xiaomi.com \
--cc=zhaonanzhe@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®