From: Randy Dunlap <rdunlap@infradead.org>
To: "Tobin C. Harding" <me@tobin.cc>, Theodore Ts'o <tytso@mit.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 4/4] vsprintf: Add command line option debug_boot_weak_hash
Date: Fri, 22 Jun 2018 09:21:32 -0700 [thread overview]
Message-ID: <7ce4d6ec-ef1b-1372-56bf-30ac1feabc9f@infradead.org> (raw)
In-Reply-To: <20180621231534.32278-5-me@tobin.cc>
On 06/21/2018 04:15 PM, Tobin C. Harding wrote:
> Currently printing [hashed] pointers requires enough entropy to be
> available. Early in the boot sequence this may not be the case
> resulting in a dummy string '(____ptrval____)' being printed. This
> makes debugging the early boot sequence difficult. We can relax the
> requirement to use cryptographically secure hashing during debugging.
> This enables debugging while keeping development/production kernel
> behaviour the same.
>
> If new command line option debug_boot_weak_hash is enabled use
> cryptographically insecure hashing and hash pointer value immediately.
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Documentation/admin-guide/kernel-parameters.txt | 8 ++++++++
> lib/vsprintf.c | 17 +++++++++++++++++
> 2 files changed, 25 insertions(+)
--
~Randy
prev parent reply other threads:[~2018-06-22 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 23:15 [PATCH v9 0/4] enable early printing of hashed pointers Tobin C. Harding
2018-06-21 23:15 ` [PATCH v9 1/4] random: Fix whitespace pre random-bytes work Tobin C. Harding
2018-06-21 23:15 ` [PATCH v9 2/4] random: Return nbytes filled from hw RNG Tobin C. Harding
2018-06-21 23:15 ` [PATCH v9 3/4] vsprintf: Use hw RNG for ptr_key Tobin C. Harding
2018-06-21 23:15 ` [PATCH v9 4/4] vsprintf: Add command line option debug_boot_weak_hash Tobin C. Harding
2018-06-22 16:21 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ce4d6ec-ef1b-1372-56bf-30ac1feabc9f@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®