From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0734DECE58E for ; Tue, 15 Oct 2019 08:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C43922089C for ; Tue, 15 Oct 2019 08:47:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="gc9Q/1db" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728685AbfJOIrE (ORCPT ); Tue, 15 Oct 2019 04:47:04 -0400 Received: from mail-eopbgr720078.outbound.protection.outlook.com ([40.107.72.78]:11232 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726430AbfJOIrE (ORCPT ); Tue, 15 Oct 2019 04:47:04 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IM/kU3VAwlPZRVTCMque8g9xqXXMaZKnG1RionkmAq8LyI3K1LqeEpk+w8dg7XNRfhZ6Mhe+DvKDsoi+V4O+rx1OS5Pa0CqXAd0bnef2PxfbBMrRYidV01aGAYOAdACg79Ll7zDbDDVD/8t8ZvbbmtyvF8B/kFJi/IWfHbeiSxn4J/wmSaJy0/1McUNJCw1CWTjOII4TZYQ3z5T9dvmvEBe/RZT6UWS3XnYFUWsKqw45YS2h2XisH26Gy7IllIrNLmQkN+Trb0vgLy6NNVUJSdDvrlbiVIrSOjwXi5aWemjnvSamZlWMFgfLqYCK/EK7ka+nXKf+tvhxoDeAQ7+j1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcLxa/n8yPMLHN09YrYmdFwSUuCRwXxvWWgs5hv9K9g=; b=mCj2h26UHIa5jCZskg+U6u8M/pbtteEVpn/oPy63QxZ8HE4J/+yDjeVHYpykenINXmIkq4V7I1hioXdZfbnPxChcn7FT9hoNK/l8hNyfmymib0vSiNMLT/0QqQA8ORJsMj2NM6gFqmvPfbzmAG5glisoqGj7GCPBybj+j3RBx8sX91l3Wc14HpT9ZkvYXXJnXkyp6GI/o0UiE7rzGAwe9vKj4qiLbQ5aT4EHxg+tDgT19yP4wabOqcHRfpYCwNctoXdBmDDpjXgb0pwGOi7o5ycdgE2wJEf75KstShMrZ8AtHRZT4UGPXCfZPshcxiiwr6sfePOyW1v7i8rFWpy54Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=infradead.org smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcLxa/n8yPMLHN09YrYmdFwSUuCRwXxvWWgs5hv9K9g=; b=gc9Q/1dbBAQ7dNvw2u2+XYRUSqGfNgrgWAoMQNIsYxFT6hmqKqoS2BExB3Gak3bceSsiHYmTfd9pXaNorcr3SobO7rkQ1am9ptGb3bwRh0AfHkhs2HzL6Sn1X4FhnzZQ9UvIAirYe3SGp2DT73B9/T+JNmUFy4Bs/J6viln9oOk= Received: from BN6PR02CA0046.namprd02.prod.outlook.com (2603:10b6:404:5f::32) by BYAPR02MB5205.namprd02.prod.outlook.com (2603:10b6:a03:6e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Tue, 15 Oct 2019 08:47:00 +0000 Received: from BL2NAM02FT047.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::208) by BN6PR02CA0046.outlook.office365.com (2603:10b6:404:5f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.16 via Frontend Transport; Tue, 15 Oct 2019 08:47:00 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT047.mail.protection.outlook.com (10.152.77.9) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2347.16 via Frontend Transport; Tue, 15 Oct 2019 08:47:00 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1iKITr-0003FD-Fs; Tue, 15 Oct 2019 01:46:59 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1iKITm-0005GJ-Cq; Tue, 15 Oct 2019 01:46:54 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp1.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id x9F8knUa027849; Tue, 15 Oct 2019 01:46:50 -0700 Received: from [172.30.17.123] by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1iKITh-0005Fa-Mv; Tue, 15 Oct 2019 01:46:49 -0700 Subject: Re: [PATCH] microblaze: Include generic support for MSI irqdomains To: Christoph Hellwig , Michal Simek , Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Kate Stewart , Kuldeep Dave , Albert Ou , Greg Kroah-Hartman , Palmer Dabbelt , Masahiro Yamada , Firoz Khan , Paul Walmsley , Andrew Morton , Will Deacon , linux-riscv@lists.infradead.org, linux-kbuild@vger.kernel.org References: <20191008154604.GA7903@infradead.org> <20191015074717.GB8715@infradead.org> From: Michal Simek Message-ID: <7cedfc62-b9ba-d1f2-e14f-93a64ad07fbc@xilinx.com> Date: Tue, 15 Oct 2019 10:46:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191015074717.GB8715@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(136003)(346002)(396003)(376002)(189003)(199004)(36756003)(31696002)(478600001)(305945005)(316002)(230700001)(106002)(9786002)(36386004)(58126008)(110136005)(54906003)(50466002)(2906002)(229853002)(8936002)(65956001)(31686004)(81166006)(76176011)(23676004)(186003)(47776003)(65806001)(2486003)(81156014)(8676002)(2616005)(476003)(486006)(356004)(44832011)(126002)(5660300002)(446003)(7416002)(426003)(336012)(11346002)(26005)(6246003)(4326008)(70586007)(70206006)(6666004)(41533002);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR02MB5205;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;LANG:en;PTR:unknown-60-83.xilinx.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e10634e9-b643-4753-150c-08d7514c3e70 X-MS-TrafficTypeDiagnostic: BYAPR02MB5205: X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 01917B1794 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CnCylBB9yDFqJQI5rjHdz+z6RHCaVVRL28mxlRltDT23kjZ36i26sWuJ156pzfCFPrCcOyM5AF9UJsIYKzzWUMciyGr1Lg6aHvP6yKNON8tjU+ckQlKnjJIo+4oRZEKVPnmmpLs/5AJ5nEKD5JJlHa0GyvnuzwvEoGfLer8xSNwSuhdBDGGln6+tudFb2sntKEfljy0RyV+jjHcRU7TiPA92Ljrgr/VOwZ8gr3N94HsBAQb7biVkP/G8BaJPZFFJ6NzT9D0zl3JX27oNosFKzwcoaiFOXNpvU72/VTAjfnPdiSHnAqj61niZ7CIumkjolvzhYss3w2f5IJyRNzI5bJQytZa7Jr7LEmVd74gFSX4nDaVD3Lm1re0YhLpRcqZ/6T2yDdhnpQpypZ+BbDC3tbZwGQhvH0Nu/UBXTU3TKj4= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2019 08:47:00.1380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e10634e9-b643-4753-150c-08d7514c3e70 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5205 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15. 10. 19 9:47, Christoph Hellwig wrote: > On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote: >> On 08. 10. 19 17:46, Christoph Hellwig wrote: >>> On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: >>>> index e5c9170a07fc..83417105c00a 100644 >>>> --- a/arch/microblaze/include/asm/Kbuild >>>> +++ b/arch/microblaze/include/asm/Kbuild >>>> @@ -25,6 +25,7 @@ generic-y += local64.h >>>> generic-y += mcs_spinlock.h >>>> generic-y += mm-arch-hooks.h >>>> generic-y += mmiowb.h >>>> +generic-y += msi.h >>> >>> Please just mark it as mandatory-y in the asm-generic makefile >>> instead of requiring a sniplet for every architecture. >>> >> >> But is it really mandatory for all architectures? > > What the mandatory-y keyword means is that every architecture that > doesn't provide its own header gets the default one, which seems > applicable here. Maybe the keyword is a bit misnamed and should be > default-y or something like that.. > > But in this case I think we have a clear case of x86 vs the rest, which > is unlikely to change in a major way. > Bjorn: If you are ok with this I will make the patch. Thanks, Michal