From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m21470.qiye.163.com (mail-m21470.qiye.163.com [117.135.214.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E37BC2E0; Thu, 25 Sep 2025 02:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.214.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758766637; cv=none; b=OlV8VLrGSOQCxsrNezTB6vPsxMROhJT8qo4exFuZfqOj9gBXUR603VgaMNpFNTnc3hqZPzD2j2NLq8T23U3vFD+k1n8akWDtBz3xzFnnRgniPXaTc+RsXTc/Z/wGRKXhiDz+vnP6bb7NInF3ITLk5vFxHX6Qsls0L7zFJxAjTWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758766637; c=relaxed/simple; bh=2vZWpSzNYela03bxYQwOWzTgdlsvks2tQABzUql3sQk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RcdFrcm21CP7J0Y1I5jG5faDCNfnhH80YQbnBReLh9cXLS+cUphrgM6XAtG+cpcpgimp/aMINgNMC8ZZnmL6kdPJbJiwkR6nB1H0TUO64lSvsFcpK7RRWg5ss2oSLncyGSRjeqFWnK47SPg/xdyfnGZwh1SG/zGeEJr521V9PsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=iVKD7f62; arc=none smtp.client-ip=117.135.214.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="iVKD7f62" Received: from [172.16.12.26] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 23f942a34; Thu, 25 Sep 2025 10:11:53 +0800 (GMT+08:00) Message-ID: <7cf14078-5d4f-4ced-bdcf-182371d0fd35@rock-chips.com> Date: Thu, 25 Sep 2025 10:11:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 13/17] drm/rockchip: analogix_dp: Apply &analogix_dp_plat_data.attach() to attach next bridge To: Dmitry Baryshkov Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dianders@chromium.org, m.szyprowski@samsung.com, luca.ceresoli@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20250912085846.7349-1-damon.ding@rock-chips.com> <20250912085846.7349-14-damon.ding@rock-chips.com> <2cu3ge6kjeibfznvt6c52xn2rp5zb3wk3pkb7gly34qrjlueem@7wqyowascpn5> Content-Language: en-US From: Damon Ding In-Reply-To: <2cu3ge6kjeibfznvt6c52xn2rp5zb3wk3pkb7gly34qrjlueem@7wqyowascpn5> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a997ea4309303a3kunm542c945b85b02 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGR5LT1ZIGh1PTEMdGUpDSx5WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=iVKD7f62uqeDZeWknCM50t4q+F59fTE4NNT58Y0093B07tMOfWOMy8AZVe6YOCr802f8Pf+EvfpvFbJEg2wVUjJcIBAH3suMh+XfmN4d3KXJXFGIQ0VcjzG3rZuDDk/5Md8wIwVl5DruEmeVZoWpbNKEhRNxy82ULkMok5Cfsmg=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=Ljhn8bif18aFps1rRdBClCGFFynJpfAeepmIW2TXY3A=; h=date:mime-version:subject:message-id:from; Hi Dmitry, On 9/12/2025 7:05 PM, Dmitry Baryshkov wrote: > On Fri, Sep 12, 2025 at 04:58:42PM +0800, Damon Ding wrote: >> There may be the panel or bridge after &analogix_dp_device.bridge. >> Add rockchip_dp_attach() to support the next bridge attachment for >> the Rockchip side. >> >> Signed-off-by: Damon Ding >> --- >> .../gpu/drm/rockchip/analogix_dp-rockchip.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> index 0784f19a2ed9..39f1ed293c75 100644 >> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> @@ -164,6 +164,24 @@ static int rockchip_dp_powerdown(struct analogix_dp_plat_data *plat_data) >> return 0; >> } >> >> +static int rockchip_dp_attach(struct analogix_dp_plat_data *plat_data, >> + struct drm_bridge *bridge) >> +{ >> + struct rockchip_dp_device *dp = pdata_encoder_to_dp(plat_data); >> + int ret; >> + >> + if (plat_data->next_bridge) { >> + ret = drm_bridge_attach(&dp->encoder.encoder, plat_data->next_bridge, bridge, >> + DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > Can this be handled inside analogix_dp_bridge's attach callback? I found that the &analogix_dp_plat_data.attach() callbacks of Rockchip and Exynos sides are the same. It should be nice to handle the next bridge attachment in analogix_dp_bridge_attach(), which would allow us to remove the &analogix_dp_bridge_attach(). > >> + if (ret) { >> + dev_err(dp->dev, "failed to attach following panel or bridge (%d)\n", ret); >> + return ret; >> + } >> + } >> + >> + return 0; >> +} >> + >> static bool >> rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder, >> const struct drm_display_mode *mode, >> @@ -452,6 +470,7 @@ static int rockchip_dp_probe(struct platform_device *pdev) >> dp->plat_data.dev_type = dp->data->chip_type; >> dp->plat_data.power_on = rockchip_dp_poweron; >> dp->plat_data.power_off = rockchip_dp_powerdown; >> + dp->plat_data.attach = rockchip_dp_attach; >> dp->plat_data.ops = &rockchip_dp_component_ops; >> >> ret = rockchip_dp_of_probe(dp); >> -- >> 2.34.1 >> > Best regards, Damon