From: Rob Landley <rob@landley.net>
To: Dave Young <dyoung@redhat.com>, Lichen Liu <lichliu@redhat.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
weilongchen@huawei.com
Subject: Re: [PATCH] fs: Add 'rootfsflags' to set rootfs mount options
Date: Fri, 8 Aug 2025 09:38:36 -0500 [thread overview]
Message-ID: <7cf546fa-d98f-4c9f-92ae-0bd26b9d1178@landley.net> (raw)
In-Reply-To: <CALu+AoTGwZqB28Z+sJ4KW7esNHx8=5kJ6nrMpoQ_rogzSDGwxA@mail.gmail.com>
On 8/7/25 21:30, Dave Young wrote:
> I do see there are a few similar usages in init/do_mounts.c, probably
> it is old stuff and it just works. But I think making rootfs_flags as
> an array and copying str into it is the right way.
The lifespan of the string ends before PID 1 gets launched. The copy
would be unnecessary and either perform an allocation or impose a
gratuitous length limit.
Rob
next prev parent reply other threads:[~2025-08-08 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 1:51 Lichen Liu
2025-08-08 2:30 ` Dave Young
2025-08-08 2:47 ` Dave Young
2025-08-08 3:36 ` Lichen Liu
2025-08-08 17:59 ` Rob Landley
2025-08-11 1:57 ` Lichen Liu
2025-08-08 14:38 ` Rob Landley [this message]
2025-08-09 15:02 ` Rob Landley
2025-08-14 8:13 ` Askar Safin
2025-08-14 10:25 ` Lichen Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cf546fa-d98f-4c9f-92ae-0bd26b9d1178@landley.net \
--to=rob@landley.net \
--cc=brauner@kernel.org \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=lichliu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=weilongchen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®