From: Zhao <zhixu001@126.com>
To: "Joe Perches" <joe@perches.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Greg KH" <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
rcy@google.com, rspringer@google.com, toddpoynor@google.com
Subject: Re:Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c
Date: Wed, 15 Jul 2020 18:45:21 +0800 (CST) [thread overview]
Message-ID: <7d0444ff.5c46.17352142e11.Coremail.zhixu001@126.com> (raw)
In-Reply-To: <128a9f7de9885257736b3bb2648ea90bcbc2c760.camel@perches.com>
At 2020-07-15 17:04:06, "Joe Perches" <joe@perches.com> wrote:
>On Wed, 2020-07-15 at 11:37 +0300, Dan Carpenter wrote:
>> On Wed, Jul 15, 2020 at 09:57:55AM +0200, Greg KH wrote:
>> > On Wed, Jul 15, 2020 at 12:24:22AM -0700, Joe Perches wrote:
>> > > On Wed, 2020-07-15 at 09:17 +0200, Greg KH wrote:
>> > > > On Wed, Jul 15, 2020 at 07:44:40AM +0800, Zhixu Zhao wrote:
>> > > > > On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote:
>> > > > > > A coding alignment issue is found by checkpatch.pl.
>> > > > > > Fix it by using a temporary for gasket_dev->bar_data[bar_num].
>> > > > > >
>> > > > > > Signed-off-by: Zhixu Zhao <zhixu001@126.com>
>> > > > >
>> > > > > Hi, there~
>> > > > >
>> > > > > Does anybody have any further comments on this?
>> > > > > Can it be merged?
>> > > >
>> > > > I never saw the first version of this, are you sure it got sent to the
>> > > > mailing list? It's not in any archives anywhere.
>> > >
>> > > I saw it. It's here:
>> > > https://lore.kernel.org/lkml/20200617161127.32006-1-zhixu001@126.com/
>> >
>> > Ah, doh, sorry.
>> >
>> > Zhixu, please address the comments given to you on the series and resend
>> > it as a new version.
>>
>> He responded but not as a reply to my email. It turns out I made a
>> mistake.
>>
>> Anyway, just resend, Zhixu.
>
>It's a pity a resend is being requested.
>
>It'd be a better process if the original patch could
>be applied via the link akin to a git pull.
>
Yes. All comments have been resolved by now. Patch v2 is sufficient.
As Dan said, there was a tailing thread because I mis-replied his mail.
I just now replied that mail with a reference to the final resolution mail.
next prev parent reply other threads:[~2020-07-15 10:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 16:11 Zhixu Zhao
2020-06-17 19:10 ` Dan Carpenter
2020-07-15 10:38 ` Zhao
2020-06-18 13:44 ` Zhixu Zhao
2020-06-18 14:03 ` Dan Carpenter
2020-07-14 23:44 ` Zhixu Zhao
2020-07-15 7:17 ` Greg KH
2020-07-15 7:24 ` Joe Perches
2020-07-15 7:57 ` Greg KH
2020-07-15 8:37 ` Dan Carpenter
2020-07-15 9:04 ` Joe Perches
2020-07-15 10:45 ` Zhao [this message]
2020-07-15 11:06 ` Dan Carpenter
2020-07-15 13:33 ` [PATCH v3] " Zhixu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d0444ff.5c46.17352142e11.Coremail.zhixu001@126.com \
--to=zhixu001@126.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcy@google.com \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®