From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24CA246775 for ; Thu, 10 Jul 2025 12:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752149455; cv=none; b=VJWeXJijc43FSk2DK1+0HKrQZvcnvmYMfEBw+Ojd0mIlRl79BEMBshq0lS0bEOr2FAcZP8CagGTkeOo4dUo7y1vca8iTFBttTzfL7/XSo0/aat9/KBo5LNUcJvvaCNO/ee49DXQ/S17E0EI2TmDEQDgEQWdDvAWNTbIT0irgfv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752149455; c=relaxed/simple; bh=3WpSLx1lOvBgBlWtCmaes9/MUjWZbRyaDXKVUI5jEkg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gaPaEP65GB+ZZjdIVnIOglq+Lg9iv1rShBosO4Iw3J5Jd3fIznZKCYjb9/VziyGRr0im/l4RoGzzVkqsW0Li63S4/fJ2TgERHE7oaCTdEdeW7xvODbxjct/0yIYeB5eVjAmbEg8KqFPpcRawRsDI9UZRNhfK73HcOFPc9lXDYjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HC4i460z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HC4i460z" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56A9VwDO016166 for ; Thu, 10 Jul 2025 12:10:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qylshFqGhjqdpqss4EWahA3a0P0XpI5R9ccWJmm4pUM=; b=HC4i460zUPUFENA3 MjRi8M3dzKhyuwssANgdh7k8mfip5nLU8X7F1JLj/sxneVaa7iaUdR15UzXVOO1F ImzFzHvTm3/blYiN9gmEt4eFM+SKwfcWqWcLM5UUWm+cNkd4TvGlDZQkev5fv2sT TcFrMkRA6al43ifj2jkubAJs3FrUfNvtZkkkcVcB4X5gGng2otxgKTuXqt6KlQyp dcUR+PaPy4JSoiLFp59cAR7s6aGWZ6mI3ejAN7yQdgXz2XAOshrFt26Xpk6Yu27Q bXAA1+6Ihl0EE1FsykzY+81TpsEqFSxeR8ojjOmPNiMs9ZCfJm++Ekb9bCaLzkT1 Z5N+Cw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47pvefrb8j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 10 Jul 2025 12:10:52 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7d094e04aa4so27742985a.1 for ; Thu, 10 Jul 2025 05:10:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752149452; x=1752754252; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qylshFqGhjqdpqss4EWahA3a0P0XpI5R9ccWJmm4pUM=; b=J6sTAQwj6GqL1VACXvANPHeF1iinnTCXmtMsXgYoPuEU743BJnWXgpqwALPDhwp+n/ VZGFGun3c+D30l217oAE2pOgLU77WprHaPo1uBThbulI2zWhyavC7wKbW4/J8hUoKdsm ZwaI78ufIfLSxDENiEYGkqqQMkZyhyzYYaU/VRsoW3KbZRYEL4h2oOGY+6mDWhs/a2d4 2UMLor7ddJqfboXXsUHT8E2/z5kH72m7fY2hoFpuhNjCf+6Uap76Z/KnB6xBF9KdSn+i l2ZAilXKfwvd8QjgYC1cx0QCzE9aQCi10uIPdiVD4OjIDcNJatmAKYo3CUs4BGIDScDU wvwQ== X-Forwarded-Encrypted: i=1; AJvYcCVDFm1/8rLarJ97VbpLmeYuBbylVZMIMnmOdVgFpbxw+GNLHi4Hom/9K/gstjOtDAkeFIJryYymHpO16H0=@vger.kernel.org X-Gm-Message-State: AOJu0YyaphgFjrVA9wLgUcCrS2I2exx89rZAB5sF2Ymjs+loTRBKslhu MYUVaHlVPlLFZVTS+Hcm14xZYzlg+JZ+C0Rf5HtrqS6PajLSeQs5pFrcuFrn5qIx9dvIYDbLL12 KE9+HX4yLalOrKRY/q6pNAQZekr8mr78NeN8zDHnWilq1oop82VPa/Uk97rn7WLx0WKU= X-Gm-Gg: ASbGncvy1rhnekpbu7sR3wXWJbJI3GZQzAbFVeYjI02vUlhfiQ0kHfRx/cJbqGZAI5U I0R1NvZ2z6sKW+m/x5f4xGIqWNnm63MDgv8dVNcypenzI+1bKQf8ATFp3aLdNiMtIhgMl/nzy18 tkhrkWdgio9j7g+vSweprg7ajsSqiMuH2Tgm6pg5Vp1SK7SkWV3gU2/i8GalXdz7za6yg98+11Q xDRNUweq3US1h69xtlm47D6/h8zX6xKA+DNR45c7skwqtPIaVssRkXX8kxGuYTP49x92NnLZ9Uh juEK0BHC4PbKPlDJZfez39gJNlpYEeNEYHBRVLNDLmqFiR5oesI4UHXz/OszZ6NFmE2TPOkXLyn qeCs= X-Received: by 2002:a05:620a:470d:b0:7c5:687f:d79d with SMTP id af79cd13be357-7db8ec65af8mr344977785a.8.1752149451770; Thu, 10 Jul 2025 05:10:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNdXIlzeTaHsQw8JV+VNgiKFo/GTeGYtHM7NPf/e+vpsxjpM2ZxW4+HG2cXIrSvCR3dYQdRw== X-Received: by 2002:a05:620a:470d:b0:7c5:687f:d79d with SMTP id af79cd13be357-7db8ec65af8mr344975285a.8.1752149451347; Thu, 10 Jul 2025 05:10:51 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e8294bd9sm121061566b.132.2025.07.10.05.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jul 2025 05:10:50 -0700 (PDT) Message-ID: <7d073433-f254-4d75-a68b-d184f900294a@oss.qualcomm.com> Date: Thu, 10 Jul 2025 14:10:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] phy: qcom: phy-qcom-snps-eusb2: Add extra register write for Milos To: Luca Weiss , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Kishon Vijay Abraham I , Abel Vesa Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Neil Armstrong References: <20250709-sm7635-eusb-phy-v2-0-4790eeee7ae0@fairphone.com> <20250709-sm7635-eusb-phy-v2-4-4790eeee7ae0@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250709-sm7635-eusb-phy-v2-4-4790eeee7ae0@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDEwNCBTYWx0ZWRfX590u+MlQ5Yds yanuax6IvWFmM1igdcTAZ531Y9Fl6r6OJnN3xwhxKqtZ6W+oYMU5mlbVcgn1nl8IdqQt3ATT5cF YYtYWwyRX+5iYVq6zriZz1Xvns1gyLhd/K9uqb2nPpfuR62v8A5FvXRpqXfu5pK5ddlXUwJrb74 9jNAbeGEsUY+7/MtjoRBtt8bPdAnHwjElStm82W8zXXsQSwJVV9vMLOQPm2tW7sXcIFkizoz9zl T9U+nIr6trtlJcmVEHA/XechrOgSu2LpwquXBlP7iiAwvWQWsEATIg2AkJyf/oKonWGZ+MpSmdg k1f28HK08STO5Tki+xhOMnWmRrcb5HswgOsYpevzcmVnSbZeEPvzYuRIBt0ZLODOUVfU94rIrXc rEY4HdDrIQck/WQOmQ4DQQuj+OfBtyEJ509P6KkHaOGAVJBtKuVW+iK7n9jtcHcUcxApeoZ5 X-Authority-Analysis: v=2.4 cv=dciA3WXe c=1 sm=1 tr=0 ts=686fadcc cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=KKAkSRfTAAAA:8 a=6H0WHjuAAAAA:8 a=JvZHP73eehLcbYbFTREA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: tnNdzhtgUmbF1uC2ZhbAf63u7-qJv1VK X-Proofpoint-ORIG-GUID: tnNdzhtgUmbF1uC2ZhbAf63u7-qJv1VK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_02,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507100104 On 7/9/25 11:18 AM, Luca Weiss wrote: > As per the downstream devicetree for Milos, add a register write for > QCOM_USB_PHY_CFG_CTRL_1 as per the "eUSB2 HPG version 1.0.2 update". > > Reviewed-by: Neil Armstrong > Signed-off-by: Luca Weiss > --- > The downstream driver supports an arbitrary extra init sequence via > qcom,param-override-seq. > > volcano-usb.dtsi has the following which is implemented in this patch: > > /* eUSB2 HPG version 1.0.2 update */ > qcom,param-override-seq = > <0x00 0x58>; > --- > drivers/phy/phy-snps-eusb2.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c > index e232b8b4d29100b8fee9e913e2124788af09f2aa..87fc086424ba4d9fb3ce870aa7f7971a51d4a567 100644 > --- a/drivers/phy/phy-snps-eusb2.c > +++ b/drivers/phy/phy-snps-eusb2.c > @@ -420,6 +420,12 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) > /* set default parameters */ > qcom_eusb2_default_parameters(phy); > > + if (of_device_is_compatible(p->dev.of_node, "qcom,milos-snps-eusb2-phy")) { > + /* eUSB2 HPG version 1.0.2 update */ > + writel_relaxed(0x0, phy->base + QCOM_USB_PHY_CFG_CTRL_1); > + readl_relaxed(phy->base + QCOM_USB_PHY_CFG_CTRL_1); Said HPG asks to clear bits [7:1] on all targets Konrad