From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>,
Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH ath-next 2/2] wifi: ath12k: refactor m3 and aux_uc firmware memory handling
Date: Wed, 4 Nov 2026 10:02:32 +0800 [thread overview]
Message-ID: <7d07b4b7-42f2-4367-b3f2-aa2ce5258747@oss.qualcomm.com> (raw)
In-Reply-To: <20261103-m3_and_aux_ucode-v1-2-e14f13fdfa41@oss.qualcomm.com>
On 11/4/2026 1:26 AM, Madhavan Ganesan wrote:
> ath12k_qmi_m3_free()/ath12k_qmi_m3_load() and
> ath12k_qmi_aux_uc_free()/ath12k_qmi_aux_uc_load() implement identical
> logic for freeing a DMA-coherent firmware memory region and for
> loading firmware into it (reuse existing buffer if large enough,
> otherwise free and reallocate, falling back to a standalone firmware
> file when no embedded data is present).
>
> Factor the common logic into ath12k_qmi_free_mem_region() and
> ath12k_qmi_fw_mem_load(), and have the m3 and aux_uc wrappers call
> into them with the appropriate struct ath12k_fw_mem_region and
> firmware file name. The shared free helper also clears paddr, which
> the previous per-region implementations missed.
I don't see that paddr is cleared in ath12k_qmi_free_mem_region()
next prev parent reply other threads:[~2026-11-04 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 17:25 [PATCH ath-next 0/2] wifi: ath12k: refactor m3/aux_uc " Madhavan Ganesan
2026-11-03 17:26 ` [PATCH ath-next 1/2] wifi: ath12k: rename m3_mem_region to ath12k_fw_mem_region Madhavan Ganesan
2026-11-03 17:26 ` [PATCH ath-next 2/2] wifi: ath12k: refactor m3 and aux_uc firmware memory handling Madhavan Ganesan
2026-11-04 2:02 ` Baochen Qiang [this message]
2026-11-04 2:03 ` [PATCH ath-next 0/2] wifi: ath12k: refactor m3/aux_uc " Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d07b4b7-42f2-4367-b3f2-aa2ce5258747@oss.qualcomm.com \
--to=baochen.qiang@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madhavan.ganesan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®