From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1B1A13635E for ; Thu, 19 Dec 2024 15:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734622613; cv=none; b=JqiTfN3dmoocG3AuZchCccEgnNthWCqy2HwIZnM9dTDHTKT/BFN/twSpHx0SzpurSwefcg+DC6A2F12eUZblZtI3I9bHkz3hvUd3esOK+s/KaPkJRqcrucOl6lzyzDk08nSQXkPqP3gQLVfwitOI/kaNzHoP12+tzb17dJkXUWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734622613; c=relaxed/simple; bh=Vg89KmiWFCLXKgHdoOHwLQx/nuLHQkuceIsVsvpTUFE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B1/9ifLErKguixI+/sup/hqVWCcNdz8+IkUkCs88fXPi3nFnRHNpS3xHmxwkPQS7EOrBsQP0XOK+UCpNDUBraIxbaIwy5yNk2brm1+aEtVLu7IgiHpZHL+978Uiu5ROW5iRoDyHH6z4xc7anqMXsxNwOE+EJVuDQpIRdAltoHww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gUnKDVAX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gUnKDVAX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734622610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IEDcFmKFnj28QqWPpPWrA6cMbTmaxl53CXDYM7xQ8cI=; b=gUnKDVAX2BHQ6OTuraakVprCAjNxovVwOJssyWPkEvJMJLaIoWFErEhAYox1BxZtH+OSYr qLJBvZLKKL6Kb8GBlFjxiT7pJ90PH2GxpzWv2+qhXe0WVBWow0GtxDH86hYGpp8DLRzMvm 8jEmXT2UARrICaMs0ZIPnkQApfHN4ww= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-tiPKV8qAN-2cz9tKXZbq0w-1; Thu, 19 Dec 2024 10:36:49 -0500 X-MC-Unique: tiPKV8qAN-2cz9tKXZbq0w-1 X-Mimecast-MFC-AGG-ID: tiPKV8qAN-2cz9tKXZbq0w Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385ded5e92aso428351f8f.3 for ; Thu, 19 Dec 2024 07:36:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734622608; x=1735227408; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IEDcFmKFnj28QqWPpPWrA6cMbTmaxl53CXDYM7xQ8cI=; b=nmMTPwrzpJ5fGPWKLpKTSPNiIJjK24lAUDEcDDdyblvK0cICUekKIrkwjbKfx6F19p farNmToylYFgPofXj9og8Uayc1BF9LH0aGiyRfPgtiCeV6/m6q5prJ/wBWqpcWAmEu6q yTWrCUCQJ/NXCuLPTfrFenX4zp3OkiXY4AM0M7IuNZ6X99BztFs1zIzEmGPQG0zz2wJA MorvIe5XhfdwMgFV0Z5ZeB/JqikPsrCcWjkgQCX1R1zY8bTOa3ZZ5JYm7DePxDife+hx gO+3BkbnHPD0QLjGXxX1+tHzCfeDr0BFJ7glLyVdPaPVTLS69s2DmzGcj5hmkPxk62P+ Phrg== X-Forwarded-Encrypted: i=1; AJvYcCXGImhvK/3NY1w8SJBtf3nkBm0kSerwR00P3jTg2yLnDfOiUDOSaIGiWO6wOcxtBtmm4MPCjIFqjejkLPw=@vger.kernel.org X-Gm-Message-State: AOJu0YxdDf+C9lzIx2y15eieNvoCQ4HRAjvy52PANhyHErFa1V5BC1zd 9F9rWaHKntGQPuJhPFqTo/HjmX/OKKFnlOgJjWl8oEmqTHwUDhBYjKVWMMjqYRdyL0Pg5Dm9YqB LC5728SXIEo4+1UWWsyy0BU+1QiOAPSv2w4U/R70NVw9d0TN+IAkLQeSVAWHFlw== X-Gm-Gg: ASbGncsaLFE+oK9B8G1GJL8C78hrUEyTyOwjP/ahrJWjnHICm2b52BQP7YS7J+k+XvW Pr5dvvx5FC2WtBfCj2lWbmCbtVEs7GNfaeaKmBRcy1yI4BdFJ28ct5dleeYqn76INEG8iQDLP+l Ug5RWQFIgeWRPhiH1eN890peBmYVtKGwsBAGa3pg+16gSsCoWX18/pI6D5ap+8DqyxbX2CYSL1k 6+ncH8rkZjbFON2QR+RnDc65jaTcxIHQy/TBbS+rwxm2IDKKVpmckcx9gOlUXMdNli1EKSFALWj J26zK8b13L9MWLV8P5HdswT1LKTaDT+M3pB2mIMU19uVbvj95ZafUr0PoqlRPcr3qserBYnKU9n fyGra4Q== X-Received: by 2002:a05:6000:1785:b0:385:f284:c41b with SMTP id ffacd0b85a97d-38a19af199cmr3601787f8f.25.1734622608052; Thu, 19 Dec 2024 07:36:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmyviwzK8JkoMaNZamKcvCHh3nNqblnLqH2R793cPaiAyEsJSLlH29r6r5uJRtnEk9879ziw== X-Received: by 2002:a05:6000:1785:b0:385:f284:c41b with SMTP id ffacd0b85a97d-38a19af199cmr3601767f8f.25.1734622607700; Thu, 19 Dec 2024 07:36:47 -0800 (PST) Received: from ?IPV6:2003:cb:c749:6600:b73a:466c:e610:686? (p200300cbc7496600b73a466ce6100686.dip0.t-ipconnect.de. [2003:cb:c749:6600:b73a:466c:e610:686]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e1a1sm1776658f8f.69.2024.12.19.07.36.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 07:36:47 -0800 (PST) Message-ID: <7d087c20-91f2-4c38-9ad8-7cd45a0906b6@redhat.com> Date: Thu, 19 Dec 2024 16:36:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: shmem: fix the update of 'shmem_falloc->nr_unswapped' To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <77d8ef76a7d3d646e9225e9af88a76549a68aab1.1734593154.git.baolin.wang@linux.alibaba.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.12.24 08:30, Baolin Wang wrote: > The 'shmem_falloc->nr_unswapped' is used to record how many writepage > refused to swap out because fallocate() is allocating, but after shmem > supports large folio swap out, the update of 'shmem_falloc->nr_unswapped' > does not use the correct number of pages in the large folio, which may > lead to fallocate() not exiting as soon as possible. > > Anyway, this is found through code inspection, and I am not sure whether > it would actually cause serious issues. > > Fixes: 809bc86517cc ("mm: shmem: support large folio swap out") > Signed-off-by: Baolin Wang > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index dec659e84562..ac58d4fb2e6f 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1535,7 +1535,7 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > !shmem_falloc->waitq && > index >= shmem_falloc->start && > index < shmem_falloc->next) > - shmem_falloc->nr_unswapped++; > + shmem_falloc->nr_unswapped += nr_pages; > else > shmem_falloc = NULL; > spin_unlock(&inode->i_lock); Acked-by: David Hildenbrand -- Cheers, David / dhildenb