mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Roger Quadros <rogerq@ti.com>, balbi@kernel.org, mathias.nyman@intel.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits
Date: Fri, 18 Nov 2016 13:49:39 +0300	[thread overview]
Message-ID: <7d09bdad-0618-c579-a9ad-2bac20a5b525@cogentembedded.com> (raw)
In-Reply-To: <1479394881-13863-2-git-send-email-rogerq@ti.com>

Hello.

On 11/17/2016 6:01 PM, Roger Quadros wrote:

> From: Felipe Balbi <balbi@ti.com>
>
> Some devices from Texas Instruments [1] suffer from
> a silicon bug where Port Enabled/Disabled bit
> should not be used to silence an erroneous device.
>
> The bug is so that if port is disabled with PED
> bit, an IRQ for device removal (or attachment)
> will never fire.
>
> Just for the sake of completeness, the actual
> problem lies with SNPS USB IP and this affects
> all known versions up to 3.00a. A separate
> patch will be added to dwc3 to enabled this
> quirk flag if version is <= 3.00a.
>
> [1] - AM572x Silicon Errata http://www.ti.com/lit/er/sprz429j/sprz429j.pdf
> Section i896— USB xHCI Port Disable Feature Does Not Work
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  drivers/usb/host/xhci-hub.c | 6 ++++++
>  drivers/usb/host/xhci.h     | 3 +++
>  2 files changed, 9 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
> index 0ef1690..c3c051d 100644
> --- a/drivers/usb/host/xhci-hub.c
> +++ b/drivers/usb/host/xhci-hub.c
> @@ -458,6 +458,12 @@ static void xhci_disable_port(struct usb_hcd *hcd, struct xhci_hcd *xhci,
>  		return;
>  	}
>
> +	if (xhci->quirks & XHCI_BROKEN_PORT_PED) {
> +		xhci_dbg(xhci, "Broken Port Enabled/Disabled, ignoring "
> +				"port disable request.\n");

    The messages shouldn't be broken up to facilitate grepping.

[...]
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index f945380..4f724aa 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1656,6 +1656,9 @@ struct xhci_hcd {
>  #define XHCI_SSIC_PORT_UNUSED	(1 << 22)
>  #define XHCI_NO_64BIT_SUPPORT	(1 << 23)
>  #define XHCI_MISSING_CAS	(1 << 24)
> +/* For controller with a broken Port Disable implementation */
> +#define XHCI_BROKEN_PORT_PED    (1 << 21)

    Indent with tabs as above, please.

[...]

MBR, Sergei

  reply	other threads:[~2016-11-18 10:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 15:01 [PATCH 0/3] usb: xhci: Add broken port disable quirk Roger Quadros
2016-11-17 15:01 ` [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits Roger Quadros
2016-11-18 10:49   ` Sergei Shtylyov [this message]
2016-11-21 11:51     ` Roger Quadros
2016-11-21 11:51   ` [PATCH v2 " Roger Quadros
2016-11-21 11:56     ` Felipe Balbi
2016-11-21 13:05       ` Roger Quadros
2016-11-21 13:09     ` [PATCH v3 " Roger Quadros
2016-11-17 15:01 ` [PATCH 2/3] usb: host: xhci-plat: enable BROKEN_PED quirk if platform requested Roger Quadros
2016-11-17 15:01 ` [PATCH 3/3] usb: dwc3: host: pass quirk-broken-port-ped property for known broken revisions Roger Quadros
2017-01-03 12:37 ` [PATCH 0/3] usb: xhci: Add broken port disable quirk Roger Quadros
2017-01-03 12:53   ` Felipe Balbi
2017-01-03 16:32     ` Mathias Nyman
2017-01-24 14:59     ` Roger Quadros
2017-01-26  9:19       ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d09bdad-0618-c579-a9ad-2bac20a5b525@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®