From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168002AbdDXJ2u (ORCPT ); Mon, 24 Apr 2017 05:28:50 -0400 Received: from smtprelay0175.hostedemail.com ([216.40.44.175]:47832 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1167929AbdDXJ2n (ORCPT ); Mon, 24 Apr 2017 05:28:43 -0400 X-Session-Marker: 69616E406162626F74742E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,abbotti@mev.co.uk,:::::::::::,RULES_HIT:41:355:379:599:800:854:960:967:973:988:989:1260:1261:1263:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1683:1711:1730:1747:1777:1792:1801:2393:2525:2553:2560:2563:2612:2682:2685:2693:2859:2901:2933:2937:2939:2942:2945:2947:2951:2954:3000:3022:3138:3139:3140:3141:3142:3151:3352:3865:3866:3867:3870:3871:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4605:5007:7576:7652:9025:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12438:12555:12740:12760:12895:13069:13311:13357:14096:14097:14181:14571:14685:14721:14764:14777:21080:21451:21600:30021:30054:30070:30090,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: head73_112c90187eb13 X-Filterd-Recvd-Size: 2318 Subject: Re: [PATCH 1/1] staging: comedi: addi_apci_3xxx: check return value To: Pan Bian , H Hartley Sweeten , Greg Kroah-Hartman References: <1492941175-9422-1-git-send-email-bianpan201602@163.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Pan Bian From: Ian Abbott Message-ID: <7d20a03b-869a-ffe3-b3e2-28a3350398b8@mev.co.uk> Date: Mon, 24 Apr 2017 10:28:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492941175-9422-1-git-send-email-bianpan201602@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/04/17 10:52, Pan Bian wrote: > From: Pan Bian > > Function pci_ioremap_bar() will return a NULL pointer if there is no > enough memory. However, in function apci3xxx_auto_attach(), the return > value of function pci_ioremap_bar() is not validated. This may result in > NULL dereference in following access to dev->mmio. This patch fixes the > bug. > > Signed-off-by: Pan Bian > --- > drivers/staging/comedi/drivers/addi_apci_3xxx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/comedi/drivers/addi_apci_3xxx.c b/drivers/staging/comedi/drivers/addi_apci_3xxx.c > index b6af3eb..a07d5bd 100644 > --- a/drivers/staging/comedi/drivers/addi_apci_3xxx.c > +++ b/drivers/staging/comedi/drivers/addi_apci_3xxx.c > @@ -787,6 +787,8 @@ static int apci3xxx_auto_attach(struct comedi_device *dev, > > dev->iobase = pci_resource_start(pcidev, 2); > dev->mmio = pci_ioremap_bar(pcidev, 3); > + if (!dev->mmio) > + return -ENOMEM; > > if (pcidev->irq > 0) { > ret = request_irq(pcidev->irq, apci3xxx_irq_handler, > Looks good. Thanks for the fix. Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-