From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C86A39E17D for ; Thu, 26 Mar 2026 20:12:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774555975; cv=none; b=kfVCJOeTT8AplkGbJWPMDzXO9CEY8LPpPsPamTfINTWPtQeCEy7zv5jaepxB0l4AsmtzQbsCTRQLs5Gz+hRlHjtwrribGPq7J6YaDqhMlJiqu7Q1Qk/8IWNNz6D8FXvtMBZ8JBgimFyMmB3CSndIbKGgYo7uEF70cOMZznBnkkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774555975; c=relaxed/simple; bh=5AkZwlLSAkMrjll6QfT18fZ0Lmy5ItVLit6autosngQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nupT0cTuymFpLJnRvEI+e1bY/0E15WqwRK4K3dKwsUupZmrSJr99C+u/oZIs3RbhienPfQ7Cs10JEZzeFnzwN4TojCQUXul7gKBnj0J2okQVPbN9yvvIUy8eKg8Hno+Ab8j65Buj/Rnlxb3SURa1792brS4yfAhT5Uedie66otM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GQySmhwv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IONOYrSG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GQySmhwv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IONOYrSG" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QGKek7638799 for ; Thu, 26 Mar 2026 20:12:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qsmz1RtLkSbASLYXXxlZoxnDX1y/ZiflBrWH0lwDH0k=; b=GQySmhwvWr292qvQ Bgk2fh9i76aQJFVMR7B5IaskHorUINoRFaADSIIgiRRUya4snLSS9ZZ8tgRpXJDT EopJIzyQ/7MrCqmKr7Uo1iuUVB2H44ektweW5InsuOO6VsbW0IW7XO164/XqgpwC 4wR3WoaYxtR1ZL1k1WoVOOKyWNOK8aQ8KLSRB4pE27hC4PPGdevI2q+Cyw2KdJJp ELW4/vEW1s8yyOxGgEM2GkI0LgjLaVyUC26YOGMbTmD7NQeWFK2Yxr0swus9ZKZk X7nD92gK+luVNm+F3wKGTZ2nsKGCPjX0CeDjKSqbh1pC/wT6V2LOYd80tnNn4l7L uLDauA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5883guhq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 20:12:52 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c76681f8074so963344a12.2 for ; Thu, 26 Mar 2026 13:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774555972; x=1775160772; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qsmz1RtLkSbASLYXXxlZoxnDX1y/ZiflBrWH0lwDH0k=; b=IONOYrSGrVVTHAZ2CDBTfLxJDPJOtCuNPvYDLIMJEbiBUahGdzgWi+foVsNkX08Akq JtM9LK+/0mMOZi9d0lJhZ2G1Wrjd4aglD9eoRXdF6BWuOf2hgqVKwmKwxSZUpQ4QVRDk z+veufh1Spw2i0D/1bxlWc/3l3ZJSTHBYvIGr48hAuteEbJRepsNjc5PW5NXGETAZQVY lLs4VyzACvyFmvoM2o4gqD1f6JcYxRMzScofbuohNuNo0f3YOT63Alnjfmb6M1/lEXK1 W2omoXyHVZ9v2bcrt2AZN/s5dt9Y/MNagc7QNPUFmoM0QAdEyc03bvOVwSU9am3qJ2al HZsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774555972; x=1775160772; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qsmz1RtLkSbASLYXXxlZoxnDX1y/ZiflBrWH0lwDH0k=; b=PhYAlQVMBFlxk9EKr285DslAqH+55nR7GINsM9g8LnEpLlCwUXy6N8JkaCjKxQL2/n j8O9GGKWDOvB0cI8aryD05mwwOgUsoS0Hy8wLGZqIynzEgnt0nqECEFWxbU/GMPSQMVj M/BtCDeBQ7C9cZZI2xrG3UCuTv+jB4OrcKK2fz0Z7WdfduMe0oE/Bn5AYlEhhnHAiFJn mLOHJxxLv3Pp9fu512Ccu6P4A3ut0hH2c7HDty47DUqGrLGrCq1A2xYmso7T83hq9GqZ e+01MLAAsNqeun2Te3xCdMUk03v1LzEJKzNaw45tpcnam9VHYfvxsU9iIBInvdPEvhsm Pirg== X-Forwarded-Encrypted: i=1; AJvYcCVosfw/R7oiRKwwk9s4ncIQdh4N6rYyFQYRZjVqKe9aOMRdG17+RzwWlC7N93a8ZK/Vfbn7JQniMh1Akik=@vger.kernel.org X-Gm-Message-State: AOJu0Yws3SJjBx6vlkNdSDW1BUVI/TA74esuD066ZXFz0wEGOFK+6k8t dhHn4Vm2VoJI9pn2ZpojxrFlT8l5WKVo0/D4CQTDFKlooARx5aFykBHq68kHdrsa/yC+TsDPMVV dNTHZGtVijSJHRnmGyczDPBtGi7ldGgWlRLyyR4PMC/1gkrte8keBwmNWMdMB+b+SH2g= X-Gm-Gg: ATEYQzy713/J7axcGLtrM/2zhiGXb0OWFjqNsTo+MV2TGcIXkxp8TjbF7XsFekpiAAb 6GhtyygLtR6Tut/lEu/OoLjc5Bk4DDjKzZvFWI1+/wEQQ7sLSj+0Y5m+2suFFNhkZCdnOOTcEyg GU/dRiOuG2LNNCE1pN337wwI59Ap7Q8Sja/bJC9VmnMb45JcJXxeIpTb2wGxI4IXXe2mZrGkDaL yrzupWhKqdmTwXrpOswC7osKpSQ3UQ28vq8Wq6UuhTzbi4RNGIbowSrfw0Qt2uLLFeLz2RiSC+S OVDNxH1ymVZLqqpvwtJ2Q/FMDAURL8tmKotY/QkjoYfxk75dsux9hzfl75EN6RcLL4Rn6DOt+r4 B7/AKpayCYOtQlFID3vMUmsaDWch+GxmbycjRccqLiSq9 X-Received: by 2002:a17:90b:5109:b0:35b:9777:8bb1 with SMTP id 98e67ed59e1d1-35c0dd951a1mr7211366a91.19.1774555972206; Thu, 26 Mar 2026 13:12:52 -0700 (PDT) X-Received: by 2002:a17:90b:5109:b0:35b:9777:8bb1 with SMTP id 98e67ed59e1d1-35c0dd951a1mr7211358a91.19.1774555971741; Thu, 26 Mar 2026 13:12:51 -0700 (PDT) Received: from [10.91.121.222] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2ebe2c98sm44495a91.6.2026.03.26.13.12.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 13:12:51 -0700 (PDT) Message-ID: <7d223573-438c-4e93-b4b4-64975c4da93f@oss.qualcomm.com> Date: Fri, 27 Mar 2026 01:42:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/16] drm/msm/a6xx: Fix gpu init from secure world To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-10-fc95b8d9c017@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: VvPrC6aPBj1Foe4yM1SDU0if8uBY9vuT X-Authority-Analysis: v=2.4 cv=bopBxUai c=1 sm=1 tr=0 ts=69c59344 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=SFlVdHt8JhaXNI1LWXcA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: VvPrC6aPBj1Foe4yM1SDU0if8uBY9vuT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDE0NSBTYWx0ZWRfXyNXyQqbfiyXD 6mGRl1U9FpugUoABvPwnIsb/olikX0PWXnk6FfTz6eO/pI/FQHOHjFrZDY9DbFni9DqzNGnGMds y8Q1UDatRZX0NRSomZW2wQ/YsHOYY6lbJNrRkk6Cjd73eB9zmS+0GwgzCehFXVxMtV/XFTJc0So KRZ+wZ0gGpXtNPNPNliijCDQRHUrDbDKvmyp3430NSq39LACbiiWip6W5k01h5h22XD2uFMirrG 686aDe7gmVNGCcJEQyLfcad6NUbiXkwAzKHg8nIHXbFiBpnBf2gK9kAT53I4g/ceDEXXUPO/zB8 LArBj9+2VgypAG9Ie8eHfBtScPSshRzgsR5Q9IwEN6+mYKNFsDolD5VGOwjzBfZ8eh2uLN6on+7 SU+u5RTqoIEaAOKjntUnJjmTm11GKrhFfo/5So7Lbg8V7e+3y+/fNS9DsZu0QwL/gaakXJB3sxF /NVlJlMNgVDNDyyImVQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_03,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260145 On 3/24/2026 3:37 PM, Konrad Dybcio wrote: > On 3/23/26 9:12 PM, Akhil P Oommen wrote: >> A7XX_GEN2 and newer GPUs requires initialization of few configurations >> related to features/power from secure world. The SCM call to do this >> should be triggered after GDSC and clocks are enabled. So, keep this >> sequence to a6xx_gmu_resume instead of the probe. >> >> Fixes: 14b27d5df3ea ("drm/msm/a7xx: Initialize a750 "software fuse"") >> Signed-off-by: Akhil P Oommen >> --- > > This now makes this happen on *every GMU resume*, which sounds > undesirable (kgsl does this in gen7_gmu_first_boot) I had this in my TODO list, but forgot to update. Will fix. > > Similarly, we call a8xx_gpu_get_slice_info() on *every resume* No. We check then slice_mask and return early. -Akhil. > > Konrad