From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88622335562 for ; Wed, 15 Apr 2026 09:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776245327; cv=none; b=mklR8+A5+UTQEfzVOxRFmVzKNvFCRp/GpfG4tuxo9E6QN/6mn1z0wzj92OG1/29Iz7TGTys0asf9b4BZq0HT68JM8Eu59yLAt8XdBqS+QF/uVlJuzDmiYlBU5hbhor8oCkyzvYVQ17uazTsdLSCMn3FHiceTwtUTytdMjGUmiKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776245327; c=relaxed/simple; bh=2M5+CsIlZRmP5Rp+ialR6inz9ixaMSwGSxDK7V3i1vE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SSvQtF+Aq/00jTcUHiEi0G1s9Uo72piuWy5CuwWC9iCQUnVNKteNpVhdIeTvzH7ocVuwwsqaCVzTMDpd8JqAXrw56yvHPiDl8suAFXmG9QBDb02qRqpKwKlyLPoT/YMQvFOWOFk3sxgh/Z9JZGy4LNmCN7Uox+F+OP5WC4dioRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NF3NoOib; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A3QJn4b+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NF3NoOib"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A3QJn4b+" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63F2rkkh731459 for ; Wed, 15 Apr 2026 09:28:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3M8LPszBnttqtBPzt5SqKBHeS1QcNQU5Hd5dp/o0B5I=; b=NF3NoOibaplmMS5p bcfH2nexAkbkvpLWKTBjpjcFWU1//E1dtwHqAY94YEkPXSRw6tOenC3tVNXBITCo GnjyuQWbIBDBsIPrrVc3ydotCYLZtX7nP7Sm3Lal1dGh09IuQqGM4hXNR+6QBeyy dGj34qWbeuY6Wm2/asTdApstMiHomDMCkXuW42iRdLaa7iBMt76obKF/qRkmxQid kz9TJhwAg+Dk49iYLmvs3yR9dtvWPv+HZm6NaxmsgXlC6W+aglvAj0NFuAvurwLH vVK4crWvDvRJMspLRMHDdAEts0IzihdtsGU5R2V/KCQXiHlSx0YytWXOXJa3XIYC PMVGiQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dhruub3qh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Apr 2026 09:28:45 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50dec198720so11506811cf.2 for ; Wed, 15 Apr 2026 02:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776245325; x=1776850125; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3M8LPszBnttqtBPzt5SqKBHeS1QcNQU5Hd5dp/o0B5I=; b=A3QJn4b+0MWBnu3Lx1nHEFs0KVvO7l/kpzbZpV7mQtqA1ih/JulY6LuTINGOKt5eiB +zmQmBKw3WVpyv0aRkmIGCM1aDDjFCLvCWOF6EPe5JSAH2rHMDr8vrNcF6holuHDwIyp avRFwizyEdOYVkMY47KYB7VvahMh+3SY56PEyiZHJQSqHyWSb5K2MWU8LUkPcD41V6I7 TP+1bK/I5d7IsfF5oPgKl2fuV/oj4Aj3TZhoEot5ggSuClkys2mSXgBA2xN38W//Tn2i 4a6Yl2aGfEFPdWnKHuaJnu1QFeu1hH+VmTWtT6prQZFh1UNbcbtaks1G+XL6M8X7hQWI 9w6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776245325; x=1776850125; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3M8LPszBnttqtBPzt5SqKBHeS1QcNQU5Hd5dp/o0B5I=; b=Vf5K4/UVqs1D3m6e5HT3nSeqe+isMHcZiSegBQzcvmd8SG8fVwpACGMIYuGdb2py7N COA8VO/GawwybpWKCzMyK3A8W3c7ljCBEBzX2Q29h85x7ZXBSUQbEWRhBqj6+lQXB3tN rTF4LfCPmAeGz48RQ/wmlnxwxHASIijZKjUzDEAUjIPXjKg44wv6HKFbKsUJXlkTtxDc Ngy4UrbeCwnTD5RTSCFnN4u/i8gILrg1qkwmuBULlBEslBnU/58q/bIJ/afgDbGm6Jqa HRAr7jmAtTqocGDYDBsC5SAe7QS5ZDGIhW24exn1PSy9WmhvF7eCD64wjIGWy4DTlWei hNsQ== X-Forwarded-Encrypted: i=1; AFNElJ+kPVLMIOgMnRqXGHJQ95bnE47ydwmtkglgDvIlDO3L+9Z58PUuHNQ64MNS7AX3g6V3LvF9rKKqN7Arz/M=@vger.kernel.org X-Gm-Message-State: AOJu0YxcSrDxS0JdWPoUFpOl+vsvec3xbswIe3UbBxKcLIT3FkbH3+Bz Z9DSTIAM/YLtqu1o3HkfnftwtKYegw4Yy9NW9ygfOLKXfXfi58nbvYv01+2gcjZJ/dchMG93+u8 ekeEXmOMltNUTt87SGc407XC7jtR9leh6m0wobWrEOftDu09t6URxrnHFMNi++QJ8b+M= X-Gm-Gg: AeBDiesFsUOPpt0fSFBg/+G7JC0U6Y52SkFr9nTW9/zF+ZDaA/PzQxvtz0dTcvRb7cL zbXksBNebVV4sVxgo52cykErH38LwAgwrPuilt2ekw/6WJ+NY6lVwAHlj+XMHjMT5Bu9SZ2KUeB xz7SFfav251SY72g/ZFZkbuC3+Z3DdAagJKdYGBWkORA1+1NhqpuL1fpId9KpKHFrSzyjurMJ4/ 4sUAaIGe29khqG766MaQpqzIpdCZ/N1aQRMwANrvQqAdIeVFSJ+APARU5smsEvrUjL/2n7BoV2r wve3rg2hBjEdRwpNwQJOVM2uHZovAyriF7/IY1jzYPRD7UH3BJXFGg4vxRhsZzT5Q/lGid+ndAd Yv/PoFW+rYtxJKtLcq5dCx9CO7it5sO3iZ9bjXfV2wY5QMqJOCxD0pKwOJW04YowbPZfAM0cyA4 tKJTQB1Blg3jiHdw== X-Received: by 2002:a05:622a:18a1:b0:50b:3489:5495 with SMTP id d75a77b69052e-50e1a7ccf1amr15897881cf.8.1776245324539; Wed, 15 Apr 2026 02:28:44 -0700 (PDT) X-Received: by 2002:a05:622a:18a1:b0:50b:3489:5495 with SMTP id d75a77b69052e-50e1a7ccf1amr15897551cf.8.1776245323940; Wed, 15 Apr 2026 02:28:43 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba1780b9c2dsm37412866b.59.2026.04.15.02.28.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 02:28:43 -0700 (PDT) Message-ID: <7d25970d-c2e8-432e-b69f-0da99271b581@oss.qualcomm.com> Date: Wed, 15 Apr 2026 11:28:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] ARM: dts: qcom: msm8960: add RPM clock controller and fix USB clocks To: linux@smankusors.com, Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Konrad Dybcio , Dmitry Baryshkov Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta References: <20260414-msm8960-wifi-v1-0-007fda9d6134@smankusors.com> <20260414-msm8960-wifi-v1-5-007fda9d6134@smankusors.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260414-msm8960-wifi-v1-5-007fda9d6134@smankusors.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: LV1nznfMzicjeUhvfQ6P-ojlR7jMiyjP X-Authority-Analysis: v=2.4 cv=dpfrzVg4 c=1 sm=1 tr=0 ts=69df5a4d cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=wxLWbCv9AAAA:8 a=1PKY5ISNgj2KPwyAcZcA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=QJY96suAAestDpCc5Gi9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE1MDA4NSBTYWx0ZWRfXzXciefSWgMiK 7IexBEzeafNmqm/5PS9ypeGZUO3KCz17ecPk67CpjxsibSmBiTe4QOgiXujg2twyo6eEVCiZE8s XRoIA350OB2439EchDsXTB7YADSa6RLOo4Y8JeP2hv8Zk2hlUtIWuxvUmAbM9w4a1A8/VQJO/Gt wm1GlbGBDx6lt5dFKbvL+tkjA0lOIzBNjT601UNqOFVVNpU/bebxd6mE5Pp/ErzE/6ObS05UzIr CoX87gWmV1qoejrrlgkrNNZ1jmB5nSRJn6A7qLjFZVdQaaYkOtAsQivyzsbTusW6XQ0EIwW/zsl cw00m0PLzQ66/5YcpGkj7fCVsfOgslk8ayl1TNs37xmCAK87AZsayM3l1qlO58rgsJyCAnHyL1q 5QVstasGUHkTMyEKlFEFpmhvqGW5yYSGvigG6/0QhNxoEohDT3GhGzq1bs2/HCYSeMS4TF2e/jc 0fFSUZ0i+QYs8cngOhQ== X-Proofpoint-GUID: LV1nznfMzicjeUhvfQ6P-ojlR7jMiyjP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_04,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604150085 On 4/13/26 8:55 PM, Antony Kurniawan Soemardi via B4 Relay wrote: > From: Antony Kurniawan Soemardi > > The RPM clock controller manages clocks shared between the application > processor and the RPM firmware, including fabric and bus clocks required > by several peripherals. > > With the RPM clock controller now available in the device tree, the USB > controller must explicitly declare its dependency on > RPM_DAYTONA_FABRIC_CLK. Without this declaration, the clock framework > would consider it unused and disable it, breaking USB functionality. > > This also corrects the previous misuse of USB_HS1_XCVR_CLK as the core > clock. The XCVR clock is in fact used for PHY/reset handling rather than > as the main core clock. > > A similar issue has been observed on APQ8064, where missing the RPM > fabric clock dependency leads to broken USB. > > Signed-off-by: Antony Kurniawan Soemardi > --- > arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > index fd28401cebb5..1d5e97b6aa4b 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -98,6 +99,13 @@ rpm: rpm@108000 { > interrupt-names = "ack", > "err", > "wakeup"; > + > + rpmcc: clock-controller { > + compatible = "qcom,rpmcc-msm8960", "qcom,rpmcc"; > + #clock-cells = <1>; > + clocks = <&pxo_board>, <&cxo_board>; > + clock-names = "pxo", "cxo"; nit: one a line would be preferred > + }; > }; > > ssbi: ssbi@500000 { > @@ -507,8 +515,12 @@ usb1: usb@12500000 { > reg = <0x12500000 0x200>, > <0x12500200 0x200>; > interrupts = ; > - clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>; > - clock-names = "core", "iface"; > + clocks = <&rpmcc RPM_DAYTONA_FABRIC_CLK>, I still have mixed feelings whether this should be a clock or an interconnect resource.. Some internal data tells me this is used by: * USB * SDCC * GSBI * INTC * APSS? * BAM DMA or anything that is adjacent to SPS. I think any/all clients vote either zero/off or 64 MHz, on MSM8960. It seems to be an IP that wasn't really used for a long time (and a long time ago, at that), so it's difficult to judge. I see that the list above is roughy in line with where msm-3.x attaches the votes (also for QSEECOM and friends).. +Dmitry, would you know more? Konrad