From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbcG0G6l (ORCPT ); Wed, 27 Jul 2016 02:58:41 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:7422 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbcG0G6e (ORCPT ); Wed, 27 Jul 2016 02:58:34 -0400 Subject: Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table" To: Max Filippov , Rob Herring References: <20160726180132.12764-1-robh@kernel.org> <20160726185030.GA1787@octofox.metropolis> CC: Chris Zankel , , , Guenter Roeck From: Kefeng Wang Message-ID: <7d2a3059-2198-521a-e102-891c7b393f58@huawei.com> Date: Wed, 27 Jul 2016 14:56:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160726185030.GA1787@octofox.metropolis> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.57985B3E.0085,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 832233e433d43e89736e7bdd2aa60c3b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/7/27 2:50, Max Filippov wrote: > On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote: >> This partially reverts commit 69d99e6c0d62 keeping only the main >> purpose of the original commit which is the removal of >> of_platform_populate() call. The moving of of_clk_init() caused changes >> in the initialization order breaking booting. >> >> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table") >> Cc: Kefeng Wang >> Cc: Guenter Roeck >> Cc: Max Filippov >> Signed-off-by: Rob Herring >> --- >> This is on top of Guenter's build fix. Please test and I'll apply. I Hi all, Sorry about the issue introduced by me, will be more careful, and thanks Rob and Guenter to fix them. BRs, Kefeng > > Tested-by: Max Filippov > >> tried briefly running under QEMU, but didn't have success. If anyone has >> up to date instructions that would be helpful as using these[1] didn't >> seem to work. > > I think they're up to date. Another thing that need to be done right is > the toolchain: it must match the configured CPU core. Please refer to > http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File > for more details. > >> >> [1] http://wiki.linux-xtensa.org/index.php/Xtensa_on_QEMU >> >> arch/xtensa/kernel/setup.c | 9 +++++++++ >> arch/xtensa/kernel/time.c | 2 -- >> 2 files changed, 9 insertions(+), 2 deletions(-) >