From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonic314-22.consmr.mail.ne1.yahoo.com (sonic314-22.consmr.mail.ne1.yahoo.com [66.163.189.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46DB92853F8 for ; Sun, 17 May 2026 07:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.163.189.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779001441; cv=none; b=FzgHGwo7spOiskdIr0JjOMfHt4r2GSyI+KNUssHCOE2wuscemzpFT2ZL8lW5dMe0AbkGD9ljs9ye5TzQuoo4JHhRJ1+47rlyvSvtQBoQB9mv3/sMEX9RWziSGsvgextBa1L6Z/EyOhnaYhCoi38/b6/3B2hJ6acmc0dPoGoaR+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779001441; c=relaxed/simple; bh=TxI6yUkOsCYt17vW77re+oBARTSLya4T3cCNoDeNAFc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=slJzFZTeo5dRC58h+bYi1I8g3AkxyC+w9i+sL4btcmfORXlJBzItWweclr+T9duNWMN4iZiNvxlQt+uUqm+A8h7oHJeG/7AL2lrLq1TUjoHj9VFsqnZ1uCY5UD92Ra27xykTMscXafY2z1A50z5DAapkEONSDk6CysU9cjsCJOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=VxV/6MDT; arc=none smtp.client-ip=66.163.189.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="VxV/6MDT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1779001433; bh=eqD48QuVXN8aWQrdlCb4t87R/mXMsQ33mIlYPls/ym8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=VxV/6MDTCZjz1cPjZUhhJe81OqyHyJTQzjwfzzSYd1HAlMTmOhWeBz+H5VYBwvrzYAZzEYizNS6CmfcFdyPITCAgL4WoHzIoHFNT/j5q5KL4ixmynwcvs93O/A9PCvVmjU8djG20pfVLJgCqr2SQwpg+4QPayRIgZw4k5Bt6nGbfPUSPr/QozCoS7QFh4Cnuf7bw39n487mPWxCfO2rHLM+4RIOmKR2EkcKuJsYfrPo/F0TBbhWA8JMa+/2YRZgUQWJQknG1tCFZFGYPHLfskvk4xWTIafAv2d29JODvasLjEwew89bLKJvfMuQkmRMemkV9S+0XZpMw8Dd3UUMHJw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1779001433; bh=9LfW2ol9Aor4XjcXPplmTYIB9eMd2NNZ9C3PfzomWCx=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=eJFN3XRhiQSFXKulOAjZNvRca67po+a2ynF+IJ/TX/JXkULXO2QCuGUjcCeB/Ewwock1T684I0ll5nF5SHO6bHywg0KXZ8PwBz/GMN8L87hBqy0xP/KajwVWSpYTg0n9eV4rUcyY1LHhdDRI+QRUEsCyPJxCq1mJAmEPlHU+9eIkJEOv4f12L5IzD8g8wqXdrkF+2F1/ydqPCD5mWdAZmqziqvxtqDrLp/MNYeGJ5kMbznByU1JPOqQBprH3u6wk0RMj/lTgBz7Vzs/Ymuf0QNGyBdVpHLpUESAq7gml+HbMDOaRFstXwqKEUycRf0HH0hkD/FQEQ0p0timeDesL6g== X-YMail-OSG: UGcplvMVM1mHTTSar8qDpsoJro7QCHxEa4Thd7IX2pfY7YvApyqDwq7f.LYFVbs wek6Zw4r0uATw76bS5IhNeK8q2FYnvnEos1nwthlzyIMjbrcPnvRoHiXbvoFS3EqKQUHSvJmWTdT 0QCeMZeizmdfL3lTY0YRfLPUvqZqmOXw2Dfkcpa34K2RqaaKL04qJBe0x4NU_.dJNTwTlxk7g4Di uyefDizBC_ztnogTQUJvYISE6UoAMRkuN0ut8UBKHsdb.J_Gw_KBHprQirBrpwmC6G7tST_nprrG QFVYGwNyxY_MtMXlnaJyLjrTmKafj4mw7TVCqn6_cmb6ZMcfG1e4GoszRTDfyYjbLvMStPjYhHLK rCho_VoWZ19YWtgYrvOq5XL2pha31ydPQ0CtqJvW0b9loZ0SEPt5klLaaJCBTMeiifqt8E6AoGYo FRDskbgW7BYT0kH7vPCbYQ6Nvs4vA.FoiwY1yU8w74vdKRL8756ifsCczkP2wYUSCofT6gpTpDRB y61nwI2H_twRza2i7eCacZeDGJ.1tpgUq9n37s0cGgu9tEtvZFqdlCPnnba2x4nD4UABDeo7dvYs xYnswkDLJSaMOcEj6K16SO3n1_EIvxig4UBCo9V1WjPiVUtTcxs3LfKNTRbbZNrPot5DuQBaeQrN 02JFnWR4E7b2Muo00dv9UYFyBVeJFvo68U1PHHo0G5THGHCJapYpUhMGGNaku9ftMm2RNsGYnVa_ gUMX1FBoc1csrXB5RMm1zQwp9347YBQfNgByR9u_kn7UBNFzs7FjCa7JkCiu6Rbv8PwLNHeMidpZ dy1oeQrmRtkEsIIyxNCfFzTzvZjBIhCl7P..Xg0cHtShalQxfePcVOADwm2M6XNnngThddVpPVDR 3Eb8.0M475u5tBm0kXGLOdmyhdpFSLMGuWJAjWpGBB2dle7TubvQ5xOHS8uo4.xBFq6zWICqn29A 63D1Dyckgl5vdgLkKvzzPqT.uXw26JHXH2BJZTqlQCiK97WVKfUpqsA5viCIfV6cHzt4mu6BXg5C m9XPajGT9RFhw560rHZyWQTE.OtCooUyjJeitZoqjeonhLCRAwohVPwXhelQTAWhCxROH6LJnSge 2hR__fDimxahAAXkkBSWU9lJrDAwWQK8rw6_ZPWDNlp5RdjhlfAdd8_zaKv5Q7ogbBky7tMsPDDl Q1WN0h54oJSyzAr_DIIyVkHozQZBCymZEdmnqw6PFMA8BklkMET2Jygweid0Ny3Upp.SiQQESfcs Jk5nKqBTpagNxWlXemEAnyQseyIlGWk2AriKiTjczfwJlHoibPo1q7QSWZtECSZ.csgXAvLhmZIe fdya0SqBmpNM1cfqnp5jnMl44IdQ_gKFEPeJhAWBt7R1cGPhv.UKhV0En1XwYgndzHcIfoPSFXa9 56naWDXA4Et14Gd8.x7CJN_yWpQ30DxcmOxd0ojOKuBiljuCJNPEf7wO1vN.RzwoO6EKQMTQ0FR2 aZ3qb6pGhPn3JfF8kJZy1deXSsZnQtiR1cZABAUNSDubLGdHrlj9LAkWW6RiCHLQ6whCZvjgo..g .b1rXmdR67mksjIL8I5RodYRQCdkSlz12QxbgSy0PjzDRlceFoTixHIfkPHnUBGyovZ9CqSVR1FP UwcgvF_RCU0kygpymO0EpaUkZrvUlOq_kk69FeSFHYVDJ3ulvnw8ZAw1lkPHrd5n2Adf0hECJLwe ic_AMuLgCKzegksTC3MH2szePvUA3cUW2FRJz1iljiN59dNjqXZiDye.8TvQ.hupKhoogfmKkIx_ SkHcO0eQxsAf2jVEbhNFqUyuxD3WUnqT1NVTUN2kbkvtxBop8rZ0YXvg2TIqk5NwHDcWguvO7_RG 7TViq_J4ThRgiCI3SsP2bI1V2X9tQ1OkX0TbwLFZ5JkaGjkp18VdJ04oWp3Z1LJgbklP_iq5Zky0 X7iVH1_K2wfbXY90.5mypLKtwsyr6pt7Tur.IyDVp8ADcf1SSRp7uA1UKxr97t4Jjm5tb69QBJSR cmS2NfyV1Y9p1AoLgxoHj3UqNhGso1HWTJX5WaeMGYRpTeSlO2eZ8HC2bnvyN_JnVHXlAG_oSjsv NGqhL9wDZvv1LwFsW8HsCP3CMILN1arw1AWRQfabk2HzLKqpMblvlVZ71N_1eJ5kOp9tAvtamYls J.WuUkf5pQ78pUVZhNQfn1F1Pm7nHic_BGNQMa3YN3SCt1jNcUA8DfIQY37qIpZDemXIruttpqLM zIBpUR4rJ4AXJ1dQMSrqefDJvcqT_YNDqRpLL_Gcvl2FHeD7ogkIjMGFdNYVlbMU1ehS.NxqMFXK d5kMtAd0jbhUYhRdSuaooOx_MgVTgW7IGgqyWQhWTD_dZdtQ- X-Sonic-MF: X-Sonic-ID: aa01225a-701e-47fb-b798-eb24c9899c5f Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sun, 17 May 2026 07:03:53 +0000 Received: by hermes--production-ir2-89844b765-6gbsd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2dac59f4c51d1cc16ebb8c72f4716054; Sun, 17 May 2026 06:53:32 +0000 (UTC) Message-ID: <7d2dbd71-b82c-4ff0-97ed-3af39143289f@yahoo.com> Date: Sun, 17 May 2026 08:53:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next PATCH v4 2/8] net: dsa: realtek: rtl8365mb: use dsa helpers for port iteration To: Luiz Angelo Daros de Luca , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Abdulkader Alrezej References: <20260516-realtek_forward-v4-0-8b6d6a1eefdc@gmail.com> <20260516-realtek_forward-v4-2-8b6d6a1eefdc@gmail.com> Content-Language: pl From: Mieczyslaw Nalewaj In-Reply-To: <20260516-realtek_forward-v4-2-8b6d6a1eefdc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.25725 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo On 5/16/2026 5:46 AM, Luiz Angelo Daros de Luca wrote: > Use dsa_switch_for_each_*() whenever possible. > > For port setup(), a new blocking setup phase was added for all ports, > including unused ones, before the user and CPU port setup. > > CPU isolation includes all user ports as traffic was being blocked in > some scenarios (suggested by Abdulkader Alrezej). > > The driver bails out if a DSA port is detected as the driver was not > tested in a cascading setup. > > Suggested-by: Abdulkader Alrezej > Reviewed-by: Linus Walleij > Signed-off-by: Luiz Angelo Daros de Luca > ---> [...]> @@ -1974,46 +1978,83 @@ static int rtl8365mb_setup(struct dsa_switch *ds) > else if (ret) > dev_info(priv->dev, "no interrupt support\n"); > > - /* Configure CPU tagging */ > - dsa_switch_for_each_cpu_port(cpu_dp, ds) { > - cpu->mask |= BIT(cpu_dp->index); > + /* Start with all ports blocked, including unused ports */ > + dsa_switch_for_each_port(dp, ds) { > + struct rtl8365mb_port *p = &mb->ports[dp->index]; > > - if (cpu->trap_port == RTL8365MB_MAX_NUM_PORTS) > - cpu->trap_port = cpu_dp->index; > - } > - cpu->enable = cpu->mask > 0; > - ret = rtl8365mb_cpu_config(priv); > - if (ret) > - goto out_teardown_irq; > - > - /* Configure ports */ > - for (i = 0; i < priv->num_ports; i++) { > - struct rtl8365mb_port *p = &mb->ports[i]; > + if (dsa_port_is_dsa(dp)) { > + dev_err(ds->dev, "Cascading (DSA links) not supported"); > + return -EOPNOTSUPP; > + } > Missing trailing \n in the format string. Kernel dev_err() messages aren't auto-newlined by the logging machinery — without one, this line will be glued to whatever subsequent printk follows. Every other dev_err/dev_info in this driver (e.g. the dev_info(priv->dev, "no interrupt support\n"); a few lines above) terminates with \n