Re: [PATCH v1 1/3] ACPI: button: Fix ACPI GPE handler leak during removal

[Mario Limonciello <superm1@kernel.org>]

On 5/21/26 08:32, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Commit a7e23ec17fee ("ACPI: button: Install notifier for system events
> as well") changed the ACPI notify handler type for ACPI buttons to
> ACPI_ALL_NOTIFY, but it forgot to update acpi_button_remove() to reflect
> that change.  This leads to leaking the notify handler past driver
> removal, which may cause a kernel crash to occur if ACPI notify on
> the given device is triggered after removing the driver, and causes a
> subsequent probe of the given device with the same driver to fail.
> 
> Address this by updating the acpi_remove_notify_handler() call in
> acpi_button_remove() as appropriate.
> 
> Fixes: a7e23ec17fee ("ACPI: button: Install notifier for system events as well")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: 6.15+ <stable@vger.kernel.org> # 6.15+

Good catch, thanks.

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>

> ---
>   drivers/acpi/button.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -689,7 +689,7 @@ static void acpi_button_remove(struct pl
>   						acpi_button_event);
>   		break;
>   	default:
> -		acpi_remove_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY,
> +		acpi_remove_notify_handler(adev->handle, ACPI_ALL_NOTIFY,
>   					   button->type == ACPI_BUTTON_TYPE_LID ?
>   						acpi_lid_notify :
>   						acpi_button_notify);
> 
> 
>