From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D55537DEB8 for ; Thu, 19 Mar 2026 09:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913173; cv=none; b=rytXFjaTsv9SIhWDpO/TE7miKbr4RDqk2LxKseuF4Yxo9tTEt2kynpqIBLcV9Eo2dzgB2JYNx4VOb3qO5l3IRgEuEzS2jXx86d5Nsbe5r6yRot4ipcLtXVKgioqmWS9qhivE4Y3c/HUiVUVqf2FB4AAXwX2der3gSsBDjvRMjS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913173; c=relaxed/simple; bh=JjicrlBfk9QqFJ2kpdakwIDVXV7/i/EQrkfucEboEHA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eJxXxVwSmkj7M5cH3xxxxA1L9HsRSN9CznRvEXOBkx5rUaV/PrPyObGZQVM0gZI4mKmFiYCDQNgC0lW6jOAyTEF5qImK17/fflhxk+9sX+DGE1dpKfarzxsCbFUGIf9eeaPJRcTXBt82van3LS2ItkpA4ENaM28bzzdR6CmHooA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HP4eVMtV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QZmiZJvX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HP4eVMtV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QZmiZJvX" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J741IP2883774 for ; Thu, 19 Mar 2026 09:39:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bZQ1JZfZf0V3b2o9DsRkzjevaQcj+BM7BVANfXVI76Q=; b=HP4eVMtVTbOXWsW+ nppDM8gMWfMyYCFG790YVY/aoyqToC0nn/4cqmpT1zlrOskNWyVYJMxfWBT97P2+ 6Q8X2GxNGWdzfHmaTdYZruseS9jlv0AkzcbUkxgAAokTrfxhL2gZpMuJqD31lnxl dbashY0pDeWFkJIEa7fWm3XKbuY0qdc++xecn1XEwI3LGdcJe3fuv/CazC/H4vPc m+cBp2JGk4lVNt93adVBt1tNl+nhXmopwyHo/lmSI36dYppfQ4xhI0+zSC65H+Me HdCmPc+LP6qBcS9zj8JUGyqODRZ1uZaFtZU/1Uz94lNpVK90jdbTNjtg3AkHFmAq nULnfg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cytxyuy7h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 09:39:30 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89a01982dc5so7225556d6.3 for ; Thu, 19 Mar 2026 02:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773913170; x=1774517970; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bZQ1JZfZf0V3b2o9DsRkzjevaQcj+BM7BVANfXVI76Q=; b=QZmiZJvXktQA2unJNg5vAzO7A0/YUgbhr7urnZHsKO2JUOZ8DxA+fyMXpM/QW2rKq+ OTWVDTzfrfAdr8yI7PnnDSjOWnwkoAqzK7cVMIr+ds5N49yFPcL+Nm1Wee6H9O53Pyq7 9O54Z3oMZowcYfnSt9aZ6aJ7QNJMeYwtJqlP3G2EH6WLIlPcdOJ/lyYjXjsNQeRDsLkd TFGi0ZIsX1CnD/JSiXbMU95d6x82SJi3QvLo9RPiTUjLHY11saGkYyUzYHqQGzbKi+GJ GateDWrQEPkPhMJxRUZeEWj7uTPYElNj3Vx2fux5XOeW3cav2jEbvsxhcPgJ4JOr5atd eltw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773913170; x=1774517970; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bZQ1JZfZf0V3b2o9DsRkzjevaQcj+BM7BVANfXVI76Q=; b=T2roRQ7vqM9+J3IEmAb8lLu1ZrrNsUHIs1FrRUfJG1PVNhR3UBqLU9jlBzVgXxJqiT wPcYCjikVIvfY0gd74Km/cdKDPmowELSTuScf9dICQHmijvYvjEQYmgpKUchpcqGzKS8 jwVuxQL7PDqQyXCCN2ssE4dLVXn34RPsTJCy0hrYDCft4gFj+2BaBMA88hrP77LP536b JeHX8VRiTtpLXkjrVIqSHSyL1YsnnGaQs6oUzWkL7Lnlys0MB/i+iymJUrnnB/H2xACe DWVZoiRu6CMAvCUSiCBVW/iItOsOGIV/Ox7iZUe1tTyjDviHRIUCDl7eOjoi5SqYGvS5 Z8BQ== X-Forwarded-Encrypted: i=1; AJvYcCVnRbNk11KAF5W5W7MMNOzcSYxkWmLZizgx6keWnP5NIac266iNqGpqO3A+wi0Li8IKtoxQledtvb4VlRs=@vger.kernel.org X-Gm-Message-State: AOJu0YyLbDO0E5Pjmo/+aJsKWYgG5S+rgblEhRpVn1rOK/ulk0EieHMQ BWZ1v0D1z1H4Bo9d76lX7WveyCODWXyOjw1Mn1xGb6knCyXpkW+CIGj9B709trdIzsuVXKQesGj HKQcK938quA5t2BLOsILBDVcDuIwrhl4Hhqw6uiwzDDqvsCUPP8W2c4GStYBr7USVsMg= X-Gm-Gg: ATEYQzy7HbUKwFU2NZgbuT/U0PapB2YHYXe8F/J8vMJklOaN9x5TRUzZzdgW93sR4JG kfaRB+H7txEKmkfGv8CEljDed1Is3r9dCdIMrVHhXcLLoA/QsG5zyol3WWqfX7ZLJ4gc96BCpWx a0kk4q4GwvK+AZ/u57fqrIuj7WhRn2tlYEMkfhpvAg8pYwXwAfEYiYkvQbfJbecT4ZrKDSLjdCF KslpEAIsJX3i+nEF73qaDdhXESZpG+qc2mWkj+iK0a+wl54wBqM9qwyoh4EQ+RJHCpIf3vNvX2h l3PgbdTNNCk1RsAgI6kPJAJMlqmPo3KdDLxRcEEFwibtoFh+pksE6a/TZNH8O7kySnpXoh/QUGa mNvoO7wg0OCUjjdhY3W68iRNCUIrkxCB+aKjh10TSoMQITEc/mCBg1yuuC/hi3mBckCmGpfjkQg Z/Ipw= X-Received: by 2002:a05:6214:411a:b0:89c:51d0:20df with SMTP id 6a1803df08f44-89c6b5bfd2cmr73428426d6.3.1773913169756; Thu, 19 Mar 2026 02:39:29 -0700 (PDT) X-Received: by 2002:a05:6214:411a:b0:89c:51d0:20df with SMTP id 6a1803df08f44-89c6b5bfd2cmr73428036d6.3.1773913169232; Thu, 19 Mar 2026 02:39:29 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f13e989bsm429275366b.11.2026.03.19.02.39.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 02:39:28 -0700 (PDT) Message-ID: <7d31ca0e-063c-4cae-be82-41f5f80238a6@oss.qualcomm.com> Date: Thu, 19 Mar 2026 10:39:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] drm/msm/dsi: Add support for RGB101010 pixel format To: Alexander Koskovich Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20260318-dsi-rgb101010-support-v2-0-698b7612eaeb@pm.me> <20260318-dsi-rgb101010-support-v2-2-698b7612eaeb@pm.me> <5b79ccbd-5c75-454b-8b3f-812a6c59157b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 52NZLnFVPl5LaavhbO1nPJmfBPFkbOVd X-Authority-Analysis: v=2.4 cv=FKAWBuos c=1 sm=1 tr=0 ts=69bbc452 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=tXHaASYRl17ePNmWAmoA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA3NiBTYWx0ZWRfX4jSPtu9amUhn oWH4avgLT0981ELAnuR/nG9tZzHDLkbFFVZe30vSUJRi3BFtzqPAVn5lfx5TuN99Uqi9GAV5lv+ CjqaERsEeEiiwudepf5UOb6I2z2twrcFlidg6/aOe+g6Pnkn0ufLwwqPcFtKsyCQQkbX0y3y6v8 5yh05ZXve2h7H3tE2lSC5twBGGT8RqtVAbYR1QCDfHxpZO97O0pzUqHPKqPhASO4hotmJxRifHN J0CzFuG49IpyMujvfG7w594aXa+boLE4+gBfKDynSPZEhpUMABLjXDoJJIVDjH9vg07CA2nawuw OG6VRuEdcUA0u0hb9Ffe07aeWGyPlWlEx1JJNcdHQRuflCCpWYtS2OUJkmccn6vFS98NW2edqQx /FHgSHit4kqJ6azSKfLsuT5V2fuTXORWt+xCofIco+rLPmvd4AWcgvGA+gmGEdffrku0e1D5oFS N8lqbqPqvJKjB0MAPAg== X-Proofpoint-ORIG-GUID: 52NZLnFVPl5LaavhbO1nPJmfBPFkbOVd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190076 On 3/19/26 10:25 AM, Alexander Koskovich wrote: > On Thursday, March 19th, 2026 at 5:10 AM, Konrad Dybcio wrote: > >> On 3/19/26 5:00 AM, Alexander Koskovich wrote: >>> Add video and command mode destination format mappings for RGB101010, >>> and extend the VID_CFG0 DST_FORMAT bitfield to 3 bits to accommodate >>> the new format value. >>> >>> Make sure this is guarded behind MSM_DSI_6G_VER >= V2.1.0 as anything >>> older does not support this. >>> >>> Required for 10 bit panels such as the BOE BF068MWM-TD0. >>> >>> Signed-off-by: Alexander Koskovich >>> --- >>> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 8 ++++++++ >>> drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + >>> drivers/gpu/drm/msm/dsi/dsi_host.c | 9 +++++++++ >>> drivers/gpu/drm/msm/registers/display/dsi.xml | 5 ++++- >>> 4 files changed, 22 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c >>> index bd3c51c350e7..6a7ea2183a3b 100644 >>> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c >>> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c >>> @@ -133,6 +133,7 @@ static const struct msm_dsi_config msm8998_dsi_cfg = { >>> .io_start = { >>> { 0xc994000, 0xc996000 }, >>> }, >>> + .has_rgb30 = true, >> >> I wrote a patch to determine this at runtime, and only after I was done, I >> noticed that we can already achieve this: >> >> bool msm_dsi_host_is_wide_bus_enabled(struct mipi_dsi_host *host) >> { >> struct msm_dsi_host *msm_host = to_msm_dsi_host(host); >> >> return msm_host->dsc && >> (msm_host->cfg_hnd->major == MSM_DSI_VER_MAJOR_6G && >> msm_host->cfg_hnd->minor >= MSM_DSI_6G_VER_MINOR_V2_5_0); >> } >> >> let's perhaps extract this to a msm_dsi_host_version_is_gt(u32 major, u32 minor) >> or similar > > That's what I was looking into initially, but V2_2_0 (0x20000000) is numerically less than V2_1_0 (0x20010000) so didn't think I could do that. It should be v2.0.0 (0x2(zeroes)) v2.2.0 -> sdm845v1 (unreleased) v2.2.1 -> sdm670 and sdm845v2 Konrad