From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1285A1F37A1 for ; Thu, 20 Nov 2025 12:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640668; cv=none; b=LW1ygsZmfCQEww1j1U0kmuqkJHbvtxsaMhYYmWewib9Ja1NTGCKq1HRjxIOYSRiu1l8ekaD98Er8LgubsAcbwZmxAtdQYW818XtHhhVWqfdbdUqXaa2ZTawfeDa0V+v3oMCKR5q7dJGr9dW81MCRPawuHMiSTU70D4bgz2XpZRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640668; c=relaxed/simple; bh=0cfT3bgRQbsxGmTKccy05AiwguLM7Q2MsBKOaWKIdfI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QXB6smnwQkmPEf4fvybETwoeVeoG81NKchfcbjTy7jfldiaBiZjiLr+nahy+sHCH0glloQFSkeaaQ08fwijUyuu6L9ak0fhD72VSUDivIGxBclqNHKWd2YrZZGy1rX+JF6TDfMkbtmh7BN/zOgLpmm7A5rjVJXyyvcEelSl6h+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QYQujI/I; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TBo+iMi6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QYQujI/I"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TBo+iMi6" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AKAgW7B417946 for ; Thu, 20 Nov 2025 12:11:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kybWWPjVRqLZtCLxRW8OdT69bB3HpyM4+4Y1yEo1/Vc=; b=QYQujI/IgdfnDoLr z5pme9U28TsPB1q+c6F3q5hir96TghVshozPpk/ZQUp9pX9x/z8Si0Wib3vYToDU mER94FOk/BXhPwmuECClTidqxEn4sZ5P17mShAlZdGpou8Y0JmKHdzGHrFJhYCSf SM8k5FR1sv2sonpUdTjgdl1q4Y7mP0GTxWRSXqnU/L6LP28xtL2Xyic9bR2+j9ZU O5MtF0ExbUiSbMHkKW9i5YfD/0/0ulpuDTQMASudXvlLL+Jp/7kVv3dRjKSUdWhf QtYSBRgNgvXEslNxruAG7F5kfDQIwGbpIaajLJ5wr0wcsk3HxoWh3XLwDvSbP2Sd znUVSg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aj1fgr7s6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 12:11:04 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ee24e1559aso2412281cf.3 for ; Thu, 20 Nov 2025 04:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763640664; x=1764245464; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kybWWPjVRqLZtCLxRW8OdT69bB3HpyM4+4Y1yEo1/Vc=; b=TBo+iMi6pGZ/Lh+2yBQdDMTFS6HRpDye+WWZ5vPmwg0AwB47r7nWB2GXmXqOBI67UJ NjhIhx/uak+94AxuckIfaDtDe/rPjjV0HtERWDxCCpmWT913h839LJ0KwuQsrFYDouAv jX3yOpxkpAz0tgPTzz9E+Di4BLXSbgqD+a2Y/VXIf03vMOBQCL1OYsQxAnBPH1QENnMp KOV0ZNsXWK2nWGPGVnwL2MF4nEsMPnFmbY0hobG1abyKqcr8VLxygbcshP8D0lrhW7E+ XLfYZ8DVYOebf1mBdyehdvZN2uM5Kb+al8WuDHd0ap4TPOekgJjRNe+C5CimgXnF4Mhn 6/Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763640664; x=1764245464; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kybWWPjVRqLZtCLxRW8OdT69bB3HpyM4+4Y1yEo1/Vc=; b=rfcVPgK0a90siom8WYbscdJDKTIJd6A/cZvaszLMg0neWlgaIg+Uyps70VZWSBPos0 zXxpLG0uoX9uDC6M8BBOyNrONUmyBpymJAl2LCLWrVT9sZmAGAxsdGrSrNLi1yj6hbhT qgeYOXeIqPBTCOrC7vftoIZ8lQ0N1NYWlXfsZGOf0dBVIF0eOTPzDR8yof4OCa05AC1/ LUjZEGeHs2HbRLOglyYIojX7PnwUaXQqdyBZKOnSpnwFpSnxIBjq+geXLKVP+b1oPinY 1UQDOlh7YxNi004S1Gjgvya7RuzKlJw+6NgdnJ/q3Xe0VM4Fsd11fI3fGOCWbeqUdEde MQzA== X-Forwarded-Encrypted: i=1; AJvYcCX0bAP5FF8Utgo7BsM1R/9WgAUPJCKYiGFEum0ERkZxbbLPURCHJ5wG3m9sNqCKVu7p0eMvLDbrM8HgnT4=@vger.kernel.org X-Gm-Message-State: AOJu0YyB9Y51s7ENw4EsXVViXT20XkZp6t7gUKE/kEc8UhCHSAwUDpsx /fqc+NQksBTfTYoPo1hbGe0LobOSy630DJqnkbcDHc59jVNkNu+2DhywbG2zlShwL71Fnsnrwwt 6hnkCG8ry/u/350yW+7yzZLaBWL5r79HBUDZjTIWq1GJJizhr8C/hp8ujLy+iqF+Kpdw= X-Gm-Gg: ASbGnctgGZaAGVZJNa5bkT9Tp6lP2+GR+sfVl8/85GPv3IB14wrFtT+ke3fLM112cbA GsWD4S5mhbVLk558K8N1cUwAXda4cpS1GoB+xcG7M7I6p2piu5XyJTuD+BNtZNwNo20geCi4fct ovKdwMlyr0Uv+0PzgQNfDmQsAgy1iC5N3Tq9h4d5WG1HLWX0dL5u4tf3XkG2ED6Un6IdPD525/a jUvVDnn6X48I5Z0RVtqpd3XjIz0mrJxpBlN7VG6xaqulCu0B+fX9U9eiXpOqrFuWDWK1jzSnU2u 2YTDqozEjBHDFqg/Z0t95X+TOExNp2U5j4XkIRVanihakxAtqSAvH7uGx5TowZjgYDRBVfurtEK 7IgDxmyAige2rDexZIOs5pgcAu7Ccu+DHSDbaeBkPOEPhdR96oVUZr0EdR92M51U0Xow= X-Received: by 2002:a05:622a:292:b0:4ed:b7f0:c76e with SMTP id d75a77b69052e-4ee49723b53mr24514421cf.8.1763640664042; Thu, 20 Nov 2025 04:11:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHivoDHEac0E8i9LKK60VuwTkp8BI3Br/o1/N7jrKQ/I7z9Nqd091W8EW4YkeLLHm5SG2OTmg== X-Received: by 2002:a05:622a:292:b0:4ed:b7f0:c76e with SMTP id d75a77b69052e-4ee49723b53mr24514181cf.8.1763640663640; Thu, 20 Nov 2025 04:11:03 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654d56a70sm194154066b.22.2025.11.20.04.11.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 04:11:03 -0800 (PST) Message-ID: <7d31f45b-1062-4118-8769-49209908f2ef@oss.qualcomm.com> Date: Thu, 20 Nov 2025 13:11:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport To: Vishnu Saini , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Saini , prahlad.valluru@oss.qualcomm.com, Prahlad Valluru References: <20251120-lt8713sx-bridge-linux-for-next-v1-0-2246fc5fb490@qti.qualcomm.com> <20251120-lt8713sx-bridge-linux-for-next-v1-1-2246fc5fb490@qti.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251120-lt8713sx-bridge-linux-for-next-v1-1-2246fc5fb490@qti.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=OqlCCi/t c=1 sm=1 tr=0 ts=691f0559 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=S05nYBC_j6DkukOZ6w4A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: Jau7XVgEx6BHw6b73wihjIEEmdxVL7Ex X-Proofpoint-ORIG-GUID: Jau7XVgEx6BHw6b73wihjIEEmdxVL7Ex X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA3NyBTYWx0ZWRfX13GKslHvC41A YTCriE6EhwzHAQyV768ATbBQyD1PK1TbCZU1TSV4IS0qzYKL171nS7D6Vsn98zi06eZGkG/7uoj B3evEGJG56imX0DJGDo8epSH1FPiNZdl8f7K498Rim9b3Lc8ymp+sX1XZElJ8WkCBMJUFbi1qLs B+RmzQ7M+oubNxe72ClPPiD4LN2o5GQtCwRqOK++SBF9ReMSDBrOdm3NPQupvcuBEKIVJFlzSXA QtuLhPwZXk3erCKshhFxLYJH5yJp3ajXfRPJkLsLNGrWKw/WDILd8AKH/9UDiLhq6aF3IDnEvZD gcVfptIc9V9ZT6HkvsDAvtJhaLU7hAfftPLYm/EZaIeOv27T8ndJRV8E77dMPWTHCgWjmtjxGRe Er04tClXZlWtq/LnmQLW3ocbNxbFqw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_04,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200077 On 11/20/25 11:58 AM, Vishnu Saini wrote: > Monaco-evk has LT8713sx which act as DP to 3 DP output > converter. Edp PHY from monaco soc is connected to lt8713sx > as input and output of lt8713sx is connected to 3 mini DP ports. > Two of these ports are available in mainboard and one port > is available on Mezz board. lt8713sx is connected to soc over > i2c0 and with reset gpio connected to pin6 or ioexpander5. > > Enable the edp nodes from monaco and enable lontium lt8713sx > bridge node. > > Co-developed-by: Prahlad Valluru > Signed-off-by: Prahlad Valluru > Signed-off-by: Vishnu Saini > --- [...] > +&i2c0 { > + pinctrl-0 = <&qup_i2c0_default>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + lt8713sx: lt8713sx@4f { Node names should be generic, so bridge@4f > + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/ Comment start/stop markers should have a space after/before them respectively, however I'm not sure this comment is useful given the dt-bindings already describe what it is [...] > &tlmm { > + dp_hot_plug_det: dp-hot-plug-det-state { > + pins = "gpio94"; > + function = "edp0_hot"; > + bias-disable; This is an SoC-mandated function on the pin, so please move it to monaco.dtsi > + }; > + > ethernet0_default: ethernet0-default-state { > ethernet0_mdc: ethernet0-mdc-pins { > pins = "gpio5"; > @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins { > }; > }; > > + qup_i2c0_default: qup-i2c0-state { > + pins = "gpio17", "gpio18"; > + function = "qup0_se0"; > + drive-strength = <2>; > + bias-pull-up; Similarly, you can move these settings to monaco.dtsi and keep them as defaults since 99.99% of I2C users will share them Konrad