From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ADD014431B for ; Thu, 28 Nov 2024 20:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732824130; cv=none; b=IpWkfCV47+NPE85tbsmqd61OrvzOE+q7zeuta7iOtJOG7ZGRz2H3xhTyhEZcWlc/raYutI//W8eUtIGfcaY25PUFS2XXTm51RCMOH13khGZsQ0QBBKEYk+1dP1EzTpYXIvbnCo7hlod3gNaqc5Qwdo+l4jNyeblCB0H85m1lAOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732824130; c=relaxed/simple; bh=qTIa5ewcdNKi4ufBLVG/FfPhgpbjosm13dgaf9cJ054=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lt1qpbUUTNAR28jzF04gs0Lc0v14vpyzHxG74+/dOjlpGC1gL6ONKVwULKQLgw4WoyMKnKuLiml/wwQxWOMup1HWEiH9WHjpbuxmDy35tqN/fhYUYZkYq5zSYfPdp8FeETYjxUUNqV9ND2ODFG167D8C8uCiapTJOZvT8vYeU9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UvUiWNMK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UvUiWNMK" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4ASALqeY005786 for ; Thu, 28 Nov 2024 20:02:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4ryxQrLv394JJ73iyw7kDdXCsPIHG185hp0I0Nvmu6c=; b=UvUiWNMKnpTDutQc WV3kG2XZiNzbBtXjAZ829NKkce5K2CLccRZhnSLVk4Cbi2NxLiV5DMW7vhbD1O16 tTNRm11Y7hZkbQGPaeLW4kE1sMIzxnSHoMFNW14C55+CzGe59T86T5nZER7Vowma xdloOROkBGn180TCqdQTAB0XK8q4ZOEQeiL3hSORHrsMc7J9Ds+Xai8UHOM0zyxG mr70Tq67GMlXPNk9BUeUmgCqwAVRRZSpTlo6/uAyCCSQYcutwFTfu7SjgBfIyC5q ChJkf2SsZhlWy6FPEKD6ZgEz8GLjAQGwHRGjXPIyZ+JfDNSgCbS+Ia64XYTgIH0m FyLADw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43671ebj7b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 28 Nov 2024 20:02:08 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6d41894a35dso2868496d6.0 for ; Thu, 28 Nov 2024 12:02:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732824127; x=1733428927; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4ryxQrLv394JJ73iyw7kDdXCsPIHG185hp0I0Nvmu6c=; b=YrpEQItlX5xMuGUzd+0KtUAicu3MlpQjVieF4/Qlr2xQw4tNlndlkJ4uDvnz/eFs8G AM0by0QwdsEMPlJdOOB6tfsKgu15HHT01EKKy9iv6/xeY18qC87TsOuPYzrZDmZXiSFp ed5fu/FK1N7bC7k5YiBNcoZD3kDbt+rp6WtBUjsbCqAnr+WwBEP6+wUzvXhzeAV+iief I/MLvUkjjSuARBz7p/UwTi7PFq+TbE3B/lwSjLHe3eAUBc3rkfL9s73fKgY0NS+U+TvA t3r6VeUfX+IhKNoBowSH0mpOPyDO6LyBKVpdMyq05a9rcF16eotlioGwyZCapzXATsaJ iO8g== X-Forwarded-Encrypted: i=1; AJvYcCViM1nTHIdMgYY+o5xWVjVLNyIm8LoS+QFrnVZrYUTW4wmVzrV7BkwWRkhq1jNrs+qwWC4O5Zor1o9F7yc=@vger.kernel.org X-Gm-Message-State: AOJu0YwodipbnVs/Axdmwibk11XgLHt32oj+eak29pT82A9m1onhVkUq hwUm9YZOOxAHnx15y6YnaCnB9URR8uJmzNr1xNPisQcMAHBaOmv8Lv6hmoLrxkcZrjym6ppZX4I DEiQ7YwjveZNEhXgl2OHLwhcUVrF1Sb7p5XjAcHVkesZFKG96mJBmNd+i39pBH/8= X-Gm-Gg: ASbGncsiwgRlhFhwdLWjK79JUpd2Qs15AjbZTcKUFoJhYHkdTZLLkedQfYHgFRDfx79 RmINDxXTww875i7jp8odnYkM+sLfjUll8aMtXsrvBeLVyGobMfJt96IPFctCGITJzBz2ftbnSkS WknLvx8wo2ziDZqcXSBrdSxk8WboreNKKyN7jgl8Hi/4OWcxkyPiulEJCAA8r0Qb5wZNWGXVllh MFcaCDYm0fn5mk3MvaEqig72eeXZoUbMaBzs57TsbjU5tDUmPealf7Y9cKoZ4SVS7VMMIWg+dRP 1kAtbcB2GN88j+uYzFXKPP66aCykQmk= X-Received: by 2002:a05:622a:cf:b0:466:8033:7dd2 with SMTP id d75a77b69052e-466b365e8d0mr60111041cf.15.1732824127024; Thu, 28 Nov 2024 12:02:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEe2yFrYKlH7GKamBIcOIr6tSYjrJg4Yf/IcqIpvGJ2yK7SICcuObbV3wRHzWvvMeRae6au7w== X-Received: by 2002:a05:622a:cf:b0:466:8033:7dd2 with SMTP id d75a77b69052e-466b365e8d0mr60110791cf.15.1732824126611; Thu, 28 Nov 2024 12:02:06 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d097e8dce0sm1031189a12.66.2024.11.28.12.02.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 12:02:05 -0800 (PST) Message-ID: <7d344377-f1cf-400e-a9c4-442123dcf4ab@oss.qualcomm.com> Date: Thu, 28 Nov 2024 21:02:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] media: venus: Add support for static video encoder/decoder declarations To: Bryan O'Donoghue , Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: quic_renjiang@quicinc.com, quic_vnagar@quicinc.com, quic_dikshita@quicinc.com, konradybcio@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Stanimir Varbanov , devicetree@vger.kernel.org References: <20241127-media-staging-24-11-25-rb3-hw-compat-string-v1-0-99c16f266b46@linaro.org> <20241127-media-staging-24-11-25-rb3-hw-compat-string-v1-1-99c16f266b46@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241127-media-staging-24-11-25-rb3-hw-compat-string-v1-1-99c16f266b46@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 3UBXJ8hYJ6TGD1zVKFECbvrJT3Js3r-k X-Proofpoint-GUID: 3UBXJ8hYJ6TGD1zVKFECbvrJT3Js3r-k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 impostorscore=0 mlxscore=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2411280159 On 27.11.2024 2:34 AM, Bryan O'Donoghue wrote: > Add resource structure data and probe() logic to support static > declarations of encoder and decoder. > > Right now we rely on video encoder/decoder selection happening in the dtb > but, this goes against the remit of device tree which is supposed to > describe hardware, not select functional logic in Linux drivers. > > Provide two strings in the venus resource structure enc_nodename and > dec_nodename. > > When set the venus driver will create an OF entry in-memory consistent > with: > > dec_nodename { > compat = "video-decoder"; > }; > > and/or > > enc_nodename { > compat = "video-encoder"; > }; > > This will allow us to reuse the existing driver scheme of relying on compat > names maintaining compatibility with old dtb files. > > dec_nodename can be "video-decoder" or "video0" > enc_nodename can be "video-encoder" or "video1" > > Signed-off-by: Bryan O'Donoghue > --- Bryan, I'm still not sure if keeping the logic behind this makes sense at all. Could we not just call platform_device_register_data() with a static configuration of 1 core being enc and the other dec? Konrad