From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Qingfang Deng <dqfext@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Qingfang Deng <qingfang.deng@siflower.com.cn>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] spi: dt-bindings: add Siflower Quad SPI controller
Date: Mon, 1 Apr 2024 11:53:23 +0200 [thread overview]
Message-ID: <7d344878-867f-4a03-90b7-a61c3fff0fce@linaro.org> (raw)
In-Reply-To: <CALW65jZoU8ChPg+e-5T4+ZmS2=g8O3wL96mjaRAPbomHJhg4gg@mail.gmail.com>
On 01/04/2024 05:36, Qingfang Deng wrote:
> Hi Krzysztof,
>
> On Sun, Mar 31, 2024 at 1:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 29/03/2024 02:51, Qingfang Deng wrote:
>>> Add YAML devicetree bindings for Siflower Quad SPI controller.
>>
>> Describe the hardware. What is this Siflower?
>
> It's a new RISC-V SoC which hasn't been upstreamed yet.
>
>>> +properties:
>>> + compatible:
>>> + const: siflower,qspi
>>
>> Except that this was not tested, aren't you adding it for some SoC? If
>> so, then you miss here SoC part.
>
> I should add the "siflower" prefix to
> Documentation/devicetree/bindings/vendor-prefixes.yaml, right?
Isn't it already there? Then obvious you must, but that was not the
point. Please read writing-bindings document. Compatibles should be SoC
specific, not generic. "qspi" is generic.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-01 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 1:51 Qingfang Deng
2024-03-29 1:51 ` [RFC PATCH 2/2] spi: " Qingfang Deng
2024-03-29 3:27 ` [RFC PATCH 1/2] spi: dt-bindings: " Rob Herring
2024-03-29 5:46 ` [RFC PATCH v2 " Qingfang Deng
2024-03-29 5:46 ` [RFC PATCH v2 2/2] spi: " Qingfang Deng
2024-03-30 17:43 ` [RFC PATCH v2 1/2] spi: dt-bindings: " Krzysztof Kozlowski
2024-03-30 17:42 ` [RFC PATCH " Krzysztof Kozlowski
2024-04-01 3:36 ` Qingfang Deng
2024-04-01 9:53 ` Krzysztof Kozlowski [this message]
2024-04-02 12:22 ` Mark Brown
2024-04-02 13:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d344878-867f-4a03-90b7-a61c3fff0fce@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=qingfang.deng@siflower.com.cn \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®