From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA042EAD10; Mon, 9 Feb 2026 03:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770606346; cv=none; b=jZFZ6CU3lzDxhYfbM+jzgt8I9YJQ/IJ22+UmHOYX4lm84KM0CfRUEEqGrPERq9M9XfFvqEJjJcPJbJQqmJoNBZspBPTAIJaGGV2hKWdFlYMhi0tXlnyplOD85nRakCvToxco/ltz+yMXw/ZhKoWUpjZH93whi6DeeotlzRZYrPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770606346; c=relaxed/simple; bh=Bi0BkSU0X7luO/eNKUDTo3OAk9c0hNwnUFQEUKPEsfw=; h=Content-Type:MIME-Version:Message-Id:In-Reply-To:References: Subject:From:To:Cc:Date; b=DXZuBi1BfyPBXXhrKZQOpZ3ovP9f9KnHKbACzYjnvjEd6X9wBdLIuYQxH0xWTZH7xMFcwqucdL7aDVXiMc0kEAi/yX9xL+JsZczBXpBc2oVsu0GiKnu34m28sGlmD/H67wiK3osA7/YfjAikuT826XUIOC5QxBcibPiUEYRpD4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cG+sAeWy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cG+sAeWy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C193C4CEF7; Mon, 9 Feb 2026 03:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770606345; bh=Bi0BkSU0X7luO/eNKUDTo3OAk9c0hNwnUFQEUKPEsfw=; h=In-Reply-To:References:Subject:From:To:Cc:Date:From; b=cG+sAeWyJWGwC/Aap7um1mW3FVa/saSM/1E0r2PdRfdLfatSgunijyvKcqeRKABt1 9whi9FzkNVfIQ+TvxlYTn5HAgF+pnqN7B8G8sc+cq0+vrZ+IEjN+w4XE6xDPQAIE76 VCBslV3UB40R6f+l6hQkpoi7dGX88W9ej+jud/nTyIyGgpW5ZUQ7/KHhJRu8mS6Qpp EnokLaUHyDKEkGtmoD/kh+zpbfxMklkxNIbByo8g1VXDH13xuzaw1WlHs/rN/ouozD p1xmIGCBlZlHOlA081oGTvSijWr3XLkgIlwuC/KeTiuT9PICZR1onuWPwB2nPtMzR5 uvHk2B6DOXtIA== Content-Type: multipart/mixed; boundary="===============3409934204227450896==" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <7d3944c1d8ffe5ee6d52907d7227f8eb8b91f5aa2b705fe3eb0af23454b8b072@mail.kernel.org> In-Reply-To: <20260209023153.2661784-12-ankur.a.arora@oracle.com> References: <20260209023153.2661784-12-ankur.a.arora@oracle.com> Subject: Re: [PATCH v9 11/12] sched: add need-resched timed wait interface From: bot+bpf-ci@kernel.org To: ankur.a.arora@oracle.com,linux-kernel@vger.kernel.org,linux-arch@vger.kernel.org,linux-arm-kernel@lists.infradead.org,linux-pm@vger.kernel.org,bpf@vger.kernel.org Cc: arnd@arndb.de,catalin.marinas@arm.com,will@kernel.org,peterz@infradead.org,akpm@linux-foundation.org,mark.rutland@arm.com,harisokn@amazon.com,cl@gentwo.org,ast@kernel.org,rafael@kernel.org,daniel.lezcano@linaro.org,memxor@gmail.com,zhenglifeng1@huawei.com,xueshuai@linux.alibaba.com,joao.m.martins@oracle.com,boris.ostrovsky@oracle.com,konrad.wilk@oracle.com,ankur.a.arora@oracle.com,mingo@kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev Date: Mon, 9 Feb 2026 03:05:44 +0000 (UTC) --===============3409934204227450896== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > The wait is implemented via smp_cond_load_relaxed_timeout(). > > smp_cond_load_acquire_timeout() essentially provides the pattern used > in poll_idle() where we spin in a loop waiting for the flag to change > until a timeout occurs. This isn't a bug, but the commit message mentions smp_cond_load_acquire_timeout() when describing the poll_idle() pattern. However, the code uses smp_cond_load_relaxed_timeout(), and the subsequent poll_idle() conversion (patch 12/12) also uses the relaxed variant via tif_need_resched_relaxed_wait(). Should this say smp_cond_load_relaxed_timeout() instead of smp_cond_load_acquire_timeout() for consistency with the implementation? --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21810635323 AI-authorship-score: low AI-authorship-explanation: The commit follows standard kernel style with iterative improvements across 9 versions and reviewer feedback, consistent with human authorship. issues-found: 1 issue-severity-score: low issue-severity-explanation: Minor commit message inaccuracy referencing wrong function name, no impact on code correctness or runtime behavior. --===============3409934204227450896==--