Re: Pointer magic in mm_init_cpumask()

[Rik van Riel <riel@surriel.com>]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

On Wed, 2019-08-21 at 09:13 -0400, Siarhei Liakh wrote:

> If mm_cpumask() is not safe, then at the very least the following has
> to be fixed:
> $ grep -rIn 'cpumask_clear(mm_cpumask(' *
> arch/powerpc/include/asm/tlb.h:69:    cpumask_clear(mm_cpumask(mm));
> arch/sparc/mm/init_64.c:857:        cpumask_clear(mm_cpumask(mm));
> arch/ia64/include/asm/mmu_context.h:92:        cpumask_clear(mm_cpuma
> sk(mm));
> arch/csky/mm/asid.c:126:    cpumask_clear(mm_cpumask(mm));
> arch/arm/mm/context.c:233:    cpumask_clear(mm_cpumask(mm));
> 
> Otherwise, mm_init_cpumask() can be simplified down to
> cpumask_clear(mm_cpumask(mm)).
> What do you think?

That looks like a nice cleanup.

I do not see why it would not work, but I suppose
that should be tested :)

-- 
All Rights Reversed.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]