From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C2E3F39CE for ; Fri, 15 May 2026 22:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778882949; cv=none; b=KxqMEuDUfZfIdYkuQaZQjXVwQRzJkLWYGUdFOSOCPw8wYrouTaqsmmbUmrIz4vM/9Cmh8j5T0TWuOlpBhyBu0o+U9+FQZ6W4FEcoDF+Gz+5VzGHOxBZe3RJi9XvcMqBWKv2sAGOYrsrYB3bYdSElKwxG17FkGU9BtyOIuceE+VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778882949; c=relaxed/simple; bh=IET5AU6rrRRsH37Au+nEzTi6bqMiuH7lodZQGEdsPl0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J1siMZBniXSfc+F0tA+je5Z0T1VeE5voPb72Q+NIbIHKO9DWfBxMvhKWRi2fNqk0H6boBW6wV+1qso+7OcMimDLX1QHTOGoKGEDOuWcDKtMSyDQhvAUqc7lNyt+z6HWivw8ylHSG1rOJPMaUw5OdEREGSdezcIrP8VIDorS0qdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Io9+h9rw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ePf8g/PB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Io9+h9rw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ePf8g/PB" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64FJeaw9903679 for ; Fri, 15 May 2026 22:09:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YaMH5hmIAD00xqSHsQUa0nL0jAccvNpv5cFUjemkwiQ=; b=Io9+h9rwNtHe309S OVH+h6e78ujukoFG+67vJwR+0WA8GGWvkfs+CED7kM3wyT4k1v9lowfjIPwi1Zk+ +6HG0ljCnzxDh37PtulhGakMBC3hAWzzqfiitC7kHCE0v8DGQuUOaLNBsjzd+0Uy tYfqFXE0S9X27qzlkI+MDCeT+hPOdA6OOb4QT4aQV4l03YH5e79XLqGMN/4p1pAB sRgAncfHAIY03FZYu7dmHCywYpzd1GvogS7gldtYuJEwrzQMNw31J+Np9vja47pj jyosMCP8W72ChGMJzytJE4aK0CiMbUcGRbLGSOjoEupsbn08EAUyxNsaOnW7tihV XD5tWw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e670u8y7x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 22:09:05 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f756ebd0dso158087b3a.1 for ; Fri, 15 May 2026 15:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778882945; x=1779487745; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YaMH5hmIAD00xqSHsQUa0nL0jAccvNpv5cFUjemkwiQ=; b=ePf8g/PBQg7UsE9819vV4XxfqtpAc2pqLXkIekwsE03yQrc2+bIXxepTe4Jgwq4UiU qKfdP4xM/op+dHrJWNHDFLkKHesNM6dp2T36zKuoMmYcBSnIjfPiTwn6AcU5Hrr87q4a agJd8MODLlaneoWFOUzdwq+YAHY+bJEcF3J2i1D45bcDD1e90SADvPOJM7QYBkxOyfB/ bc90SHa1hzxBJ5xeM4hRr0PSiPE/bLk7F3dV1Namsv8W5J/SMk9FRW2DrElWbDs8ujyr zRjZDI6F0mvpWzgLkzLcBYTVweBCuYs67ezDnypY5EZEHK717N+MWJs3wYot/H6ItGtd rx4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778882945; x=1779487745; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YaMH5hmIAD00xqSHsQUa0nL0jAccvNpv5cFUjemkwiQ=; b=SRbPO1v7qA5+7Z7G/yikcQdzG5Fr2E4npWtxddJ/8jR7N44pNHHgyJwcw5zUoEMnCC Qliy+MAbmQFuj67KBA24RKi7bHupPyebX+zbTroNHK8Sd/T573V1/E98ujJ0o3ii3swY QawIrIerVzSEIhfX8BIY/PaKmfHdyQlH0I778zludpC+FiDUczJ0r7UiN2w8aZCxRTQz UpCHdcPsZGC3ioiK6EVe6luMdyUinqof3CeBKcoe2G/vKxI99lfaOIawGbrC3T/K7+j3 BvaXRLbPxe/1WJSCdFGfHKb9kKUYedFsSZnD3alv8Kt0NTWvjYTsPk3krR9Y+RmonAOD WVIA== X-Forwarded-Encrypted: i=1; AFNElJ93/fpT6V70ZUeIdkJ96orgDM3toxQ+exr2zgTKz+mQ7NFdEuaDp159wPJhFZAqHd8HRre/VlkISuDxkZw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4ElX6HZkwvzlJHD09ZLk/nVF7AWeK5u2nsMpF5uODFef/kwLv GCiz94ExcOLghzHiTNfqPogUPBCCmPGZYtWw4ZFa0RJpn2HZxXvDDYpSEEeBwxvY92KPPdd5cri YI3ljjGZ5iC+KE3PJDxQNsYAGQY59t36wpKYN2cG2EXdI3x2QIBgh0bzjCHNnKvIxpWc= X-Gm-Gg: Acq92OFHDSAjCGQxSdShiSbgzwOdNmGigKTfWA7eDGIjxft0MGknf4WScjfewnkvjVb eNyTrQ4AnxR0fhEQbqzkEHvcAOGsoguHKUXYUDQlOl+tijkiQ5tNH4kHtwgxlRb0b1ibDNlliTJ 1nvQVltwwbIdIDYxqLW7RFiW8YyAObCgyyNC432U8XLVExSDHvPDy6OwhELaA1Qa4kh3cuTGTCa ZtW6UIO8T57Ui/yjgklUp1pSyVWr0iGek7qSuausdg5NV9Id1Eof0UDKwGrjQwTkYtwzfPbZhtm Bftwd9fj3xJSczrTNCKbbVSfL7toMAKTHZdcPvchafh6nqdFTgGJWhGRBWA2nhkYWsaYLnV8Gaa f+ZEXZl2kJwF0oQFI2BClE3LmLEjWXe577vZxCld8PtI= X-Received: by 2002:a05:6a20:4305:b0:3a8:2339:24c4 with SMTP id adf61e73a8af0-3b22ebed4a2mr6668414637.26.1778882944663; Fri, 15 May 2026 15:09:04 -0700 (PDT) X-Received: by 2002:a05:6a20:4305:b0:3a8:2339:24c4 with SMTP id adf61e73a8af0-3b22ebed4a2mr6668373637.26.1778882944158; Fri, 15 May 2026 15:09:04 -0700 (PDT) Received: from [192.168.1.3] ([182.60.13.113]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c82bb1156absm6447536a12.27.2026.05.15.15.08.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 15:09:03 -0700 (PDT) Message-ID: <7d3dd8b9-8411-476d-a1ef-fdac476a1515@oss.qualcomm.com> Date: Sat, 16 May 2026 03:38:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] arm64: dts: qcom: Add GPU support for Kaanapali To: Konrad Dybcio Cc: Sean Paul , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter References: <20260512-kaana-gpu-dt-v1-0-13e1c07c2050@oss.qualcomm.com> <20260512-kaana-gpu-dt-v1-5-13e1c07c2050@oss.qualcomm.com> <14a2fbfd-97c1-4ba7-aa51-a07134102d3b@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <14a2fbfd-97c1-4ba7-aa51-a07134102d3b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: IJ2Bro3YJFLWnz9LAcGGZsgPtEoZct4j X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDIyMSBTYWx0ZWRfX4VPYuKiB5021 u2qjbCGZ5j8aSWvmiY/vdLbN7v6s7XYhRXYrTu4tHFEFalQpYvDPjCX2bVZOm2IzWT1VvGP6JaZ GxpUz27ZVbfy1dC4YErRxY3BUDyNaao5nGuz0lge8BLt+O/5npa5jkndVuQDypdMkRwOsly67Tr /x31zdG5TH2iE2P7HD3pu3LHKrdqiDOhVmtEM/K5Xr8ZvbEpJzzlx0KhvmvE1WZJ/8uSgK5yh+S Xb+Jt2zGRFKyUh7Pj1jHsJHsW1sdBhV61MPVc9aH1JGC9TCkWw4oXoVijAYld+yIOPQunIpISIX d4z4VI8TzrO+8EQgU2Qbjocnf0aPm1O4eB/5LlhLGvwboL0Goxl2xtwywb0uoeq8i+68hSgYrv5 x1Y8nS4Sn/sitGX29lOEm6tuiy9ZSlmzN3qtdkgH7MP48+cNjOK8G1/VSHnVkSwVy6rQLPpZK4+ lJ20e7NeNbvnXFguB7A== X-Authority-Analysis: v=2.4 cv=E9f9Y6dl c=1 sm=1 tr=0 ts=6a079981 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ba8plz+5YpscmDk5DVa2Cg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=mzNi1YEEKYKHT8R6ei4A:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: IJ2Bro3YJFLWnz9LAcGGZsgPtEoZct4j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_05,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150221 On 5/14/2026 6:13 PM, Konrad Dybcio wrote: > On 5/12/26 12:23 AM, Akhil P Oommen wrote: >> Adreno 840 present in Kaanapali SoC is the second generation GPU in >> A8x family. It is based on the new slice architecture with 3 slices, >> higher GMEM/caches etc. >> >> There is some re-arrangement in the reglist to properly cover maximum >> register region. Other than this, the DT description is mostly similar >> to the existing chipsets except the OPP tables. >> >> Signed-off-by: Akhil P Oommen >> --- > > [...] > >> + gpu_opp_table: opp-table { >> + compatible = "operating-points-v2-adreno", >> + "operating-points-v2"; >> + >> + opp-222000000 { >> + opp-hz = /bits/ 64 <222000000>; >> + opp-level = ; >> + opp-peak-kBps = <2136718>; >> + opp-supported-hw = <0x0f>; >> + /* ACD is disabled */ >> + }; > > The clock plan also has a 160 MHz OPP @ LOWSVS_D3 and there's a couple of > interim OPPs that you have that aren't part of it (but maybe you have > better docs) I somehow assumed that the 160Mhz was a thermal-only corner. Seems it is not. Let me revisit the OPP table again. Yeah, the doc is outdated. Looks like there was some last minute updates to the OPP table. Also, we should update a6xx_hfi.h to accommodate more than 16 GX levels. -Akhil. > > Otherwise lgtm but the size of the GPU region and the GMU base look > slightly confusing when I'm comparing them against the reg map > > Konrad