From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbbBFDNT (ORCPT ); Thu, 5 Feb 2015 22:13:19 -0500 Received: from m13-43.163.com ([220.181.13.43]:54158 "EHLO m13-43.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753747AbbBFDNP (ORCPT ); Thu, 5 Feb 2015 22:13:15 -0500 X-Greylist: delayed 918 seconds by postgrey-1.27 at vger.kernel.org; Thu, 05 Feb 2015 22:13:15 EST X-Originating-IP: [222.73.125.68, 203.14.188.254] Date: Fri, 6 Feb 2015 10:57:49 +0800 (CST) From: "Yi Zhang" To: broonie@kernel.org, lgirdwood@gmail.com Cc: linux-kernel@vger.kernel.org, yizhang@marvell.com, zhenzh@marvell.com, zhouqiao@marvell.com Subject: [Question] should we export set_suspend_voltage()? X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20150119(59087.7062) Copyright (c) 2002-2015 www.mailtech.cn 163com Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <7d3ec992.e522.14b5cd26cf6.Coremail.yizhanghust@163.com> X-CM-TRANSID: K8GowGDJukGuLdRUG6EDAA--.15331W X-CM-SenderInfo: x1l2xt5qjk32rw6rljoofrz/1tbipQKY2lEARp9o8gAAs3 X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t163DQ9B029066 Hi, Liam & Mark: seems at present, the set_suspend_voltage() is designed to cover the suspend voltage handling from board level, when the system enters into the suspend; but the behavior of my chip is as following: a) there are two sets of registers to configure one regulator's voltage separately, one is for active mode, the other is for the low power mode, say, suspend-to-ram; b) both of the sets have control bits independently; c) once the low power mode is triggered, by external signal, for example, pull-down a gpio, the regulator switches to use the registers for low power mode; d) the consumers have different requirements for the voltage in low power mode according to different scenario, IOW, we cannot assume a fix value when system boots up; So do you think it's good to export the set_suspend_voltage()? to make it controllable by the regulator itself? another method in my opinion is add a set of virtual-regulator for this usage? could you please share your advice? thanks very much; -- Yi Zhang{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I