From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8E9A2D374F for ; Tue, 27 Jan 2026 09:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507269; cv=none; b=d5f5UoGmZthc6jryQXI4Icp9zygZ9ZKUkbDeL6sjq91MAjcHACqILy+N+TNZljYya1HJhTzOHgS34VeRiT8re0PNX7FBQYTaPJRRIKK/PYNNNNFSXnVByzvYlWo60oxk7xf9bnxMohxKfwK/61J6A9YPBQ0cI2AA/I2iwXo9pSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507269; c=relaxed/simple; bh=HeVmF5X3Z8OjUc5R0RzLvT9IdOt2BaA/r0GO4t6RaNQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FItCTXHOVas8MCArwGt2adzdoi8/slbGjR/Fz6hsuIf/wR8DlRRwZqKggc6EbsMj3Tg/IlkVokcn3xG8LyzZ2WTpbu5LNtD5KT8spOTguv99bpg8Yi62Qf7UanD0iQFiQO34nLQfTG07cup/8Ag+uWnzk6oYmcEp2016gCgJUuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ghY+VkMY; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ghY+VkMY" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42fbc544b09so3944970f8f.1 for ; Tue, 27 Jan 2026 01:47:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769507266; x=1770112066; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8JLdRq+wi1vFeuwJOX3HIei5iWGLJOqM9UIkpj0qjpQ=; b=ghY+VkMYDShE4BXcPAUUjFIz4Mpq8YuN9jTpkdIB/8Qx58nhlUkq7IkpgwY8l2tHSk ynlTWXOz+6teSLMfvnPIIQX7TrHL4SFS1w3vRO3OHFMC9ZMkNSsQlbxCs6RlHnYIXVHS Y2UpF/7DGFdohaa5a+52c8/7c3COPpygJku0DUYM/ufunnFzZK1Wc4/RO3P9UKcdTDFo Hefu4cMftbRaFV2L3sWmt7r3Z/TiJM5fR6t4OTVuesvDJ4bRBlTDTkMPur+snO/NdSQP NxPIHInTkmBcP88CKcRRjDhHgMClL2aSvcShLcceC1PL7U51irLFDRsvjLYrMmsxVnOW q+4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769507266; x=1770112066; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8JLdRq+wi1vFeuwJOX3HIei5iWGLJOqM9UIkpj0qjpQ=; b=KZPDZ47v8qqEZpxW3gbgXfq0h6XzC9RyBG01o0+CiGtiwSVEmZhTPEWatW9Ytaf67R 1l+5+x6CgDfN/yPq81Ug2dwUOe5u486loCu+pBo2gfmOTGcyZDOrX6WgFOuVBgunQikK jjr9c9xBg3ppoOBAPL0+tb7Syhf8gdjUoWnJQQ72qwUPbNCT047cDtao7xE51hQGyif6 SFJJUe0+0Cj+++/vK0f8kyWM3rrZuMefOOOC6WXPPqExChD/45A8Jhvsd7QKvJSvwyKj bTVs7nllyz+iTdNGfFg/S7rDg0f/knjhUHFE+i8v0JSmZrHt0IkMKSaQPfBGp4hqBCVN B/fA== X-Forwarded-Encrypted: i=1; AJvYcCVnJe/+GUDoouqTfX3Rjewq3aUTffL1c5nyEE4UqAmQmw/aBE52IxMzL8qRCMwo7i/MZhc+xck8rnj5VuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwON4QBqpM/gwRKjJUznrE4HKJvVcZIi3I0rBtvTT8djP09Frr4 pes4vTf907leirtC6uzoZ5UtBLgYHMPPPPn2s7a+Ali+Xp9ZccsGT/g1 X-Gm-Gg: AZuq6aLCvNaKpVlfz8lVgZXbvknMIN+6gAHh/ZqWxzXIyyGvkoWBYmwJmZmxNQ8YGDb Q20o0ZSRujb1XzAzrSdz1cPCrxYcLZCmT9y6InEMobXsnQgu3DpJVYcJqcoe77u2vf3pGGT7WXP BpjKmxksIc5Hg67giKQfw8b/GchPvlBzpl8a98gELw9UsiG1Dx2jOrqCVWZcCyLpazl8yA24oTv Rt5npBgpsc2fA1twsR6N1j1DA/XFbcscH8RPH6v1C/sKetqhGQwvkNCLH4dBpXB4/p27LMKMqrc 9RHMlf8u0249s4pfWeidkzQ2HSf9MAIh51wuNsQ5kydscqwaHz/8QMsOMXnN9hnSI0a8ib+hoRr VL8vhJ8GmFMLExzTepxn1gcFODYDsY7txN5bM6IGmJjWYevT3VXFP5U0jBA++pKq6U/opzmJTrv lu2dmLQv6i3DIYgeuOPUmzXrQZllF6+IFunG4W0azq1ggrsEvPFTIcanjZLDiKAQvbC3EABNxqm waBdxt49KfxO6G4hGc= X-Received: by 2002:a05:6000:310f:b0:435:9ea8:8b83 with SMTP id ffacd0b85a97d-435dd074b85mr1528570f8f.19.1769507266174; Tue, 27 Jan 2026 01:47:46 -0800 (PST) Received: from [10.0.0.128] (248.201.173.83.static.wline.lns.sme.cust.swisscom.ch. [83.173.201.248]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1c24bedsm35462739f8f.17.2026.01.27.01.47.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 01:47:45 -0800 (PST) Message-ID: <7d3edca3-7369-491c-8746-ba24cdd465bb@gmail.com> Date: Tue, 27 Jan 2026 10:47:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gpio: pca953x: mask interrupts in irq shutdown To: Linus Walleij , Martin Larsson Cc: Bartosz Golaszewski , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michael Roth , Francesco Lavra , Hugo Villeneuve , Maria Garcia , Emanuele Ghidoli References: <20260121125631.2758346-1-martin.larsson@actia.se> From: Emanuele Ghidoli Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/01/2026 10:29, Linus Walleij wrote: > Add a few recent developers to CC, this is a very widely used GPIO chip. > > Emanuele was dealing with IRQ storms and may want to look at this. > > On Wed, Jan 21, 2026 at 2:12 PM Martin Larsson wrote: > >> In the existing implementation irq_shutdown does not mask the interrupts >> in hardware. This can cause spurious interrupts from the IO expander. >> Add masking to irq_shutdown to prevent spurious interrupts. >> >> Signed-off-by: Martin Larsson >> --- >> drivers/gpio/gpio-pca953x.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c >> index 8727ae54bc57..f93a3dbb2daa 100644 >> --- a/drivers/gpio/gpio-pca953x.c >> +++ b/drivers/gpio/gpio-pca953x.c >> @@ -914,6 +914,8 @@ static void pca953x_irq_shutdown(struct irq_data *d) >> clear_bit(hwirq, chip->irq_trig_fall); >> clear_bit(hwirq, chip->irq_trig_level_low); >> clear_bit(hwirq, chip->irq_trig_level_high); >> + >> + pca953x_irq_mask(d); > > It makes sense to me. > > Reviewed-by: Linus Walleij > > Yours, > Linus Walleij Looks good to me, thanks. Emanuele