From: "Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>
To: "CK Hu (胡俊光)" <ck.hu@mediatek.com>,
"seanpaul@chromium.org" <seanpaul@chromium.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH v2 1/1] drm/mediatek: Fix errors when reporting rotation capability
Date: Mon, 20 Nov 2023 05:54:40 +0000 [thread overview]
Message-ID: <7d42e3c576181ce0d47cefeab845c3d80a3967b9.camel@mediatek.com> (raw)
In-Reply-To: <b84d3f321bd329dc862cb03cb35a922dbc4793a3.camel@mediatek.com>
Hi CK,
Yes, atomic commit can still work without rotation property in planes,
it only affects IGT's behavior (will fail). Since currently we didn't
receive IGT requests on platforms other than MT8188, will return 0
directly if the property is not defined. Thanks.
Regards,
Shawn
On Mon, 2023-11-06 at 05:55 +0000, CK Hu (胡俊光) wrote:
> Hi, Hsiao-chien:
>
> On Mon, 2023-10-30 at 17:03 +0800, Hsiao Chien Sung wrote:
> > For CRTCs that doesn't support rotation should still return
> > DRM_MODE_ROTATE_0. Returns hardware capabilities accordingly.
>
> The original code would not call drm_plane_create_rotation_property()
> to create rotation property if CRTC does not support rotation. I
> think
> this behavior is OK because not all drm driver call
> drm_plane_create_rotation_property() and it works. So ovl adaptor is
> not necessary to implement supported_rotations() callback function.
> If
> some OVL does not support rotation, you could return 0 directly.
>
> Regards,
> CK
>
prev parent reply other threads:[~2023-11-20 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 9:03 [PATCH v2 0/1] " Hsiao Chien Sung
2023-10-30 9:03 ` [PATCH v2 1/1] drm/mediatek: " Hsiao Chien Sung
2023-11-06 5:55 ` CK Hu (胡俊光)
2023-11-20 5:54 ` Shawn Sung (宋孝謙) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d42e3c576181ce0d47cefeab845c3d80a3967b9.camel@mediatek.com \
--to=shawn.sung@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®