From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A78C30EF63 for ; Thu, 25 Jun 2026 23:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782430866; cv=none; b=m/9MU9jtcVXWkR7UJQS/4rkCvYRnBLAaKOEOJTGw29pEKCQUYAbs96CxaqSEmeWX7iKqYoVE5CUx5NYkIrBJSvFyGqvoiBGse/+96qTAKsI110gooauO3eXAkaOSMPo6TvXiB2GTTdnoBRCtQNg6SupC28O1K+fhqrX348BCEAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782430866; c=relaxed/simple; bh=XfbZbU4hnyAc5+KdGNxe2ruPtG8EqMmSWSCqT62Y0S8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r4oRNmY7V04P1i+LuFfVrdogU+Hk/vUZMKBye/xb3YPMauHRPdSlsFMjd1hUqF7woQRKme9Kbd/3fivBw5vCylhXawrj+OtQN9ZQLmhPSNqjMdHlqr4njR5IeZvQrddgfgseUF3d9Nq7GKsRXyI2KTMM4NAx+vAIWfe7m0L+uU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CLMekx8v; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CLMekx8v" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-46db3c9a9e0so183122f8f.0 for ; Thu, 25 Jun 2026 16:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782430864; x=1783035664; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=JzRXNZAIz+cFbURiea9LciZT93qfxVdXq7/EPTmkpVo=; b=CLMekx8vQrjs5DHVdatqcoa6gVCtR8TtNy4butuSdeBLnrqn0Fi9/d+dC+AYQUi+Xz 5f1gTT9pLZEkTGuQD+KeYJbpxphhEDaxZPN/04Ayk3M/Zrd99M/p7DdDlMgBwCmIq+VF qEgM5P8FkF4Kh72V6AGTyaATSSzTebNKrVPU8l43Qtn7un0/+XCeYnCHdT/e3/UHbqOP oR+zT8iSnDY/dXNtGCexJZdRm0vQIhVBjROEEFBR2fZPonIzEBJAZx/OFZRE7GhraPXa 4oXmpSq7tGEoqQnCiYQqtHEJrhCxcvWMN7BQNgGZJ6Q+lUjxAdGG1y8l9ySLrTWVXMUa cHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782430864; x=1783035664; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JzRXNZAIz+cFbURiea9LciZT93qfxVdXq7/EPTmkpVo=; b=lRAYV/gA2DOUecPLfJjl4H0PubENiX1wPdcilhUN0GrIsM177cYjT1LvUoMwc2FRDZ Bcm9RWHFPxpbvmGHh8dCjVzfj2OJ3Rlg83Vq/hu5Zo03JJ6zD1b60tV/+yqqjgx+Mp8c +pn5FXh4qGqkvsxHlNGFOAmlL/OirB5p8HJU/p/RazZgtrrTh8arRQLgOagwHSvvRDlF KqEVKTgX83gtq0EAFXUSUYECebrNaZ341eChU+x6/4JdJt1TgOEXCfruyLWBxwRnucaD Tz1T4o/SmrI6DvsJn4q7czlziAlqahtbwF+D880vUP7N0kwNu++fv80wwiO7ZdKfPXNt 2j0Q== X-Forwarded-Encrypted: i=1; AFNElJ+CR9XMbhGHW1kuown3JAH3qcEC37lhYT+M5FzZo8+tFBjmueFsS166Te0yge0023LLNrnNPRIm79OqrYc=@vger.kernel.org X-Gm-Message-State: AOJu0YxSOV02GDrghp/2tny/UDOftz5mY2DU9V47SI7C8VYrfoHrY49I 8BIoAEx1qiJeDZxAqfsbDAJ96pthqUravvpYhVVKKEKJxvZJgHzZU/3iB7k0E6TjT2Q= X-Gm-Gg: AfdE7ckOUwd5ykLDgxc40/F6PBnsNQ2PbRpLhVtZz7m9HgRYWiVliPlLBmXongq18gG O/cV1nd+i9amCdoTdtRjwQ9l7mlZRtcA4kqdo1TWC7J5E6oSM7AnF+HbQmABTAegDTpy2kyoPcp bgK5CFNTsw3yaHyzbXraTKNZgNhkydkNV649tdTtvdcn9xabyUKvAHGTZsRx2EaI7BvChEeme51 trCXn5KNrZ9rTwcnMEoktFdcspqy3N32H1XOrUmOgQ6MzzBAHb/xoPrGIGVlQNNywDLdORHo0Wo n1Q+PlA0uAlGVH8SGtOkZJDJ5hPPyGTM7ZCHYAaol12UfOL1Mxg8n0msdeqhn5sXmtcJVyICecY g3W5cF6mjaIqPhwDrT8YQ+VP3j5/w/mr1lwzqZFUsYyaUbOmN8kUeqNi+sXVFopbTkauvzWGgTo VbxQ1E6JIy7nzM1z4zD/7Utngef2IKhxeaeFLEnUT8 X-Received: by 2002:a05:600c:a12:b0:492:5e22:ef18 with SMTP id 5b1f17b1804b1-4926685a81emr70142705e9.9.1782430863872; Thu, 25 Jun 2026 16:41:03 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-139d912197bsm18914891c88.15.2026.06.25.16.41.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 16:41:02 -0700 (PDT) Message-ID: <7d4ab06d-6cd0-4eb6-a355-d2b51d132713@suse.com> Date: Fri, 26 Jun 2026 09:10:57 +0930 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] btrfs-progs: check: fix max inline extent size To: Daniel Vacek , David Sterba Cc: linux-fscrypt@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Josef Bacik References: <20260624165144.556908-1-neelx@suse.com> <20260624165144.556908-2-neelx@suse.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: <20260624165144.556908-2-neelx@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/6/25 02:21, Daniel Vacek 写道: > From: Josef Bacik > > Fscrypt will use our entire inline extent range for symlinks, which > uncovered a bug in btrfs check where we set the maximum inline extent > size to > > min(sectorsize - 1, BTRFS_MAX_INLINE_DATA_SIZE) > > which isn't correct, we have always allowed sectorsize sized inline > extents, so fix check to use the correct maximum inline extent size. No, we only allow sector sized inline extent when it is compressed. The de-compressed size can be sector sized, but the compressed size still can not reach sector size. So this doesn't seems correct to me. > > Signed-off-by: Josef Bacik > Signed-off-by: Daniel Vacek > --- > check/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/check/main.c b/check/main.c > index 5e29e2c5..dedb4db4 100644 > --- a/check/main.c > +++ b/check/main.c > @@ -1720,7 +1720,7 @@ static int process_file_extent(struct btrfs_root *root, > u64 disk_bytenr = 0; > u64 extent_offset = 0; > u64 mask = gfs_info->sectorsize - 1; > - u32 max_inline_size = min_t(u32, mask, > + u32 max_inline_size = min_t(u32, gfs_info->sectorsize, > BTRFS_MAX_INLINE_DATA_SIZE(gfs_info)); > u8 compression; > int extent_type;