From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0848645039 for ; Mon, 8 Jun 2026 22:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780959163; cv=none; b=BzyqVSUJqhTQEdqUhIIiVqfzmwOa6v8aTzWfHLM5pmFaE1HifFWN+j6Na4+rF5FEyAtyJMBo7clnq5I4sKCVVLETeoXVCK/sVzuRIu7W9GgWgwEDOg1oQwbVJCCDKnxFYLbFWBOfIS+dp/flMBxnsmkTP5dhoAlSDTGAr+Th/g8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780959163; c=relaxed/simple; bh=UR94XfZGe4SN0tK+q/lzFr5zoyRdgF+h9/R2DPk8MdI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H8opHbO2veCoS3DAR6o7zIvrJURy3mpInaBBUMsejRPjW0Dfxhalzo4lxW3sEiMlp/jc3tuTBBrFMRM0sx8t2lYzxmY4VPdL795JkEOpgzDFgaaVgt+tH/TJCwObjP3ZHyYOXSZ03KXnUOJ9+aIxUcoh7NinI1Mh9kx2UB9GKa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qqQpIQy9; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qqQpIQy9" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c8589498839so2116744a12.2 for ; Mon, 08 Jun 2026 15:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780959161; x=1781563961; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=Jt2Eo3v53IUPQ4iRdHxED2L6IQZeVQo07iv+ksWhxxo=; b=qqQpIQy9IHiHwCLD0IEKXXpIfjRD2hpx4FNZIHJTpdrAYeithULkfHjbw5FiasAijh uaIff21eMZ9db/EBERVEdvdx42oi1FdcD5+maZsmugXe0f9GL2ByfiHNCd8TAk2Nu8YH YBXDxFmyrGnNrO9ZKBayLtbbdiO7LZAjKVMvTKaw64vm3a5ytaUObNcgCO9EOiTKtfk5 5ihXhGOM8kCST6VetheKPLi5FsjZHpvfcdjTEBZHurpbQoq0UNAgJCoVpH6IrSuqTw89 1B54jPxLaLGkSPeOC6AFamFRz57S5FfSyF/I0KSBn+Woyq+C5Ao3fKdBs9dOlBOzMm2B bkGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780959161; x=1781563961; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jt2Eo3v53IUPQ4iRdHxED2L6IQZeVQo07iv+ksWhxxo=; b=YHpB7RiEvhPQMKr1ClCFSrRRbEd/171LcOTZxZrXoZxASC9JQFO8z5x2wATzD5I4Rz BRNMrhiBT0yYEoOXQAhL0ctDFj8X3/rWZuXfPBeTHUBa7o1x7kGQLN/bxJDzn/hylDlZ /yeng5HWVZUw22bBJXumqYCa0AS/3FiNL+KbMxZXN4wGNP8kSbQMnxrAy0gRMLQhO5Uw KjnkRoaal/emXIMxA/0WRrcVBcTUtGUVhwBfNWj2aXC+B3LomaMT1V/SoeVfiZ5y6W0a Uta2gt3EGLbFA2JeGzGXIAtyAR8Ef96SWxNni87lRtGfxnMHfkP8cNS5Dn42q3GPw6Ti 4znA== X-Forwarded-Encrypted: i=1; AFNElJ9czAfGFGJatwo0RlOxK9oaU9r4k2LOiu+2KstZlBGjB0xUl8kE9dxmrn6HvXsMryaedmYpzNoZLWNTnYw=@vger.kernel.org X-Gm-Message-State: AOJu0YxTYH6OOPqQ34FiggplZTjXfAdTW32Uo0kjdt5qQ2WLTTZagdWe 7r4bQmmHR74/MdvAPAVaZzrrgC8cv+p0DNS9Ox3X8MGpfCt930zWjUBujvoj1hXU X-Gm-Gg: Acq92OHHnsFeeZYUv8x/TqEXDJ7nTfCtFFkKStV9fSP+V3mx20Spbm1aONVhtVh54A4 GtEydrchjvVqfwA0X0Hz8ipmLV6PD0xb8hk3XBGqRjpo9UAO2AA4OMM9oZAE13tDrQPWfFiAo06 spGZIfexp8QPRgFiN5CE6PG0KMlDNzTd7rA3dQLVjuopP2FPehHsE+grd4O+T3qXXyqFkqbmnda wevR1jxjkwmcVvR6r4goE2ISr1SIkeGsSXdQ7Cel9OPhLkMs8PvKS24zl/S1ARkBmwFiMRf+fc+ EIGw+l7nmG99UCSc39rRuQlprkGFhsNmGZ0r74chu4v6z0L1VFXSCYhRT3QK9GnnCBNk3cAiQhE gs4jSQuz3rJ0+QHpxNfkBRLboVKpmozadMS2RgS+G01ebS8tyiXz35bPvYogr8Yc4XonqDGb3sy gDUqQyVbkM7NvY6f+FJJXzvdg9K399/D4qQtUn+l8ofaorCQaS4myOlzP1coLmLYSQW7xvERZff fz5eMam6au2JiNVqhwQ4Q== X-Received: by 2002:a05:6a00:1d9e:b0:837:f79d:909 with SMTP id d2e1a72fcca58-842b0fbc2efmr16431184b3a.39.1780959161319; Mon, 08 Jun 2026 15:52:41 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8428221d1absm22868140b3a.9.2026.06.08.15.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 15:52:40 -0700 (PDT) Sender: Guenter Roeck Message-ID: <7d51a340-281f-40bd-9574-1f0ab0849ebe@roeck-us.net> Date: Mon, 8 Jun 2026 15:52:40 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3 1/2] watchdog: pika_wdt: fix timer lifecycle bugs To: Rosen Penev , linux-watchdog@vger.kernel.org Cc: Wim Van Sebroeck , open list References: <20260608210402.31545-1-rosenp@gmail.com> <20260608210402.31545-2-rosenp@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260608210402.31545-2-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/8/26 14:04, Rosen Penev wrote: > Two timer lifecycle bugs in the PIKA watchdog driver: > > 1. pikawdt_release() clears the open bit before stopping the timer, > allowing a concurrent pikawdt_open() to start a new timer that > is then immediately deleted. Move clear_bit after the timer > stop. Use timer_shutdown_sync() so the handler cannot re-arm > after the call returns. Add timer_setup() in pikawdt_open() > to re-initialize the timer for the next open. The clear bit is not moved, and the approach is wrong. More on that below. > > 2. pikawdt_exit() unmaps FPGA IO memory without first stopping the > ping timer. If the timer handler fires after iounmap(), it > executes pikawdt_ping() on freed memory. Use timer_shutdown_sync() > which permanently prevents re-arming. > > Assisted-by: opencode:big-pickle > Signed-off-by: Rosen Penev > --- > drivers/watchdog/pika_wdt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c > index 87b8988d2520..d567103ec5e4 100644 > --- a/drivers/watchdog/pika_wdt.c > +++ b/drivers/watchdog/pika_wdt.c > @@ -117,6 +117,7 @@ static int pikawdt_open(struct inode *inode, struct file *file) > if (test_and_set_bit(0, &pikawdt_private.open)) > return -EBUSY; > > + timer_setup(&pikawdt_private.timer, pikawdt_ping, 0); Calling timer_setup() in the open function is wrong because the timer may already be running. > pikawdt_start(); > > return stream_open(inode, file); > @@ -129,7 +130,7 @@ static int pikawdt_release(struct inode *inode, struct file *file) > { > /* stop internal ping */ > if (!pikawdt_private.expect_close) > - timer_delete(&pikawdt_private.timer); > + timer_shutdown_sync(&pikawdt_private.timer); This is wrong here. timer_shutdown_sync() is only supposed to be called if the timer will not be re-enabled. Anything else would be an API violation. > > clear_bit(0, &pikawdt_private.open); > pikawdt_private.expect_close = 0; > @@ -291,6 +292,7 @@ static void __exit pikawdt_exit(void) > { > misc_deregister(&pikawdt_miscdev); > > + timer_shutdown_sync(&pikawdt_private.timer); > iounmap(pikawdt_private.fpga); > } > > -- > 2.54.0 > >