From: "Arnd Bergmann" <arnd@arndb.de>
To: "kernel test robot" <lkp@intel.com>,
"Peter Chen" <peter.chen@cixtech.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
"Pawel Laszczak" <pawell@cadence.com>
Subject: Re: drivers/usb/cdns3/cdnsp-gadget.c:168:9: sparse: sparse: cast from restricted __le32
Date: Sat, 18 Jul 2026 11:30:48 +0200 [thread overview]
Message-ID: <7d51cfb9-0d7a-455f-9bb2-0211b6e9c090@app.fastmail.com> (raw)
In-Reply-To: <202607181505.CVpdSKHV-lkp@intel.com>
On Sat, Jul 18, 2026, at 09:49, kernel test robot wrote:
> sparse warnings: (new ones prefixed by >>)
> drivers/usb/cdns3/cdnsp-gadget.c:166:16: sparse: sparse: cast to
> restricted __le32
> drivers/usb/cdns3/cdnsp-gadget.c:166:16: sparse: sparse: cast to
> restricted __le32
> drivers/usb/cdns3/cdnsp-gadget.c:166:16: sparse: sparse: cast to
> restricted __le32
This is clearly a bug in the driver, introduced in commit
241e2ce88e5a ("usb: cdnsp: Fix issue with resuming from L1"):
> 241e2ce88e5a49 Pawel Laszczak 2025-04-18 165
> 241e2ce88e5a49 Pawel Laszczak 2025-04-18 @166 val =
> le32_to_cpu(readl(reg));
> 241e2ce88e5a49 Pawel Laszczak 2025-04-18 167 val =
> CHICKEN_APB_TIMEOUT_SET(val, cdns->override_apb_timeout);
This is broken on big-endian machines, because readl() contains
an implicit byteswap, and the extra le32_to_cpu() swaps the
value back.
Pawel, can you fix this and address any additional sparse warnings
you see in this file?
Arnd
prev parent reply other threads:[~2026-07-18 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 7:49 kernel test robot
2026-07-18 9:30 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d51cfb9-0d7a-455f-9bb2-0211b6e9c090@app.fastmail.com \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pawell@cadence.com \
--cc=peter.chen@cixtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®