From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20794C7EE30 for ; Mon, 27 Feb 2023 16:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229985AbjB0Qil (ORCPT ); Mon, 27 Feb 2023 11:38:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjB0Qii (ORCPT ); Mon, 27 Feb 2023 11:38:38 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6C429EFC for ; Mon, 27 Feb 2023 08:38:36 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id bt28so6885505wrb.8 for ; Mon, 27 Feb 2023 08:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UdlgcB/Y9MWIyQdrrEyftem3TGdOyYMADGKRIrz+XL4=; b=KhaR/5PFYBZ4e0/PRC2atbQksjLPyXgLZJVUNc/QdjF0faE1bUZtR3FTBZbZimbu4I 0sv2dFi4dPI3UntSAqkpLk954/7hl7pigQbGVhwGvDnhXFWUVujxRBQ1ZojobtjUyAYC 4dfLvyWXnNFKBC/W2ntFo+IiTI+8lIJB0hwG59RF1xx00Z+c1b85fWAXfh6BzR8OsPOA vuFuV77k2jO+uZQUecWr9IiNFbJekfOf0uYASJJVhMUQ0T4nQdNplY08nFqTEaKAYZtg lYlKplNS/6qzuFpkRKmYp3qJQyw/dzF9sH50E7T4yG5tD102EsCiRdfmngXOdKUZ2Al+ Xy3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UdlgcB/Y9MWIyQdrrEyftem3TGdOyYMADGKRIrz+XL4=; b=N0S747QyxaTzqsT+sLNNroDg7OzQ3qUShTwn3NLPAiEDwn6ajAU4EmhIaMziL1orjX A1bD/D1UHH9zRCfQt62uttTp90BvzQSGpyqNVuzyE5RlmvjM4tIGY2cBv+XWaCz/x2yx eJicct8GF0BSXFfJmxXOjlGlcmGqjruvP34kcrc2/oZsUUgm8OxTgD9BwsccuLKOSLTQ pQL8a80Jj7wgLVo7jTGdswzqILvdnBKMZgSZg4TFq/T126Bk9eZihoihnhdQiKakq6EK AvUSnWr6Q2KOgTqsYRzeTzKy0bF2O0oNl1r/BL8wNRxPfarV2mPhML1/ka0eU5vcCNCe MHyw== X-Gm-Message-State: AO0yUKWeniNvFyHhksU0NMbITDjiN3ndZiWi3u71gbW0iW3ttCpcTK4G feviY+AHApIjSYMa6YHz4MaWRg== X-Google-Smtp-Source: AK7set83TuZ0j8uIK5yzlvtwSbF2UceAh+Q/YkwHcVaUWm3uThlwlmN/wPeuy1AW2ayn9bdQwarG7w== X-Received: by 2002:adf:f0cd:0:b0:2c7:d75:373a with SMTP id x13-20020adff0cd000000b002c70d75373amr15215774wro.1.1677515915389; Mon, 27 Feb 2023 08:38:35 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t3-20020a5d6903000000b002c56af32e8csm7691119wru.35.2023.02.27.08.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 08:38:35 -0800 (PST) Message-ID: <7d52af12-0ff8-4bea-22da-596e5bac02e3@linaro.org> Date: Mon, 27 Feb 2023 17:38:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy Content-Language: en-US To: Pavel Machek , Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Markuss Broks , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20230226034424.776084-1-sashal@kernel.org> <20230226034424.776084-2-sashal@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/02/2023 17:27, Pavel Machek wrote: > Hi! > >> From: Markuss Broks >> >> [ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ] >> >> For some reason, the driver adding support for Exynos5420 MIPI phy >> back in 2016 wasn't used on Exynos5420, which caused a kernel panic. >> Add the proper compatible for it. > > This is likely bad idea for 4.14, as that compatible is still in use: I don't understand this. What does it mean? That compatible was used and still is used somewhere... Just because incorrect compatible is used somewhere is not really related whether it should be (or not) replaced with correct compatible. BTW you mentioned v4.14 but AUTOSEL is for v4.19. > > drivers/phy/samsung/phy-exynos-mipi-video.c: .compatible = "samsung,s5pv210-mipi-video-phy", > arch/arm/boot/dts/exynos5420.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > arch/arm/boot/dts/exynos3250.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > arch/arm/boot/dts/exynos4.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > > phy-exynos-mipi-video.c lists other compatibles, too, but with > different data. Best regards, Krzysztof