mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: socketcan@hartkopp.net, Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	kernel@pengutronix.de, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next v8 0/6] move CAN skb headroom content to skb extensions
Date: Tue, 3 Feb 2026 15:40:03 +0100	[thread overview]
Message-ID: <7d544645-8699-409f-89c0-6fc606113627@redhat.com> (raw)
In-Reply-To: <20260201-can_skb_ext-v8-0-3635d790fe8b@hartkopp.net>

On 2/1/26 3:33 PM, Oliver Hartkopp via B4 Relay wrote:
> CAN bus related skbuffs (ETH_P_CAN/ETH_P_CANFD/ETH_P_CANXL) simply contain
> CAN frame structs for CAN CC/FD/XL of skb->len length at skb->data. Those
> CAN skbs do not have network/mac/transport headers nor other such
> references for encapsulated protocols like ethernet/IP protocols.
> 
> To store data for CAN specific use-cases all CAN bus related skbuffs are
> created with a 16 byte private skb headroom (struct can_skb_priv). Using
> the skb headroom and accessing skb->head for this private data led to
> several problems in the past likely due to "The struct can_skb_priv
> business is highly unconventional for the networking stack." [1]
> 
> This patch set aims to remove the unconventional skb headroom usage for CAN
> bus related skbuffs and use the common skb extensions instead.
> 
> [1] https://lore.kernel.org/linux-can/20260104074222.29e660ac@kernel.org/

Could you please share how skb_ext size change with this series?
(possibly breaking down the actual size to each separate extension).

Ideally/hopefully the  skbuff_ext_cache size is not going to change, and
that would ensure that this change will not cause any indirect regressions.

/P


  parent reply	other threads:[~2026-02-03 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-01 14:33 Oliver Hartkopp via B4 Relay
2026-02-01 14:33 ` [PATCH net-next v8 1/6] can: use skb hash instead of private variable in headroom Oliver Hartkopp via B4 Relay
2026-02-01 14:33 ` [PATCH net-next v8 2/6] can: add CAN skb extension infrastructure Oliver Hartkopp via B4 Relay
2026-02-01 14:33 ` [PATCH net-next v8 3/6] can: move ifindex to CAN skb extensions Oliver Hartkopp via B4 Relay
2026-02-01 14:33 ` [PATCH net-next v8 4/6] can: move frame_len " Oliver Hartkopp via B4 Relay
2026-02-01 14:33 ` [PATCH net-next v8 5/6] can: remove private CAN skb headroom infrastructure Oliver Hartkopp via B4 Relay
2026-02-01 14:33 ` [PATCH net-next v8 6/6] can: gw: use can_gw_hops instead of sk_buff::csum_start Oliver Hartkopp via B4 Relay
2026-02-03 14:40 ` Paolo Abeni [this message]
2026-02-03 19:19   ` [PATCH net-next v8 0/6] move CAN skb headroom content to skb extensions Oliver Hartkopp
2026-02-05 10:54     ` Paolo Abeni
2026-02-05 12:37       ` Oliver Hartkopp
2026-02-05 11:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d544645-8699-409f-89c0-6fc606113627@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robin@protonic.nl \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®