From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-spdx@vger.kernel.org" <linux-spdx@vger.kernel.org>
Subject: Re: [PATCH v3] powerpc: Add missing SPDX license identifiers
Date: Fri, 21 Jan 2022 15:34:24 +0000 [thread overview]
Message-ID: <7d551fc7-0b71-dd34-c489-43bf9e337efb@csgroup.eu> (raw)
In-Reply-To: <YerO8MjbXlvbMEsZ@kroah.com>
Le 21/01/2022 à 16:19, Greg Kroah-Hartman a écrit :
> On Fri, Jan 21, 2022 at 03:13:50PM +0000, Christophe Leroy wrote:
>>
>>
>> Le 21/01/2022 à 15:35, Greg Kroah-Hartman a écrit :
...
>>>> @@ -20,16 +16,6 @@
>>>> * respects; for example, they cover modification of the file, and
>>>> * distribution when not linked into another program.)
>>>> *
>>>> - * This file is distributed in the hope that it will be useful, but
>>>> - * WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>>>> - * General Public License for more details.
>>>> - *
>>>> - * You should have received a copy of the GNU General Public License
>>>> - * along with this program; see the file COPYING. If not, write to
>>>> - * the Free Software Foundation, 51 Franklin Street, Fifth Floor,
>>>> - * Boston, MA 02110-1301, USA.
>>>> - *
>>>> * As a special exception, if you link this library with files
>>>> * compiled with GCC to produce an executable, this does not cause
>>>> * the resulting executable to be covered by the GNU General Public License.
>>>
>>> Look at that "special exception", why are you ignoring it here? You
>>> can't do that :(
>>
>> I'm not ignoring it, that's the reason why I left it.
>
> You ignore that part of the license in the SPDX line, why?
>
>> Isn't it the correct way to do ? How should it be done ?
>
> You need to properly describe this in the SPDX line. You did not do so
> here, which means that any tool just looking at the SPDX line would get
> this license wrong.
How do you describe such an exception on the SPDX line then ?
You add " WITH GCC-exception-2.0" to the SPDX line ? Am I understanding
correctly ?
Thanks
Christophe
next prev parent reply other threads:[~2022-01-21 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 11:03 Christophe Leroy
2022-01-21 14:35 ` Greg Kroah-Hartman
2022-01-21 15:13 ` Christophe Leroy
2022-01-21 15:19 ` Greg Kroah-Hartman
2022-01-21 15:34 ` Christophe Leroy [this message]
2022-01-21 16:00 ` Greg Kroah-Hartman
2022-01-21 18:15 ` Segher Boessenkool
2022-01-25 13:47 ` Bradley M. Kuhn
2022-01-21 14:36 ` Greg Kroah-Hartman
2022-01-21 18:09 ` Richard Fontana
2022-01-21 18:17 ` Richard Fontana
2022-01-22 5:20 ` J Lovejoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d551fc7-0b71-dd34-c489-43bf9e337efb@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=benh@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®