From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794501008; b=dKz/WjeW0BjSMsDvIqZn0EtJXbbjqFJ1aGuIfjqbwhSnJ3+NfD/cIxYBpFuApfOg1T8W EIqV8l+nFgxNcaRzI2lfDWUUd9E9EAtvVpEWAm46Fq+DkiHssSB5z1UI6w0UMMN/yTyob dZOvmZlHnZt4HrqQrIJhh2eZH4XuNqkXM1QV3+lvxf2RTJ7kBHcMxythiFNAa8bxM9EBu hp6EFFzpjw8YPtOBdHaD0bYtD+ewKxZIWcuYIcYfEioLsT11VKv9DguO09bGy++KjmlEG zWuy7cJITG6qV81WmyZBNo/rmgSAGOkP67Ka5CC0IVc2puroBE+WkMm7a0BUxIV2LPQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794501008; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-GUID:X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=FQyWXo7MbA+VXzM7rtfZ3B92+0RgCk2H2hIoqilD3YI=; b=bnWfW4fqY7e1n2paUdmFGR7pUoJo6GpAI2sPmF5fLi5mIiO+adp5SSLkSQJdAWIqs1f7 5k16eCFM7eiO792LIEZYy9PySr82qKKId8AjgBfA5vX2GdNExrh9iyu5UfKcMww8OULN+ 6zbYnPlmOPl9oJIk1gZuQp0J9+X/vJJS/fB6L2hIHRVH78eXAm44cC5jeiUtCzCgsBT5Y ybFe+OhQ3Y5natMetarG/rEbvr9tLGkXJW2qSJL8XQCKYvQWAwB3M0ucNj7MSoCGWI63R piEUqdhbk5hz3pDnaYeaqNV/YmP29V2g9NBGbzOSNe0mXeI7pJkh5LYiBtJgXqa7x1A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=XPtpCxoY; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=GvQ0sUl9; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36AE1606A337 for ; Thu, 12 Nov 2026 16:30:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 36AE1606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=XPtpCxoY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=GvQ0sUl9 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6ACFZkAR3180987 for ; Thu, 12 Nov 2026 16:30:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FQyWXo7MbA+VXzM7rtfZ3B92+0RgCk2H2hIoqilD3YI=; b=XPtpCxoYGBLC8Er+ uIHqcOaD0whPuQr2tzN0YMHBaFrykB8FXZmjTh21TIhCP3KU+GefJLHceHePiReY hfECzRZkocWDsHoIEBH1CXoLQwyxzOmDPDBtEQOULXKsOyBEL3HVzztgJ/xmyblW LSjcMBC1pUfk77yeQEY8/mhPUj+QCQlMxg28Q/d+o2dLJvs+EPBX85Pex3h+7rsk jFc07AuZfeBf8N+GWgD7n6vr1sfJoZmkeU8jFkYAoKO77XCu/Y5++YELifR6aURh G4PEBwADlZdW+ih9U7Vl1gHq/TcZYCMP7L+CFzUQj1r9RcnH57VFmgh6KxFEfP5H 2M4jLg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hwc1j17yu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Nov 2026 16:30:05 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3aed1b64104so6374679a91.0 for ; Thu, 12 Nov 2026 08:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794501004; x=1795105804; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FQyWXo7MbA+VXzM7rtfZ3B92+0RgCk2H2hIoqilD3YI=; b=GvQ0sUl9USKpppKxy0RgZEjLN0xsILqFOsIm15birUuVwZSQQXuiBNWSJE/EHCykc9 5eMD2Ws7NgwHasIEeDt7j4Se+F/BJvjHGzB0JODySRGko1MMRSd6S7vQ/6RxFRWw/hQ9 RA6B5V7+mcCrL17JFwDMS0CdR3ru3gAOS+cdQoSP4pzHdKOQab/gu3LcFTvAlzZY3eN0 rqNIp4vjdhV6vjvjnPN83za6LIWDW9jCnXv3R27T/vwFNfPXP+z/B4jrpAqLAVCLPP44 pMLmhgeXGIr31Vgnn/ay5dZsAC24HIm4x/5pFKk6Em2aHSSQW6UaCWQQwXkh/wWJoYUJ P/Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794501004; x=1795105804; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FQyWXo7MbA+VXzM7rtfZ3B92+0RgCk2H2hIoqilD3YI=; b=g0mkItreSbc/Bey02vitD9KV63Oho6JFkAplEk8ib2K1J+p9rgFGU8GS7TLdlOc8Tj oEG0hV7NvzlxOZgWdieAKLuoz3EUGwZ6eNif4ZrCfVrJ3CMCld377c7wKJoPyihKqVen DXpDFK9dX65tpfn5xGibEdqsPEqU0cY2Jvp8mV7fiylxESKREzGe+khZyFWE16ZeOuiT tab/BW9rxjPl2rcO/5Lo9/Wqye0UwdSfFtYZfAM6x2wAjg1qrncgjZbhZhkigvffNF3N 0A67umKhCiMyXtCPJwXHXg6zw1kBBf9hAUgSm1YS1CzCmVqCCXbGIZJd/Wf6xmOMsO2c Tw0A== X-Forwarded-Encrypted: i=1; AL+hErHoGo7jX0kQ1AL1a4yHtsgLLTyJR4uSNMPk352ETu0dm8R7iyCb1Xlg8TxX86hLWESAlmWZJXjtGMGW+js=@vger.kernel.org X-Gm-Message-State: APuU4Z82k4siRukwZ6RFgCyJZRHrVDTlNAdyA/35neBJTq76IYGwMRVK nrBh5fQZaoxnJ6TVE64OmXa1SGrzqng/Ky1QNjPh9BKryE+Kw2QPULJpxnQS/TN25IS39L0QY54 e2xs6LIS4vXs83+0bEKNWME+epS8To+kiDH6g97IMKLBCGFFZyJEAOYzdDJ8bnMuQJ/4= X-Gm-Gg: AYBFou2s76ein8Wk7F9xhLsxrnAmSkFjITqO3tQ8ZdIHPKthX3LHK1y/7yVCnJgmbqT OcF2wUwQjUpKMnsZk77+xARtGwiKsZSGeOxrxoqx+jjzvl3U2pyPzALs4ARxOjU3FlkNQyg1cuI fqYJb874JoUptXPDwU26fBScmnCJOntzUcRuU/UtIc2eW1dk9YVrUgiYq9z/QeDxNeQRTFalJQt TIybkr6L/OQDOuVeWE0RFHUz64vUFVOqgKHiNevZKQwj36WZLzIv8zlXDIKyZZljXaAleTzqaMp rgurZEYMsqAnYi3WuThqWXsa2GBc4s4vBMMbW6q5g9xF/X6Qq0jGsfjvo+ZTIA6lHCZTSJ73YS7 3zmSJ4WQV7yAFDpHfyJ/A771Qg61ETfWkYeKH1IVdqbY/gvLEHqTbhOt4 X-Received: by 2002:a17:90b:5483:b0:3ab:188b:c5bf with SMTP id 98e67ed59e1d1-3b182e9455amr6102034a91.18.1794501004403; Thu, 12 Nov 2026 08:30:04 -0800 (PST) X-Received: by 2002:a17:90b:5483:b0:3ab:188b:c5bf with SMTP id 98e67ed59e1d1-3b182e9455amr6102007a91.18.1794501003901; Thu, 12 Nov 2026 08:30:03 -0800 (PST) Received: from [10.239.124.252] ([152.59.198.216]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b1aeb17853sm78492a91.5.2026.11.12.08.29.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2026 08:30:03 -0800 (PST) Message-ID: <7d55b69e-f1cb-4271-a2ab-2cfd2e1947bb@oss.qualcomm.com> Date: Thu, 12 Nov 2026 21:59:57 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: qcom: sm8650-lpass-lpi: Force runtime suspend on system sleep To: Konrad Dybcio , Bjorn Andersson , Bartosz Golaszewski , Linus Walleij Cc: Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261112-lpass-lpi-system-sleep-v1-1-438cb997e0e9@oss.qualcomm.com> Content-Language: en-US From: Gopi Chandra Sekhar Reddy Kanala In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEyMDA2NSBTYWx0ZWRfXywPVcPQYWVlp SUr71/eOCqEsGxGVWHQelfhNL5G7q+8GvMr5bXB0le1a9CQFKFfkiDIqyjdenIRLzudJKPBm458 zL4lcJWJZ8cNuwXLgTB301W9oIBURqs= X-Proofpoint-ORIG-GUID: 9GcTJhDZLsop6Tl68j6j7CqLAkJwz6q1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEyMDA2NSBTYWx0ZWRfX/i8Rtn6kLsJr dLpd4my7QALXE2031sJRXJp1n2uYYrNc0RhgKMgCRnXJm+QJTOXfmRNb7y3GXCyOl8ZHxkPAxU6 NEeMNksd9adVPktitX07wrHfovgxczZfEVuUzm2o7cgnJim48OMzlyy93pEk8P0ur8NiiLOV/ZA aSZkUrUZWncleNeh0opOugQ8tlIVV82e7PuLaiq8YOlEAkTc9qA7pNNWBXeh+8lULocqsbhHJML Nz6pPBQZ9yo9tmT4eRgZ0jlzobfrdt6wt7sJQEdFLQV9SmuREwl4g2m/vDoM0apdgusCZ3bvXf8 IT4b0qoaQTZpefhs2XBFF3caJg9YhRHSl5g+CUBgcRZp3R3yWdk+YH5ZVp/gXecYpycap45GMEZ svFOoMzoWvWXfp7D2Z9lY02zUc0mjKmV6iU08HfjtYys9BqWkjDhlMHv3JK7ryhHDOQM0H2dx/5 CoJUzP0pPxieMZBySEg== X-Proofpoint-GUID: 9GcTJhDZLsop6Tl68j6j7CqLAkJwz6q1 X-Authority-Analysis: v=2.4 cv=Vqe2kO2n c=1 sm=1 tr=0 ts=6af5e98d cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=oj49PQJ3kor0hQ17X0pI4g==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KVmVSDkxW8-HW0ZFBYUA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-12_02,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611120065 Yes. All the LPASS LPI drivers share lpi_pinctrl_probe(), which manages the clocks through pm_clk with runtime PM, and every SoC driver has the same runtime-only dev_pm_ops, so they should all have the same problem. For v2, I was thinking of two patches: 1. Move the dev_pm_ops into pinctrl-lpass-lpi.c, export it, and use it from all the SoC drivers (no functional change). 2. Add the system sleep callbacks to the shared dev_pm_ops. Would that be okay, or is it preferable to add the system sleep callbacks to each SoC driver instead? I can only test on Glymur CRD (sm8650 driver), so the other SoC drivers would be compile-tested only. Gopi On 12-11-2026 17:27, Konrad Dybcio wrote: > On 11/12/26 11:51 AM, Gopi Chandra Sekhar Reddy Kanala via B4 Relay wrote: >> From: Gopi Chandra Sekhar Reddy Kanala >> >> The LPASS LPI pin controller votes for the LPASS HW_MACRO and HW_DCODEC >> clocks through pm_clk and only implements runtime PM callbacks. Its >> consumers, such as the SoundWire controllers, keep it runtime active >> through their device links. If a consumer is active when system suspend >> starts, or is resumed during it, the runtime PM usage count the PM core >> holds from the prepare phase keeps the pin controller from runtime >> suspending, and both clock votes are held for the whole suspend. On >> Glymur CRD this keeps CX and DDR from collapsing in s2idle. >> >> Use pm_runtime_force_suspend() and pm_runtime_force_resume() as the >> system sleep callbacks so the clocks are always released at system >> suspend. Consumers are suspended before their suppliers, so the pin >> controller goes down after them and comes back before them. >> >> Signed-off-by: Gopi Chandra Sekhar Reddy Kanala >> --- >> Tested on Glymur CRD with next-20261110. When s2idle is entered right >> after playback, the LPI clock votes are now released during suspend, >> after the SoundWire controllers, and restored before them on resume. >> Playback works after resume. >> --- > > Should this extend to all other pinctrl-xxx-lpass-lpi drivers? > > Konrad > >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c >> index bc7889c993d0..e33d4360c094 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c >> +++ b/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c >> @@ -220,6 +220,7 @@ static const struct of_device_id lpi_pinctrl_of_match[] = { >> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match); >> >> static const struct dev_pm_ops lpi_pinctrl_pm_ops = { >> + SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) >> RUNTIME_PM_OPS(pm_clk_suspend, pm_clk_resume, NULL) >> }; >> >> >> --- >> base-commit: 793807ca13bf3072fc6d16ce6d90e9ab9beff2a5 >> change-id: 20261112-lpass-lpi-system-sleep-70c4d2239abe >> >> Best regards,