From: Florian Fainelli <f.fainelli@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH 1/8] watchdog: bcm7038_wdt: Remove #ifdef guards for PM related functions
Date: Tue, 28 Jun 2022 13:09:58 -0700 [thread overview]
Message-ID: <7d561941-b6e2-6a30-b951-8ef9df9c7e79@gmail.com> (raw)
In-Reply-To: <20220628193449.160585-2-paul@crapouillou.net>
On 6/28/22 12:34, Paul Cercueil wrote:
> Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to
> handle the .suspend/.resume callbacks.
>
> These macros allow the suspend and resume functions to be automatically
> dropped by the compiler when CONFIG_SUSPEND is disabled, without having
> to use #ifdef guards. Not using #ifdef guards means that the code is
> always compiled independently of any Kconfig option, and thanks to that
> bugs and regressions are easier to catch.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Confirmed that the exact same code is generated before/after, thanks Paul!
--
Florian
next prev parent reply other threads:[~2022-06-28 20:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 19:34 [PATCH 0/8] watchdog: " Paul Cercueil
2022-06-28 19:34 ` [PATCH 1/8] watchdog: bcm7038_wdt: " Paul Cercueil
2022-06-28 20:02 ` Guenter Roeck
2022-06-28 20:09 ` Florian Fainelli [this message]
2022-06-28 19:34 ` [PATCH 2/8] watchdog: dw_wdt: " Paul Cercueil
2022-06-28 20:02 ` Guenter Roeck
2022-06-28 19:34 ` [PATCH 3/8] watchdog: mtk_wdt: " Paul Cercueil
2022-06-28 20:02 ` Guenter Roeck
2022-06-29 8:25 ` AngeloGioacchino Del Regno
2022-06-28 19:34 ` [PATCH 4/8] watchdog: s3c2410_wdt: " Paul Cercueil
2022-06-28 20:03 ` Guenter Roeck
2022-06-29 7:36 ` Krzysztof Kozlowski
2022-06-28 19:34 ` [PATCH 5/8] watchdog: sama5d4_wdt: " Paul Cercueil
2022-06-28 20:03 ` Guenter Roeck
2022-06-30 8:25 ` Claudiu.Beznea
2022-06-28 19:34 ` [PATCH 6/8] watchdog: st_lpc_wdt: " Paul Cercueil
2022-06-28 20:03 ` Guenter Roeck
2022-06-28 19:34 ` [PATCH 7/8] watchdog: tegra_wdt: " Paul Cercueil
2022-06-28 20:03 ` Guenter Roeck
2022-06-28 19:34 ` [PATCH 8/8] watchdog: wdat_wdt: " Paul Cercueil
2022-06-28 20:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d561941-b6e2-6a30-b951-8ef9df9c7e79@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=paul@crapouillou.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®