Re: [net-next PATCH v4 09/11] net: macb: Move most of mac_config to mac_prepare

["Karumanchi, Vineeth" <vineeth@amd.com>]

On 5/13/2025 10:10 PM, Sean Anderson wrote:
> On 5/13/25 11:29, Karumanchi, Vineeth wrote:
>> Hi Sean,
>>
>> Sorry for the delayed response.
>>
>> We are working on MACB with two internal PCS's (10G-BASER, 1000-BASEX) supporting 1G, 2.5G, 5G, and 10G with AN disabled.
>>
>> I have sent an initial RFC : https://lore.kernel.org/netdev/20241009053946.3198805-1-vineeth.karumanchi@amd.com/
>>
>> Currently, we are working on integrating the MAC in fixed-link and phy-mode.
> 
> I had a look your series and based on the feedback you got I think this
> patch will help you ensure the PCS changes stay separate from the MAC
> stuff. I found it confusing on first read that you were configuring the
> "1G" PCS from the USX PCS callback. I think you are using 1G/2G speeds
> with the "1G" PCS and 5G/10G speeds with the USX PCS?
> 

yes, this patch does help.

The IP was designed to configure all speeds (1G, 2.5G, 5G and 10G) from 
USX registers only, hence we are using USX PCS callback.

> Do you know if there is any public documentation for 10G support
> (even on non-versal SoCs)? That will make it easier to review your
> patch.
> 
> --Sean

The Cadence IP document is internal, but we can share TRM of our board, 
which goes public later this month. I will add the link of it in our 
patch series.

-- 
🙏 vineeth