From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41C3EC433EF for ; Thu, 3 Mar 2022 08:07:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbiCCIIB (ORCPT ); Thu, 3 Mar 2022 03:08:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbiCCIH7 (ORCPT ); Thu, 3 Mar 2022 03:07:59 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6AA81704C1 for ; Thu, 3 Mar 2022 00:07:13 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id q7-20020a7bce87000000b00382255f4ca9so4302874wmj.2 for ; Thu, 03 Mar 2022 00:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=T4kbvdEkJq7G6CWV0LAt8KL4gr8THBwbvBRsRaY/1QQ=; b=M/tb1iQDePqb2cmCw0hU63ea8SHPbgBraIobX1tCakB233EkdlNYqSdYUoLFfOEPTs t5ECrCvd788ldBGHa1nJbxRykpHBaD/HEQGExMpiH5o+y6fJHq3HbMDVIDD2xNJEsSzi O5hoF7fTiPL9/GC6fZ1CNfQLtjhiMrnIapRJosNBhe8s7P794FZnVdV/Wpl9z2+feW3f MgpzrD7p9NfGYUVXfzr5FQDt/Y4OGOwx2Hi50nfkD3tkx0uuzQxuu6NqevUrwDJpMtLW E0+pygTamKjNW+kD/MrM+puuyLqXpryxCWyFRdG8bj6+/jHGIPgu5+ITm8onuR1OtlQw AwbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=T4kbvdEkJq7G6CWV0LAt8KL4gr8THBwbvBRsRaY/1QQ=; b=3qSQXXIVVBf0sMSH+9uPdNUPbizDYFSFnVS/LFd/SezhpPEaIbneYa/pn2Ir8oqbku Zs8eUwkKT39G3ItHkiIe8vzsyZS/bH8TDBYryj/v5FuPZDHDCBIrdUgBuD4LRaQCRx6b RDsCkRG41wmhe8DpkauZTsPeMqHnzrfn/8p7W6GK+eDDMJH0Ajp8NTQrevmvgElF55SN /LaOmPGJL9wEP7D99aoHtNPW2c6affSfneYZRJBrZKtL2GYrE0cDqah1pgxlkHPKwzck xNB/BWGuN9e4sfImwuyVmJheJqjp4IBXVLWcRUvZ6e3BnUkOCqtAUGE9PcTRToPyq00v pNcw== X-Gm-Message-State: AOAM531shVuhZsqP/TYamR99stNQXklkED3nzfRphl5bvIHIeIP51bvk rkmNGFVDwb3ziyNFDjYfqtT5Xg== X-Google-Smtp-Source: ABdhPJxssSWDTS0arUsVI2AtPzFrsJyLEpnlrXh0+Wuj4W0lgc2VDglTI9bvy0zswsg7KY/31OI4Qw== X-Received: by 2002:a05:600c:3546:b0:381:7a9d:eee2 with SMTP id i6-20020a05600c354600b003817a9deee2mr2762176wmq.24.1646294832313; Thu, 03 Mar 2022 00:07:12 -0800 (PST) Received: from ?IPV6:2001:861:44c0:66c0:37d4:6d61:9015:27a5? ([2001:861:44c0:66c0:37d4:6d61:9015:27a5]) by smtp.gmail.com with ESMTPSA id p12-20020a5d48cc000000b001e6114938a8sm1244035wrs.56.2022.03.03.00.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 00:07:11 -0800 (PST) Message-ID: <7d585748-7a41-13ca-60da-20eb4fe78374@baylibre.com> Date: Thu, 3 Mar 2022 09:07:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] clk: Use of_device_get_match_data() Content-Language: en-US To: cgel.zte@gmail.com, mturquette@baylibre.com Cc: sboyd@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot References: <20220303014856.2059307-1-chi.minghao@zte.com.cn> From: Neil Armstrong Organization: Baylibre In-Reply-To: <20220303014856.2059307-1-chi.minghao@zte.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2022 02:48, cgel.zte@gmail.com wrote: > From: Minghao Chi (CGEL ZTE) > > Use of_device_get_match_data() to simplify the code. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi (CGEL ZTE) > --- > drivers/clk/clk-oxnas.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c > index 78d5ea669fea..cda5e258355b 100644 > --- a/drivers/clk/clk-oxnas.c > +++ b/drivers/clk/clk-oxnas.c > @@ -209,15 +209,11 @@ static int oxnas_stdclk_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > const struct oxnas_stdclk_data *data; > - const struct of_device_id *id; > struct regmap *regmap; > int ret; > int i; > > - id = of_match_device(oxnas_stdclk_dt_ids, &pdev->dev); > - if (!id) > - return -ENODEV; > - data = id->data; > + data = of_device_get_match_data(&pdev->dev); > > regmap = syscon_node_to_regmap(of_get_parent(np)); > if (IS_ERR(regmap)) { Acked-by: Neil Armstrong