From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 469B43B634C for ; Tue, 28 Apr 2026 07:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360762; cv=none; b=SxWhS9Bhsar4DmlA/7n7AFELHfFZ5TBsiRj/j1WAQa+8HBSBUCsWf1tGRf9S3WnUYV23uJ+pnn+dK1swqu8sfI27pv8VKSaRNI7InYfzRhgcVWTb17sUwnAjxn0gnxtxvOhv5ZzS0xtSjuJ7susz7B5iuirpKEQqGkzhKXtUk+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360762; c=relaxed/simple; bh=uGVKkyNx81VzhTdaTkMaHJMU/PiYSekfP8+BMfVmHPI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N3GKUfTLkOwGLnUS4sOG2LKoQ8f6r2GnZMLqVQD0XDl7U4R+86MW2rU/OZw1kyMmA50+7A34CFm0or45TWRBaBW+pCNIL2+UBdJPYUgEKIRKPjHltS70N5l0euXoE6VGDpQEzVXuwiNKAQqOdF5+FJpVn525i+pFMmzpzgYOYBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T+liJsDd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IhyHweQr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T+liJsDd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IhyHweQr" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63S2wMB4662905 for ; Tue, 28 Apr 2026 07:19:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QTzlCsJxRzarVSCWMnV2DjTN1aJ/3SZ0E8/5kT1ecwo=; b=T+liJsDdoA04rsFe d53NbqK0ag/2MOtHRHOR06JUiexyDx2gBJ5vQqtxZBJFAdBI/V3oYTNJEeXy/vZI DSl8AGGZTcO6NpLiOJ9sBBn0LkETrNsW/iFF2sRC/gjj/vgw1CLXvr6Mj92FWUSl 6RmbBQPMPtPzVWDL4AujiV155IXqI6pXhASR/WtM+gZ00W8FdgDVo04uk2q+8lFe 61YhHvVvmFBRNs4abwzoHtNQtw5OxiZAX4n6opp+SU116rd9RTQNOMy0dfhyEWmC HiQtPP18TKr7bfpPMjKzMdA1LHHvaCeApk1eyWTUJWBWfKgIjdNdW8EwEnUipXhh SX4wEw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtc5n2qs6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 07:19:20 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35dacc40f92so11177107a91.2 for ; Tue, 28 Apr 2026 00:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777360759; x=1777965559; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QTzlCsJxRzarVSCWMnV2DjTN1aJ/3SZ0E8/5kT1ecwo=; b=IhyHweQr8diL5qYolacKnlBtcTKupotfx/rnq1ObSKHKNpTbG09T1HMgyGUSNsjYu0 Qjoc49ZZ+vioH64jHV1YL+TQxGsCbmTg8KNUZVWIx5fVw7EJCcX12j8rP64ySlIj3KJa iWJ+lVAy6cKY90QGejt3WgCgHHycxxAWi9fb162gKXfvaB+W42bo0FUPdyALcPIQjg9/ xrVnwGexaHonPi05NAr2KarknI/A03/Q0imSfaegSCn1G5tcjJeNWXQj1I8ynocBYbbt N4oOZGTevELIWKdKYHkcctxR1mZcuqkBFMbBrjTL+fWltwpyRZwLQag2L8zsXgRjJfA8 WMVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777360759; x=1777965559; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QTzlCsJxRzarVSCWMnV2DjTN1aJ/3SZ0E8/5kT1ecwo=; b=oY1qgsWvWjAIybME2Fh+ruXlM665ZDhbpxHh3Qanta68rsqAygxsT+iRVY+QVVIVCv qqwiw0fthfKttS1PJhjOn7UsI5S8teWb7yyO3snnu0MxBntyIeVDfxpYvX2HnxZUydUB ij8rB60gnNWRKLPpjxXl6H46aGfz0sJz/5NLElqcHGhuxnOqVXUEwvgz/LqEUuCehFRm lKU+XH6l5HOuo4h5fpvmQtpePWRAWkgN+LG0voUZWMesmzf6Z5TaI1r/ZfN64mODX7bu RTWc3qLLopH92/oFCGvH0mRAzbr8D18SpdZZ81guBxnamGRz9+EX87hGcDtsbJo8esSG VETw== X-Forwarded-Encrypted: i=1; AFNElJ9xdxsD451Ubvg1nvjV4MHO11joTDH0ZAsB7T93cUDo9w71nq+rnx/6yPUdBxjxqlFKbGg0R13ZQB9CPL8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9V+wptYgP/XWAX8K4V1CJWei2rWT1iQpibgZ78mMuU8v0woD4 qwupny+LjVZBecp8rR6FzO3a8bEuLN9gDxBFkjzNC8htZ2aYZwHMVqaAj8yjyAMSPyVzqtR/SRh WEaktQpsrOFxZC8JrHQUy8Epz+wgDdu8zrN3WtNwSjkh/PGxGjW1s+zsE5UTt7Dpl96w= X-Gm-Gg: AeBDieuLFuLfcy/xdPQLU77FwvaAGB+hX5L1yumIV4mnQMjCpL7+mceB17VKJi3nG2l sMu6SYACndGKb2EE+SljsC1lA+N8GYbmH0xkRzB39AJR+HarnPfOPv1AU3OpJpMQ7rb6Is5HNk6 Ej5YaUUxSCsOGmjCakQPfSzJlZXK296kxJOY39z1EE3dnTPHio0OBnLAPKWvaWvzDA3l+4ZQznD O2FrC78Ex/Qqs8crC0GmzhgEvFAFem5S5hyQcnSJIlm454teu9jhRf6FnxeAX3KWmwbwwUbMD43 rV7RSc152CMyfV5iFlacJZFd2v06HDOy9INTo1jQeFi3BhpwfPY9a2cZwkxebPr7fwRJLZV9Jnd V+lOp5h6t6WsO+nL4AMG/c3RY1aYWvHstQeUVt0m+2mvgXBymz6ICVMkxeCQAH3xn1Ggcomry X-Received: by 2002:a17:90b:2790:b0:364:6558:99bf with SMTP id 98e67ed59e1d1-3649202bd08mr2009569a91.14.1777360759269; Tue, 28 Apr 2026 00:19:19 -0700 (PDT) X-Received: by 2002:a17:90b:2790:b0:364:6558:99bf with SMTP id 98e67ed59e1d1-3649202bd08mr2009551a91.14.1777360758856; Tue, 28 Apr 2026 00:19:18 -0700 (PDT) Received: from [10.152.199.23] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3649069c775sm894335a91.0.2026.04.28.00.19.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 00:19:18 -0700 (PDT) Message-ID: <7d59bfa4-ea59-4527-ab5b-1e2350d08de7@oss.qualcomm.com> Date: Tue, 28 Apr 2026 12:49:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath11k: cancel SSR work items during PCI shutdown To: Wei Zhang , jeff.johnson@oss.qualcomm.com Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260404043050.3433754-1-wei.zhang@oss.qualcomm.com> Content-Language: en-US From: Rameshkumar Sundaram In-Reply-To: <20260404043050.3433754-1-wei.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDA2NiBTYWx0ZWRfX7vY6K0sgWbMa FPmjsxQKCoW5yLL0bli/GtQuaRu3RgN3UTciJV0W9UK/wLPXUO/aW72+Vn6FBKDO+WDJXjUUckb wJFifSxp6W9KtZe9Nx1L093fj5M+V/p4a8JMYV0xrx97XPYPAYUIx5iDtbPglhftlymJ7KpLZAt ETHzpBgIBqoSXmvoS6v328SUdGplsl3RcWzem2uxokAXFloPmK2VWgt0BT83Do6p/GbHNEu3yZj Mgk4AmcisA4fkFN1inx/KwDyC5jKnJjSZ0z/111X6nJoPpyqskq7mzWF5LzDT0TJXaUHnLhCjG1 /7rBKTOYEHv7tP6ff3L1P1VYbSUVO+sHy9ck0iXoOctRKDbkPh9F2xnUiQPZgnEX2YizLiQhYQa 79AqxWqRhGH2YaEqemB94rngJURht8ZxkajfshcNvAW1H0CVJo2Ov6Ywyvn3tpeBQ750qUWdgyk ionLEydz/jKnn7w3yUA== X-Proofpoint-GUID: BlfVemw4jAcW_BkzvC3mJIMktqDs2OxM X-Proofpoint-ORIG-GUID: BlfVemw4jAcW_BkzvC3mJIMktqDs2OxM X-Authority-Analysis: v=2.4 cv=ZMfnX37b c=1 sm=1 tr=0 ts=69f05f78 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=G9A0gv2bhTP1aVYgofQA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280066 On 4/4/2026 10:00 AM, Wei Zhang wrote: > A reboot can crash the kernel if it overlaps with WLAN firmware crash > recovery (SSR). The crash is a NULL pointer dereference in the MHI teardown > path while freeing DMA-backed MHI contexts. > > Simplified trace: > dma_free_attrs > mhi_deinit_dev_ctxt [mhi] > ath11k_pci_power_down [ath11k_pci] > ath11k_pci_shutdown [ath11k_pci] > device_shutdown > kernel_restart > > On the host side, SSR is driven by the MHI RDDM callback, which queues > reset_work to perform device recovery. reset_work power-cycles the device > by calling ath11k_hif_power_down() followed by ath11k_hif_power_up(). The > power-down phase deinitializes MHI and frees DMA resources. > > Shutdown/reboot runs fully asynchronously with this RDDM-driven SSR > recovery flow. As a result, the shutdown path > (ath11k_pci_shutdown() -> ath11k_pci_power_down()) can race with the SSR > recovery sequence. > > Fix this by canceling SSR-related work items during PCI shutdown, marking > the device as unregistering, and serializing the RDDM callback path that > checks and queues reset_work. This ensures that no new SSR recovery work > can be queued once teardown has started, and that any in-flight recovery > work is fully synchronized before device power-down, preventing MHI > teardown and DMA resource freeing from running more than once. > > Note: This issue only affects PCI/MHI-based devices. AHB-based ath11k > devices do not queue reset_work in normal SSR flows. > > Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04866.5-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1 > > Fixes: 13da397f884d ("ath11k: add support for device recovery for QCA6390/WCN6855") > Fixes: 5edbb148bc57 ("wifi: ath11k: Add firmware coredump collection support") > Signed-off-by: Wei Zhang Reviewed-by: Rameshkumar Sundaram