From: Xu Kuohai <xukuohai@huaweicloud.com>
To: Florent Revest <revest@chromium.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kpsingh@kernel.org, mark.rutland@arm.com, zlim.lnx@gmail.com,
yhs@meta.com, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf-next v2] arm64,bpf: Support struct arguments in the BPF trampoline
Date: Thu, 11 May 2023 22:22:09 +0800 [thread overview]
Message-ID: <7d5cc151-e6c3-73a9-59c0-c4e5821cec1c@huaweicloud.com> (raw)
In-Reply-To: <20230511140507.514888-1-revest@chromium.org>
On 5/11/2023 10:05 PM, Florent Revest wrote:
> This extends the BPF trampoline JIT to support attachment to functions
> that take small structures (up to 128bit) as argument. This is trivially
> achieved by saving/restoring a number of "argument registers" rather
> than a number of arguments.
>
> The AAPCS64 section 6.8.2 describes the parameter passing ABI.
> "Composite types" (like C structs) below 16 bytes (as enforced by the
> BPF verifier) are provided as part of the 8 argument registers as
> explained in the section C.12.
>
> Signed-off-by: Florent Revest <revest@chromium.org>
> Acked-by: Yonghong Song <yhs@fb.com>
> ---
>
> Diff since v1: The stack layout comment now says "arg reg" instead of "arg".
>
LGTM. Thanks for updating the description.
next prev parent reply other threads:[~2023-05-11 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 14:05 Florent Revest
2023-05-11 14:22 ` Xu Kuohai [this message]
2023-05-15 19:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d5cc151-e6c3-73a9-59c0-c4e5821cec1c@huaweicloud.com \
--to=xukuohai@huaweicloud.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kpsingh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=revest@chromium.org \
--cc=yhs@fb.com \
--cc=yhs@meta.com \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®