From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754145AbcHAPqQ (ORCPT ); Mon, 1 Aug 2016 11:46:16 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:34472 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753837AbcHAPqI (ORCPT ); Mon, 1 Aug 2016 11:46:08 -0400 Subject: Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <1470051608-17080-1-git-send-email-jgross@suse.com> <60e0cea0-cb2d-8398-49bc-fa06720453b7@oracle.com> Cc: david.vrabel@citrix.com From: Boris Ostrovsky Message-ID: <7d60fec4-768a-1c4b-ae1d-04061851308a@oracle.com> Date: Mon, 1 Aug 2016 11:46:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2016 11:44 AM, Juergen Gross wrote: > On 01/08/16 16:10, Boris Ostrovsky wrote: >> On 08/01/2016 07:40 AM, Juergen Gross wrote: >>> There are two functions with name xen_pmu_init() in the kernel. Rename >>> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in >>> arch/x86/xen/pmu.c >>> >>> Signed-off-by: Juergen Gross >> While at it, how about changing xen_properties_init to >> xen_sysfs_properties_init as well for consistency? > I don't mind changing this name, too. Will send V2. Thanks. Actually, there is one more --- xen_compilation_init(). -boris