From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80E55296BA9 for ; Mon, 20 Jul 2026 02:20:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784514012; cv=none; b=IxDcb9uSIlbl6Tky5OIvY+nmwcW2ZB1JUzXnzCms0NanX6SEMEWES65mMvfOOB2Wy1Xn4VoN83G32xIiYtfbrsT4z5ufdMyB7b/d66lHsNFNvmpEuNeJgwrfpmPDY7AL4DJlz4PAVhgwIPFlVCUky6YWG5xMyk0tTjbTZ+v86fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784514012; c=relaxed/simple; bh=r02G33i1kr5LJXa62aRUqX6Y4MEoDKIwQv61lCt4Li0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=R7E5Q2GxyfFrqaHstXksCBfoISZQSxNqfg86v7njbMUJSVeimLA2DfQKJ+O/6utxQ0Zk1Mz41Ca8knmeNRAANbfLVMqfoq/q7nh+gK2uwAEdr/PmYI7IoK3h3Wt41umMI0rvC5zUwpXBVuV+4kjf6T3WiWNPm5hvVMWbuHqTbsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MoWD+ea/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qsdf/fO/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MoWD+ea/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qsdf/fO/" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JNvMEk917802 for ; Mon, 20 Jul 2026 02:20:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WwYCea8We6mdjWm+dC6kPkTmaclY2KKsawC/nEua+YM=; b=MoWD+ea/sFbiCg2X 7GR8vHVuokwWB4yy/3OH9zhziJEkOK9Ft1l32QWhYabo1c0vcPJqAIqOl9kxJKqp uKZGHf29Q3l6vFg2sIf7lmcda7shqXnZ9/QQ2gFehvLLho06wKywqZkC3RPhMPIN ZZHRoUOT/QzzqR91rmBkcSX7j6PsF2lQZ1mFcvUtaAWMu+sb6vrJ3hybPGgwSHbZ xzPjtdHxWS6X/gjGw6MuEEzsk/BWC2m6V2LM5Akg64anM5RBAALwJ7717+yIO8ZW Y5697mrbNV7uWxgeCuq54js4Xk6tKIel8jm7WzhwTqNuWOAqJnbocBqUkWVPVx0t vNh8dw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2af3ym3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 02:20:09 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cce02cb769so81390705ad.1 for ; Sun, 19 Jul 2026 19:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784514008; x=1785118808; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=WwYCea8We6mdjWm+dC6kPkTmaclY2KKsawC/nEua+YM=; b=Qsdf/fO/eky8OKwbH6d05DSm/li7QWJr5OQgHxNVdkOAtRczKNnxhBDZKunXU+3yML 2IWI4gMiGnj93fN75gFJxPNnTuWiGcMfkIvIVMYm3SUupocQH+AVpFqAUqrZnmLCYFBR KVKu8rhU+HN+iPWGMAHXcjNdn3pmtPi8Vu2NvbQ4NNEEttB2jYfL0mSRnvn+HALdgPEr 8PajybjkygW4p3G1jbxuc+g5ainXm4CgKzM22aAwKenfyoDfwVSrLQoWJ0KfLdLreGVO h2RJu8LNElIrrld9SjiVg7fvFf8tonOcpgjx+mut11qDi8F8/nleqAzM2A5em09ZcDXz DPGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784514008; x=1785118808; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=WwYCea8We6mdjWm+dC6kPkTmaclY2KKsawC/nEua+YM=; b=NvI6jl5nwYCgrZUZcG1xfCW/Sa6hi9Ig0bSi+1kPFOlCr4he4beD+rgWXPJ+qRISgJ oHZrPVj+ZGsvatI+A3M3p8gfQ8sS7elijVAK5kOEIzF8vZRbmfTk3qh7SbAkNa108VFA ji/s+Lz2/yaadwic++GxfA2z4RksX+jvtrDJWAXbxIKWaQSDnu2nJoVH0GlYtDswfNI4 EbyNXDvk9W7p96riw2atLjCqAwMMag4bVakcgVE5f6PqcuAvf57kIhkaUzoE5mcjoOr8 hT9nNv0NQllkJE8dvv5Ja7hIIVZ5DHqYdOt4hGRxLaJm+2EK35fI399xQEVG77OG1uZC KagQ== X-Forwarded-Encrypted: i=1; AHgh+Rq34usbM6DldF1+NjgGYO/vYAxme+FT3L9+VMpQZLBi1P/maj+gINYOGxAN2m++B/V4OdycYUEnyC0HDO8=@vger.kernel.org X-Gm-Message-State: AOJu0YxG6Pb59LOaM6OAwrhkazFZY9wc2xfLTRk/jGZmWsrlpup4YPOn 4rejf2k1r8foMCTbzN7lniQtsXGcUd8fQfL82XP4A03yizzo+2ghY/vWMOp5WS/LxuXb/SQi7Zp J6NJBpv0aQLbWC/ujbBQZKBF0ZT5ImSyW1ii7/cbh/rh81Pi/GoVDJLo18jLR33a/pgc= X-Gm-Gg: AfdE7cm9O3fUbzjxnKIqqjGiMia7abe3l3I7IsJeRRY3V8vqMNj0HvHVr45lblZXeZ6 kLs6FmqubGZu8PwasQS5mKqLKlg0DABFt/1YSQYeKoiNnVw9TdNwsHDbOeth2rmEKFns720Zq+s VX6dH12nmLn7bTX9CmtvUc1l+gBDbbyQo0JkUmj68HsCwr51UCp6Kk/8avjpWWOBhiPm3CR8kuo VdvxszQWG2QazN6AeLpF6wRsCX2zUs3wFNpeT885wv5hE788EiH/D8a9UcuQXMhE5LU9USb8hDL ADO8iCU/kpKn6Hmd59oOLaHp9vQmCJJhol6w1lnM+U26TJY4SzY6zC550nWwnWomWpMEuiPyaIS J9GM2T8dyAB077ixHvQ8R+PWw/RgUO88qOtyUhXd6erFOeMjvs0NgTLueuoQOtjRoVPd7E3f2 X-Received: by 2002:a17:903:3b85:b0:2cc:777f:d67c with SMTP id d9443c01a7336-2cf3488b0d2mr126545075ad.13.1784514008108; Sun, 19 Jul 2026 19:20:08 -0700 (PDT) X-Received: by 2002:a17:903:3b85:b0:2cc:777f:d67c with SMTP id d9443c01a7336-2cf3488b0d2mr126544685ad.13.1784514007385; Sun, 19 Jul 2026 19:20:07 -0700 (PDT) Received: from [10.133.33.82] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344b1348sm48167765ad.18.2026.07.19.19.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2026 19:20:06 -0700 (PDT) Message-ID: <7d76cc32-5022-48c1-b33d-f16521ab5b7a@oss.qualcomm.com> Date: Mon, 20 Jul 2026 10:20:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] wifi: ath11k/ath12k: release QMI handles on late init failures To: Guangshuo Li , Jeff Johnson , Pradeep Kumar Chitrapu , Vasanthakumar Thiagarajan , Sathishkumar Muruganandam , Anilkumar Kolli , Ganesh Sesetti , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org References: <20260718074026.3085688-1-lgs201920130244@gmail.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260718074026.3085688-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDAyMiBTYWx0ZWRfX4efNBiC+Q9+r tsgLRX8PZFU73aj50M21iPYLx2olwL0nu5jRf7z2aL5PQjamHtpYqVvsTSe/RRs+3411OP9Fdlx SYTITgHdDs5Vemf5o+Mh2Z7ebG5n9e8= X-Proofpoint-GUID: pY2S1WYyyCxZhv-m5Q5GI8GRDP9XEvtF X-Proofpoint-ORIG-GUID: pY2S1WYyyCxZhv-m5Q5GI8GRDP9XEvtF X-Authority-Analysis: v=2.4 cv=a+sAM0SF c=1 sm=1 tr=0 ts=6a5d85d9 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=9O-bytELmrVEQ99AJk0A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDAyMiBTYWx0ZWRfX8Dy5rk/3Zs6h FIzcQa2FZ/l58QXKht7oCduF8Eg7CEr7S2SpTIZ6bQP+Gr8nPTYOxKa7AD1hp3EXmqb5g/bny3I WUT3jhWuroZFYBK68EMsAL2ECRIN3Xt9tYD/c2tLaO28lLAhPqu8keZLxD+ccFiWoGJDybfcq9Z bf6Vrk8mhhoKwt5uqByWUPqj/iKgPqEGk5kCJrhdAFja1BDrCBCaESoGWif0SNv/CCQ64mT9MGB L4w0Z8wPmTdUONxlLPQ0t9iBzA8u09T+pl23hxALRaH12YgHpw86HdkoayFLChFgq94oilgRC28 gciZrSyC16PZvuWdxe7VXOSKMFbX16SiFDbXm/v7c79RmkQIWSBcc+DNtZ7uwaHk+qA/PUj8zUf 8s8+6GvlHloMuLSApvIKHPb2eq4osiRPcTT47k5CffRwFhPHtsy/8jGWyp3KAeVxXWRrRnPofeL 2Q69VUAD02sD35A6N3A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_08,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200022 On 7/18/2026 3:40 PM, Guangshuo Li wrote: > This series fixes QMI handle leaks in the late initialization failure > paths of ath11k and ath12k. > > Both drivers initialize the QMI handle before allocating the QMI event > workqueue and registering the service lookup. If either of these later > steps fails, the initialized QMI handle is not released. > > Patch 1 fixes the leak in ath11k. > > Patch 2 fixes the leak in ath12k and sets ab->qmi.ab only after QMI > service initialization completes successfully. > > v3: > - Split the ath11k and ath12k changes into separate patches, as > requested by Jeff Johnson. > > v2: > - Set ath12k ab->qmi.ab only after QMI service initialization succeeds, > as suggested by Baochen Qiang. > - Fix the same late initialization QMI handle leak in ath11k, as > suggested by Vasanthakumar Thiagarajan. > - Drop the Reviewed-by tag due to the code changes. > > Guangshuo Li (2): > wifi: ath11k: release QMI handle on late init failures > wifi: ath12k: release QMI handle on late init failures > > drivers/net/wireless/ath/ath11k/qmi.c | 10 ++++++++-- > drivers/net/wireless/ath/ath12k/qmi.c | 13 ++++++++++--- > 2 files changed, 18 insertions(+), 5 deletions(-) > Reviewed-by: Baochen Qiang