From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C4D2FF144 for ; Wed, 22 Jul 2026 12:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784722806; cv=none; b=P8THHJYS8y7auMVn1uNO0Bvl8RQstFBTstGsR6EmOitSFX3IWaakfGk8fv8DZTbsIux6axx5FiNtbAHGs2JfNTgebw13DJjruYeNAl1RvRAVYN06Q6T7AOZn03xtkNTBeYVgPuTp8gaeJRaRNmDrIKgWGEzCkoIq72AUETnABgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784722806; c=relaxed/simple; bh=AgSIsFIB5hJk9F7GwArLvCsxDs8srGNqiUbKoqtKay4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tkE9qw/01rdGAJrbW0EN9ofT+HLh0syN6KjuG1tIp9qY4T8oNBurxQboxnaVaJkKxss+AceW5aBxOi5ONC+Kn7jrYR40+2anzlG2kf35DYS+Krva+iByo2JW7j6M6bdkIdBd8SZkAW4uP3ryGq4ZH+E2EcvNLrO/CVBxFp8adLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=y/zDo6hD; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="y/zDo6hD" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-92e512a9a6bso805930585a.2 for ; Wed, 22 Jul 2026 05:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1784722803; x=1785327603; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5qvzOJZC5dLwV+0rw2sHYPHDnXSJxTaB22HkTCSR960=; b=y/zDo6hDu4vOETYNzk1FPBZ9JiyCBbzON0DOtnGFspPZLqQVHDUrPwSQ7k+iEfWtI7 bYfjbigDggzKwsd68jGxv0zUi870PVr4kmRdIy5AVSbQXeni8aI0gPlffAB62GDPhvDb iVPONW1BLwYxJ9ev0MmoY71KjmpSr+e3gTQofhfHxaxm4/RW4uR2/myGnYfjcXBi6S2+ A3S1Mt2mp0bfbdY4JrIQeLFIUIuqfmnOIE+5h0K/oaiQ4aBm9T8Xss1tJ/BWIEako7hn yF3FmimiRpF5ASDpEYcqFKvMH2VYiz1+urSEmQwls7cI+5SFdbP5zR6jkJWp9+DoeOHz tmOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784722803; x=1785327603; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5qvzOJZC5dLwV+0rw2sHYPHDnXSJxTaB22HkTCSR960=; b=ZIddgo2idwhfp+0070qj2jfYjKwdJTBzvoMg0GfWDHeEIWIy4gRycS43YPHZDvkH54 XPuR4NTV67yXvUUwS6T7DoLSCz/cPzCngbKn/YXPuHI2ax3PjCCbD+xoN+OmWiBNbiS3 GUHk2/Ae7k19R91XNYoKX4cegEdNJqfdr8pk3akkPKAnBG4I0zP6UCc3nRTiEj4AHc+2 54jeKeuQ0QHKOMDCIkwoReVAc5B3HORcXrkYuSzSs6erIpo56xMdjD2wVh3O/osH+hIT 8OrqHY4fAxOg9DQEZdVr/kjMjuGCMxijXzHee52pmH2DTTp85tQrZYIAOysklWsDlm6a 2oew== X-Forwarded-Encrypted: i=1; AHgh+Rqvg7L2FvagR73f7q7jq72BkRAzavY3hlFUSzNe22Cr7e4S+YjoYyn+dJ0z2oxR9liURPzcwBGReYh3q+M=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx/WYO46V03imNtjRScv6NJann4pUn5jRY/Rf6VxZbn2jAkNEr ZbexpnQpcBXkfgoFTkKrypSBd8cuq1756xTqD+/COLwbV9r8O+WbUDfZSsTk4aEf8K4= X-Gm-Gg: AR+sD13WqDww+nkp+IfbLULEu79fNST3Ni48V0pEJqdNrHfkvm9V5G6xUJJXXP3+tqp LhesVhIZ5M+l6w8f/loMdlS/wtXZdVgGXXTzBUY042jv+nqBiosl9yYBmpOtFy0ZDvMrX9WUv0C 72SrbmJGOy3Evv0uIBWVBMGDxdlSkqfGjDgZWmjqaPmALH5yUh4N9BG4pT5plQQ3mZxPj6nGUFT rKqqU7wXQA2F7hcuNwthyTsM3SDxYKOUosAcLYRsTH7Dk4a96TVknp/zK2cEZQ/mLCsoYXSSSDg zFupRa0N/k6VZZ0Okk1kQurfAA6tbxSA34EF0G+VRqKqqD72ZhW3ldhaJkA0oXNniQbxTV4fP4A /a81jGXqDnHJeiJOq3Wz5LjcBu4JAtf65pcFGb6uAKsoeaMxyDIk11DvzLlFbbFYjoHhHLhhc33 DbJQ== X-Received: by 2002:a05:620a:2989:b0:930:f306:8275 with SMTP id af79cd13be357-930f30682bemr389512085a.9.1784722803506; Wed, 22 Jul 2026 05:20:03 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930f68d323asm151978385a.19.2026.07.22.05.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 05:20:03 -0700 (PDT) Message-ID: <7d7938cd-80bb-448b-89d0-6ac6d2717e98@riscstar.com> Date: Wed, 22 Jul 2026 07:20:01 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: spacemit: request IRQ after controller initialization To: Linmao Li , Troy Mitchell , Andi Shyti Cc: Yixun Lan , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev References: <20260722094302.2284191-1-lilinmao@kylinos.cn> Content-Language: en-US From: Alex Elder In-Reply-To: <20260722094302.2284191-1-lilinmao@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/22/26 4:43 AM, Linmao Li wrote: > spacemit_i2c_probe() requests the IRQ before it enables the clocks, resets > the controller and runs init_completion(). If an interrupt is already > pending, the handler runs too early: it reads registers while the clocks > are still off and calls complete() on an uninitialized completion. Request > the IRQ after the controller and completion are initialized, but still > before the adapter is registered. > > Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC") > Signed-off-by: Linmao Li This looks correct. Reviewed-by: Alex Elder > --- > drivers/i2c/busses/i2c-k1.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c > index 51a0c3d80fc9..3fe716cc153d 100644 > --- a/drivers/i2c/busses/i2c-k1.c > +++ b/drivers/i2c/busses/i2c-k1.c > @@ -723,11 +723,6 @@ static int spacemit_i2c_probe(struct platform_device *pdev) > if (i2c->irq < 0) > return dev_err_probe(dev, i2c->irq, "failed to get irq resource"); > > - ret = devm_request_irq(i2c->dev, i2c->irq, spacemit_i2c_irq_handler, > - IRQF_NO_SUSPEND, dev_name(i2c->dev), i2c); > - if (ret) > - return dev_err_probe(dev, ret, "failed to request irq"); > - > clk = devm_clk_get_enabled(dev, "func"); > if (IS_ERR(clk)) > return dev_err_probe(dev, PTR_ERR(clk), "failed to enable func clock"); > @@ -755,6 +750,11 @@ static int spacemit_i2c_probe(struct platform_device *pdev) > > init_completion(&i2c->complete); > > + ret = devm_request_irq(i2c->dev, i2c->irq, spacemit_i2c_irq_handler, > + IRQF_NO_SUSPEND, dev_name(i2c->dev), i2c); > + if (ret) > + return dev_err_probe(dev, ret, "failed to request irq"); > + > platform_set_drvdata(pdev, i2c); > > ret = i2c_add_numbered_adapter(&i2c->adapt);