From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3089920C00C for ; Tue, 24 Mar 2026 04:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774327712; cv=none; b=nAM0D5krbjcs159KCVa5ZzLzaG/RKA6vv33YrlUm88pEGzvzODDMMswWAUvBneN2zOzsz0Q015onOYqaGmCMbbMMiP9lyzpiFDpflqZILW744MtieFJJXk79lPl/pnpR6tPOAif+W+nyECbg3LBC2xzz005lxpZsefdA2U0rah4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774327712; c=relaxed/simple; bh=MqY0rvVxZ8EWepxH1jMTKMbCOC3ejPwoTXI2X/mtWe0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EWchz18/hb9LsOqH+vabT+mkO0SptrY8I8tuSeblhKMcTP+rDat8bnyvoKlV8NxgyI5xAPlTrfzpDsksNaEekMM/Oj+JWTGNdhibXE4rhdwVmeIvw+6MBy9SiRrclpQcA/BeoOpM8W00Eq33SElnVL/iOXRMR1zMZDMmt51gU70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DfwQtmA2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gP9BbTMA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DfwQtmA2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gP9BbTMA" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O3Hqg43934726 for ; Tue, 24 Mar 2026 04:48:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zeigFvaue2fOm1v1THIQ2tyCHptET7HZIXbAdvlVh1g=; b=DfwQtmA2Tol8kT0p AyfPrBdbO7Pg7VbmAULGksQZ6QurwM65gWFE7oNJkgDyzwKoiVeXJLGLiNMwYDw7 P+eI/Aqs3BZsdC5v97cUxj0NqiYgBqoERnwM4UpjDhd36IIpBD6BAQwO1OLCq3DH NoHgCh2U125+kq8tAXfcqg9F7YZe4/j5TGinmJ2UwkcLCD+T/7qLd7PRlgEx0bLq wxQ1C0I25n2+pZSHBg80E34lf0IE+gDgHsQ+8YgC306yGx/3rsqRVP6Twt2cR8oJ ETh71+liKIfWTefm08atbUCwZZbb+bKwPe0lxI/zFjCGsd9xTxTdPKZEJbDrpD03 6BAcQA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d37a0jq30-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 04:48:30 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35ba4bf54beso4463243a91.1 for ; Mon, 23 Mar 2026 21:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774327710; x=1774932510; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zeigFvaue2fOm1v1THIQ2tyCHptET7HZIXbAdvlVh1g=; b=gP9BbTMAD7dLckdvq0sONZnQj+ztBgMGvVXDEf7ErmPyYFUMjMTxmI1AR3eb+Emk3w OBLvaFC8qpMh4DjKagzPDJaha9t+PrhUPv3hB1biya7Yfx8QHYnfAlv9Y2KAbDXldVbj DU1HO+kp6/M9IXl8wdD5DwIEs2rZkoazY0+1QfcdMg8cjMn3UmsJoBhA030SwQqpojQo a3C3Bora9w2SHI8g5nwMvkQ/B/cV7Z9XW3hodDR1nPvJphKRPA/T1JahMUEAItC8CiCf RExsCfprWyZOvP1QnOQ+wDN3vMqYtOEFWH5LlYb8+W54w8HosNR8oJVZmuKPkRgyHR12 evpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774327710; x=1774932510; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zeigFvaue2fOm1v1THIQ2tyCHptET7HZIXbAdvlVh1g=; b=RA4k86hOA6GrKg8v/oVbivUEjJonGKoBP3opVOrPhDiHrpQzdc20v3DaqGUR1u8xZN ZMTJTdtdLySklDZhJkeNiRRe/y45PTeomzuyUHPxybZaK0/SNNZCXQvOOqkVCWi0Mayl 3iJmky+rwVy/777OoVUEY39Gmtr5V6fURCJTJ6lREKIj+94vB9x8Oj/qyTS7ZPvviNyz LZUKaad30h63dsD+Tv0VuSE7332xDm9raVHYIxoLQSJ9IqKB/cpWrWxJ7I/cM5zm7hxJ T9Yo3ZL3wCpQJi9Hsx58d4WfSuCPEf1YpoSuSiAduEly/meyxDu18vGh4VnA+uWVfYPa 5KVg== X-Forwarded-Encrypted: i=1; AJvYcCVLjMSIn4q7VphFQZWWdUCWyebD9rAiU/kuYIO4tJ1cceoHslAOFyfnvxTiV9Qtv9/zaAfLOm3FokjyKgs=@vger.kernel.org X-Gm-Message-State: AOJu0YyhJSfAW0rr4rtjTaiuGFbfZ51Oa9wz7jCWrYiLx/N/I6/pP1g4 Q5mTDfI8guv1m99Fg6dSSctzQLtbhlrSSf5fwl1baBV+uNLvQXf7jhUgqX2ez2jk/6a8K7uj1Wt xEpJUKYO2gGrjkq99pPoJ698CTC0mMKMGDIwcZl2v/tBd6QOrT6+or1cw5pOu5O9isTc= X-Gm-Gg: ATEYQzzkV8Sxj8IdcSCSaYB9GEpkkQ+MVZPxrW5mHy1ncFypGXXREs4W4Rad4dgYLCM L07fL+vV/rgZZiE1hxHIW2CSiO4iYeqxH8zDLO+4UTmCzIq47sJ01b3Jv/v+v0HNTmRRF3llwUl RHTNk/auWRnr9ILXpp1Zffm2+KKQikdPy4G/b9kt3F2vIbNL1MerVM2EtDAC0G3un/X66BNZYOV ha8mhndA+1YT9yApeUD9PV3N130rjsfhbRT8iW6klkOrKvStMhLwgeyW1uU96ZGZJxAeVIK7Tgn mIKalH7iqt1s7NZ+vNLPSBWcjHTo66pcpZwG1HRCvCpwK91oMBN9oqDEze1EzfnuirP3UNBYidt 8sVAQuD16yZqteo0pLQVmmAm0ZJKCEXfIoCthEtjzm8TwaONO6Fm0 X-Received: by 2002:a17:90b:5108:b0:35b:9cd5:232e with SMTP id 98e67ed59e1d1-35bd2ce4493mr13430869a91.29.1774327709481; Mon, 23 Mar 2026 21:48:29 -0700 (PDT) X-Received: by 2002:a17:90b:5108:b0:35b:9cd5:232e with SMTP id 98e67ed59e1d1-35bd2ce4493mr13430834a91.29.1774327708987; Mon, 23 Mar 2026 21:48:28 -0700 (PDT) Received: from [10.217.223.92] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c017477eesm386657a91.1.2026.03.23.21.48.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 21:48:28 -0700 (PDT) Message-ID: <7d797c67-25b6-48c9-b98a-4545de86e45b@oss.qualcomm.com> Date: Tue, 24 Mar 2026 10:18:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-2-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-2-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GIIF0+NK c=1 sm=1 tr=0 ts=69c2179e cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=SBCaeXWvHhY2KLIX7PwA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDAzNyBTYWx0ZWRfXze8UC5PRHPFr O5HFkFoYUxPbVjxbj7HV3dYo2wtuG5mpLg92aqv78U9/zFJSoaVzvYH20CsbJxEowYL/7vjWAZ7 GdxJxORkkePpvxrWys7oo97YMdE/OyP+w8KpWORcJIAcC4dxUOI91D+aUmPMW3A6RLaLZzdfB6L JdES0ZFvU2hE975l5/1wPa4ebJxa3pc4OXo8jix5tPTXfOexQi30YS6YLRRiyjTnr2zX1kQD0l5 EXZwi2Hcc0FyFJw1QvQguzWPTcF4xzmPFCztxa1FdqY+P5DunRLatsmiFMFisihhlVUXZCqhFTY OKQZkqKNiZXozzQDNOUs65FF0uvgxRGfrrTAdcAr91RxHNBo5kbTpMEVlbW2N4Z0pl+EYCH5KSh jHpMsEeg5sZUw8o0oY9Hppke6gTyqIkQk/1EhE5xJpD9k1JSuzmqi3gpwTgwBbkn8E8wTuUCeiT BSa6yXQhQo/wOvZWM3w== X-Proofpoint-GUID: ewXS5hRKIaMcTGjUc-IPL1E5myyji2gK X-Proofpoint-ORIG-GUID: ewXS5hRKIaMcTGjUc-IPL1E5myyji2gK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_01,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240037 On 3/23/2026 2:47 PM, Harshal Dev wrote: > Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver > de-coupled from the QCOM UFS driver, it explicitly votes for its required > clocks during probe. For scenarios where the 'clk_ignore_unused' flag is > not passed on the kernel command line, to avoid potential unclocked ICE > hardware register access during probe the ICE driver should additionally > vote on the 'iface' clock. > Also update the suspend and resume callbacks to handle un-voting and voting > on the 'iface' clock. > > Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep