From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [BUG] Possible bug of missing error return code in __ext4_journalled_writepage()
Date: Tue, 9 Mar 2021 17:40:03 +0800 [thread overview]
Message-ID: <7d7b3a16-74c3-1958-85df-fe6d10ed85be@gmail.com> (raw)
In __ext4_journalled_writepage():
......
inode_bh = ext4_journalled_write_inline_data(inode, len, page);
if (inode_bh == NULL)
goto out;
......
out:
unlock_page(page);
out_no_pagelock:
brelse(inode_bh);
return ret;
When inode_bh is NULL, ret is not assigned with an error code like -ENOENT.
I wonder whether this is intentional? Or ret should be assigned with
-ENOENT here?
Best wishes,
Jia-Ju Bai
reply other threads:[~2021-03-09 9:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d7b3a16-74c3-1958-85df-fe6d10ed85be@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®