From: Tom Zanussi <zanussi@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tracing: Add helper functions to simplify event_command callback handling
Date: Tue, 16 Nov 2021 15:59:01 -0600 [thread overview]
Message-ID: <7d7de7ce5b6e6ab4ae497495f86ad65d86a613dc.camel@kernel.org> (raw)
In-Reply-To: <20211116164120.0db8212b@gandalf.local.home>
On Tue, 2021-11-16 at 16:41 -0500, Steven Rostedt wrote:
> On Fri, 12 Nov 2021 14:23:39 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> >
> > +int event_trigger_check(char *glob, char **trigger, char **param,
> > + bool *remove, bool require_param, bool
> > separate_trigger)
>
> All these functions are going to require having kerneldoc comments
> for
> them. I rather not have to try to figure out what these functions are
> for
> and just read the documentation.
Yeah, that make sense, will add documention for each one in the next
version.
Thanks,
Tom
>
> -- Steve
>
>
> > +{
> > + int ret = 0;
> > +
> > + *remove = (glob && glob[0] == '!') ? true : false;
> > +
next prev parent reply other threads:[~2021-11-16 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 20:23 [PATCH v2 0/2] tracing: Add and use event_command parsing func helpers Tom Zanussi
2021-11-12 20:23 ` [PATCH v2 1/2] tracing: Add helper functions to simplify event_command callback handling Tom Zanussi
2021-11-16 21:41 ` Steven Rostedt
2021-11-16 21:59 ` Tom Zanussi [this message]
2021-11-12 20:23 ` [PATCH v2 2/2] tracing: Have existing event_command implementations use helpers Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d7de7ce5b6e6ab4ae497495f86ad65d86a613dc.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome