From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongxuyang@eswincomputing.com, mturquette@baylibre.com,
sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
huangyifeng@eswincomputing.com
Subject: Re: [PATCH 2/2] clock: eswin: Add eic7700 clock driver
Date: Fri, 23 May 2025 11:15:11 +0200 [thread overview]
Message-ID: <7d8065ee-f8d1-4453-858b-485f7a5216de@kernel.org> (raw)
In-Reply-To: <87874bd2-2fcb-42b3-9e92-cccaa4eaa148@kernel.org>
On 16/05/2025 15:23, Krzysztof Kozlowski wrote:
> On 14/05/2025 02:26, dongxuyang@eswincomputing.com wrote:
>>> +static int eswin_cpu_clk_init(struct platform_device *pdev)
>> +{
>> + struct clk *cpu_clk;
>> + struct device *dev = &pdev->dev;
>> + struct device_node *np = dev->of_node;
>> + u32 default_freq;
>> + int ret = 0;
>> + int numa_id;
>> + char name[128] = { 0 };
>> +
>> + ret = of_property_read_u32(np, "cpu-default-frequency", &default_freq);
>
> NAK, undocumented ABI.
I NAKed your patch and this you translated as reviewed? This is
inappropriate. You just bypass comments and force push your code onto us.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-05-23 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 0:22 [PATCH 0/2] Add driver support for ESWIN eic700 SoC clock controller dongxuyang
2025-05-14 0:25 ` [PATCH 1/2] dt-bindings: clock: eswin: Documentation for eic7700 SoC dongxuyang
2025-05-14 1:20 ` Rob Herring (Arm)
2025-05-15 9:30 ` 董绪洋
2025-05-14 12:43 ` Rob Herring
2025-05-14 0:26 ` [PATCH 2/2] clock: eswin: Add eic7700 clock driver dongxuyang
2025-05-16 13:23 ` Krzysztof Kozlowski
2025-05-23 9:15 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8065ee-f8d1-4453-858b-485f7a5216de@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ningyu@eswincomputing.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®